[Attn Maintainer] json-c

[Attn Maintainer] json-c

[Daisuke Fujimura]

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

Hi,

I previously reported that json-c.pc seems incorrect.
- https://cygwin.com/pipermail/cygwin/2023-August/254350.html

The modified version of json-c.cygport and its CI results are shown below.
- cygport
  - https://cygwin.com/cgit/cygwin-packages/playground/commit/?id=42b2343c88e9ba85dd689579335a77776691bb27
- CI
  - https://github.com/cygwin/scallywag/actions/runs/6286740463

Patch is also attached.

[-- Attachment #2: json-c.cygport.diff --]
[-- Type: application/octet-stream, Size: 675 bytes --]

diff --git a/json-c.cygport b/json-c.cygport
index 0f3bc2a..a0f4195 100644
--- a/json-c.cygport
+++ b/json-c.cygport
@@ -1,7 +1,7 @@
-inherit cmake ninja
+inherit cmake
 NAME="json-c"
 VERSION=0.16
-RELEASE=1
+RELEASE=2
 
 LICENSE="BSD-1-Clause"
 CATEGORY="Libs"
@@ -22,19 +22,11 @@ libjson_c_devel_CONTENTS="usr/include/ usr/lib/"
 
 BUILD_REQUIRES="cmake ninja"
 
-src_compile() {
-	cd ${B}
-	cygcmake -DBUILD_STATIC_LIBS:BOOL=OFF \
-		-DCMAKE_INSTALL_PREFIX:PATH=${D}/usr
-	cygmake
-}
-
-src_install() {
-	cd ${B}
-	cygmake install
-}
+CYGCMAKE_ARGS="
+	-DBUILD_STATIC_LIBS:BOOL=OFF
+"
 
 src_test() {
 	cd ${B}
-	PATH=${B}:${PATH} ctest
+	PATH=${B}:${PATH} ninja_test
 }

Re: [Attn Maintainer] json-c

[Jon Turney]

On 24/09/2023 13:40, Daisuke Fujimura via Cygwin-apps wrote:
> Hi,
> 
> I previously reported that json-c.pc seems incorrect.
> - https://cygwin.com/pipermail/cygwin/2023-August/254350.html
> 
> The modified version of json-c.cygport and its CI results are shown below.
> - cygport
>    - https://cygwin.com/cgit/cygwin-packages/playground/commit/?id=42b2343c88e9ba85dd689579335a77776691bb27
> - CI
>    - https://github.com/cygwin/scallywag/actions/runs/6286740463
> 
> Patch is also attached.

Thanks.

Since Marco isn't available at the moment, I did an NMU with this change.

> -       PATH=${B}:${PATH} ctest
> +       PATH=${B}:${PATH} ninja_test

Not sure if this part is needed.

But it seems like it indicates a missing piece in cygport. Perhaps there 
should be a src_test() defined by the cmake.cygclass which does 
ninja_test or ctest depending on the generator?

Re: [Attn Maintainer] json-c

[Daisuke Fujimura]

src_test is not redefined in cmake.cygclass (and ninja.cygclass) in
cygport-0.36.3. Therefore, I defined src_test in json-c.cygport.

- https://github.com/cygwin/cygport/blob/0.36.6/cygclass/cmake.cygclass
- https://github.com/cygwin/cygport/blob/0.36.6/cygclass/ninja.cygclass

I agree that it would be preferable to have src_test defined in one of
these cygclasses.


On Sun, Oct 1, 2023 at 11:43 PM Jon Turney <jon.turney@dronecode.org.uk> wrote:
>
> On 24/09/2023 13:40, Daisuke Fujimura via Cygwin-apps wrote:
> > Hi,
> >
> > I previously reported that json-c.pc seems incorrect.
> > - https://cygwin.com/pipermail/cygwin/2023-August/254350.html
> >
> > The modified version of json-c.cygport and its CI results are shown below.
> > - cygport
> >    - https://cygwin.com/cgit/cygwin-packages/playground/commit/?id=42b2343c88e9ba85dd689579335a77776691bb27
> > - CI
> >    - https://github.com/cygwin/scallywag/actions/runs/6286740463
> >
> > Patch is also attached.
>
> Thanks.
>
> Since Marco isn't available at the moment, I did an NMU with this change.
>
> > -       PATH=${B}:${PATH} ctest
> > +       PATH=${B}:${PATH} ninja_test
>
> Not sure if this part is needed.
>
> But it seems like it indicates a missing piece in cygport. Perhaps there
> should be a src_test() defined by the cmake.cygclass which does
> ninja_test or ctest depending on the generator?
>

Re: [Attn Maintainer] json-c

[Marco Atzeri]

On 01.10.2023 16:43, Jon Turney via Cygwin-apps wrote:
> On 24/09/2023 13:40, Daisuke Fujimura via Cygwin-apps wrote:
>> Hi,
>>
>> I previously reported that json-c.pc seems incorrect.
>> - https://cygwin.com/pipermail/cygwin/2023-August/254350.html
>>

> 
> Since Marco isn't available at the moment, I did an NMU with this change.
> 
>> -       PATH=${B}:${PATH} ctest
>> +       PATH=${B}:${PATH} ninja_test
> 
> Not sure if this part is needed.
> 
> But it seems like it indicates a missing piece in cygport. Perhaps there 
> should be a src_test() defined by the cmake.cygclass which does 
> ninja_test or ctest depending on the generator?
> 

Thanks Jon

I am also updating to 0.17-1

Regards
Marco