From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by sourceware.org (Postfix) with ESMTPS id B86343858406 for ; Wed, 8 Jun 2022 01:58:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B86343858406 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=php.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-f48.google.com with SMTP id a29so2492599lfk.2 for ; Tue, 07 Jun 2022 18:58:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=U74eRFiXCPDSTont1DYfoyUzUWQsH+g5US4xKx6L+70=; b=uO7y05FUCjWLPycCnww0j9j6DNqsTCpB4ibAiGdRpvpGQj99IHZMTv3chaSMWcDa3z ONwgvZMoy+m3GPnzuNhIXFyDwFETJKKU4wRm1aZVDgBFcMq5a7enzHYmqoNE/WmEVCie fqxbianqLpAC8JdeThfjGNmMdm2kodpGELYPwqWaW7Lypj9jqL8e1k/0XxUFywzMDO5J 6hbrfPBY8Q1u/b3cUEivU/joRHkIuig/rrm+4325CkNCuNd0NznU3stCbkmb7+zeMpDs +58Fa2T/CuJiDKDSbsYwlxjBH6O7SgckhiiCsbRXNDVJZLNjyYBgjZG/qaSX54GojPsB dRsw== X-Gm-Message-State: AOAM5323fI+Pb1M6gLmmhNl62zWw2lrvLIOKel2oXsgIUSpYM5xXF/1b 91xzbPTcYXOiNlZaAwZychYrk7oWxNxovw== X-Google-Smtp-Source: ABdhPJzTJSac/TuhVlP4gMN1dfIby1n4Iye2CuX8nkshmFmou5PXE/QyLDymCpmgDA6s3v0tZS389A== X-Received: by 2002:a05:6512:3682:b0:479:137:5668 with SMTP id d2-20020a056512368200b0047901375668mr23539785lfs.555.1654653501990; Tue, 07 Jun 2022 18:58:21 -0700 (PDT) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com. [209.85.167.44]) by smtp.gmail.com with ESMTPSA id t23-20020a056512209700b00479019e1b66sm3495792lfr.39.2022.06.07.18.58.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jun 2022 18:58:21 -0700 (PDT) Received: by mail-lf1-f44.google.com with SMTP id a29so2492537lfk.2 for ; Tue, 07 Jun 2022 18:58:21 -0700 (PDT) X-Received: by 2002:a05:6512:23a9:b0:479:3249:b69e with SMTP id c41-20020a05651223a900b004793249b69emr11590889lfv.321.1654653501081; Tue, 07 Jun 2022 18:58:21 -0700 (PDT) MIME-Version: 1.0 References: <657aca46-294f-d12f-db27-c4fb4cde2be8@dronecode.org.uk> In-Reply-To: <657aca46-294f-d12f-db27-c4fb4cde2be8@dronecode.org.uk> Reply-To: as@php.net From: as@php.net Date: Tue, 7 Jun 2022 21:58:04 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [ITP] mle To: Jon Turney Cc: as@php.net, "cygwin-apps@cygwin.com" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2022 01:58:26 -0000 Updated the gists. Thank you for the feedback. Adam On Tue, Jun 7, 2022 at 2:30 PM Jon Turney wrote: > > On 06/06/2022 15:33, as-GOAhiB59KME@public.gmane.org wrote: > > Hello all, > > > > I'd like to submit a cygport for mle[0], a text editor. It's available > > on various distros/OSs[1] including Debian, Fedora, FreeBSD, and > > others. It's licensed under ASL 2.0. > > Thanks. > > > A first attempt at a cygport is here[2]. The editor depends on a > > header-only library called uthash which I also attempted to package > > here[3]. The other deps, libpcre2-devel and liblua-devel, are already > > packaged. Is there a way to express a version constraint on the Lua > > dep? It needs 5.4. > > Unfortunately, there is not currently. > > A few comments on the cygport files below. > > > [0] https://github.com/adsr/mle > > [1] https://repology.org/project/mle/versions > > [2] https://gist.github.com/adsr/4ecb4113f2d9c0e4ee389a800c0fd15b > > > NAME="mle" > > VERSION=1.5.0 > > HASH="bc05ec0eee4143d824010c6688fce526550ed508" > > RELEASE=1 > > CATEGORY="Editors" > > SUMMARY="Flexible terminal-based text editor" > > DESCRIPTION="mle is a small, flexible, terminal-based text editor written in C. > > Notable features include: full Unicode support, syntax highlighting, scriptable > > rc file, macros, search and replace (PCRE), window splitting, multiple cursors, > > and integration with various shell commands." > > HOMEPAGE="https://github.com/adsr/mle" > > SRC_URI="https://github.com/adsr/mle/archive/${HASH}.tar.gz" > > Is there some reason why this can't be > "https://github.com/adsr/mle/archive/refs/tags/v1.5.0.tar.gz" ? No reason. Changed back to the v1.5.0 tag plus 2 patches. Also added a src_test function to run the tests. (They pass on my system.) > > > SRC_DIR="mle-${HASH}" > > BUILD_REQUIRES="libpcre2-devel uthash-devel liblua-devel" > > USE_DESTDIR=1 > > I don't think setting USE_DESTDIR=1 is needed as this is the default. > > > > > src_compile() { > > cygmake -j1 > > If this is because the build system can't handle a parallel make, a > comment to that effect here would be good. Thanks for the reminder. The vendorized build (make mle_vendor=1) breaks with parallel make. The normal build does not, so I removed the flag. > > > } > > > > src_install() { > > cd ${S} > > cyginstall prefix=/usr > > } > > > > mle_CONTENTS="usr/bin/mle.exe usr/share/doc usr/lib/debug usr/src/debug" > > This shouldn't list usr/{lib,src}/debug (as those belong in a debuginfo > package), and I don't think you need this line at all, as the default > will do the right thing? > > > [3] https://gist.github.com/adsr/e5e6beb373a427dca9e3093cc31b4cea > > > NAME="uthash-devel" > > Don't do this, because this becomes the name of the source package as well. > > Use NAME="uthash" and then PKG_NAMES="uthash-devel" Updated. > > > VERSION=2.3.0 > > RELEASE=1 > > CATEGORY="Libs" > > SUMMARY="C macros for hash tables and more" > > DESCRIPTION="uthash is a collection of header-only data-structure libraries for > > hash maps (uthash), linked lists (utlist), dynamic arrays (utarray), dynamic > > ring buffers (utringbuffer), intrusive stacks (utstack), and dynamic strings > > (utstring)." > > HOMEPAGE="https://troydhanson.github.io/uthash/" > > SRC_URI="https://github.com/troydhanson/uthash/archive/refs/tags/v${VERSION}.tar.gz" > > ARCH="noarch" > > > > src_compile() { > > true > > } > > > > src_install() { > > cd ${S}/src > > doinclude uthash.h utlist.h utarray.h utringbuffer.h utstack.h utstring.h > > }