From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by sourceware.org (Postfix) with ESMTPS id 94F5A3857008 for ; Fri, 10 Jul 2020 12:25:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 94F5A3857008 Received: by mail-ej1-x644.google.com with SMTP id w16so5837780ejj.5 for ; Fri, 10 Jul 2020 05:25:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=kWgqMbJ+UXPhDSICEPGIC0SYkLWgeGS/fTrQbjMx8Pg=; b=s9jb9QXwiW/k1TgQMXx90cdtHSBjjQq9Vzo7cb+bfvVdNSxnBVXAnYxWXMCF9kruQk N76PRjOVG2JFT/n20tJZl5p1+wEkluG9mqOdNV0epLmmaeZq73GEh6cb27EVj2y+0wlE WelZ5wo9agweG0p87u2ILGNL403rdfL9cxrnf98y/1n7Tb3mbzYMdS7fwytljojXSbTH 2jslhfV0uB5JbXdqDLI4K+k4PDkSn6r+vzR3MHOc9b2WanutII6N3MtW+ygwISear+vV 5Yx5HUbWY/yF4xcALfvedi5l6EhKgUbF71InCPwtTJ3f9kq+WGS+Gz6PltYxXscqdtsr ysWA== X-Gm-Message-State: AOAM533YKXj9wFUwb3yyLrwxYk6skOT+e4Emvvm4HOnmppykptjGZy/6 oJCVyyVzfPIp4d14//MSIy1h6P1WSnt5i4DiZpH7kmRRS7s= X-Google-Smtp-Source: ABdhPJxUX449C8LeUuV6cMCFqbWu2Q/9jd3bfSrDhKvm9pS9EUrke9eg/Hizys4c6ZU3ovpglby9I6vDOwgGPmIhQMM= X-Received: by 2002:a17:906:1455:: with SMTP id q21mr44052205ejc.139.1594383906491; Fri, 10 Jul 2020 05:25:06 -0700 (PDT) MIME-Version: 1.0 References: <136eb766-af71-c758-186b-fd9c98214642@aol.com> In-Reply-To: From: marco atzeri Date: Fri, 10 Jul 2020 14:24:55 +0200 Message-ID: Subject: Re: [ITA] python-imaging To: cygwin-apps@cygwin.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2020 12:25:09 -0000 On Fri, Jul 10, 2020 at 12:28 PM Hamish McIntyre-Bhatty via Cygwin-apps wrote: > > On 10/07/2020 01:20, airplanemath via Cygwin-apps wrote: > >> I tend to use loops like > >> > >> for ver in ${PYTHON_WHEEL_VERSIONS//:/ }; > >> do > >> /usr/bin/python${ver} script > >> done > >> > >> for the tests. Also, I believe ${ARCH} is the same as $(uname -m) here, > >> if you want to streamline the PYTHONPATH definition a bit. Both of > >> those are personal style and you are entirely welcome to ignore this. > Originally it was using a loop like that for the tests, but for some > reason not all of the Python versions I wanted to build for were being > tested that way (it was only doing 3.7 and 3.8). I figure I might as > well use ARCH then, makes it a bit clearer. > >> Other than that, I noticed you're writing your own src_compile and > >> src_install. Is there some reason python_wheel_compile and > >> python_wheel_install aren't working for you? I haven't noticed a problem > >> with either of those functions in the past year or so. (For reference, the > >> value of PYTHON_WHEEL_VERSIONS determines which python versions > >> are compiled: see > >> https://cygwin.github.io/cygport/python-wheel_cygclass.html#robo361). > > Ah, thank you for that link, that clears things up for me. I didn't > realise I could do that. So, I can just set PYTHON_WHEEL_VERSIONS to > "3.6:3.7:3.8" to build for those versions? I guess I don't need the > custom functions that way, that would make things simpler. > > So far I've built for Python 3.6 and newer, should I also be building > for 3.5 or are we not bothered at this point? I am not bothering with 3.5 for my builds. The focus should be to have 3.8 up and running so 3.6:3.7:3.8 are enough > > >> Thank you for taking up this package. > > You're welcome, and thanks for the advice :) > > Hamish Regards Marco