From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13706 invoked by alias); 6 Jun 2016 16:46:18 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 13688 invoked by uid 89); 6 Jun 2016 16:46:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Regarding, H*RU:209.85.218.68, Hx-spam-relays-external:209.85.218.68, itp X-HELO: mail-oi0-f68.google.com Received: from mail-oi0-f68.google.com (HELO mail-oi0-f68.google.com) (209.85.218.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 06 Jun 2016 16:46:00 +0000 Received: by mail-oi0-f68.google.com with SMTP id f12so11955342oig.0 for ; Mon, 06 Jun 2016 09:46:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=6rvZSGy+0CXmYZDODSj0M8k5guP6twHCbhV1s6+u0YQ=; b=RzGzBny6pcre2Ou0gbD5tL/tmc1hedJq/jE4jtun1DyHAdlolf3Y776AXDncIHI4lV RDoyiaKFLjibTuNfQ/lXCOWcDUOXKKhCXk4skCPEU8svBDmFtdC1vk5Xeklc5ViQVgAV Gco1NLuq1oVx72bK8jeiH0itnBbArXQe0cEEFERlL2fLdunvnNckAm89GX9JNDu3K9Wz SyxPWprw3RjLZq3++IS4csRpuD0+tuPuOWCjCry/u3RRpMm6tfOhrExD/dIcMvW461nr MnMLShwI7lpDNuSMJowU7TwVSHTTNvb70MIHIf4mgV//qrFeYqSgrUIXgAWqhwRCfut8 S53w== X-Gm-Message-State: ALyK8tIr5rbQ3ry6ULMvVMvEQoKliBMsqBQrE7jO2vG9xTC7JBAxExHpPw8s8vlY8Ii8o+MHF/0WT8wXy8pqVw== X-Received: by 10.157.5.172 with SMTP id 41mr7737058otd.161.1465231558941; Mon, 06 Jun 2016 09:45:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.48.35 with HTTP; Mon, 6 Jun 2016 09:45:39 -0700 (PDT) In-Reply-To: <8005b674-1e74-a909-50ca-2a0b4fb0e570@gmail.com> References: <8005b674-1e74-a909-50ca-2a0b4fb0e570@gmail.com> From: Marcos Vives Del Sol Date: Mon, 06 Jun 2016 16:46:00 -0000 Message-ID: Subject: Re: [ITP] libsass v3.3.6 To: cygwin-apps@cygwin.com Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00006.txt.bz2 2016-06-06 12:08 GMT+02:00 Marco Atzeri: > builds and packages fine, but I suggest you > > 1) to add > > DIFF_EXCLUDES="VERSION" > > to avoid the useless creation of libsass-3.3.6-1.src.patch Actually the patch isn't useless. It creates a VERSION file which version.sh expects to exist during the building process. Without that file, the library reports version "[na]" instead of the correct 3.3.6. > 2) to move "usr/share/doc" from "libsass0" to "libsass-devel" I've moved it to -devel, so they cygport file now reads: --------------------------------------- # libsass libsass0_SUMMARY="${SUMMARY} (runtime)" libsass0_DESCRIPTION="${DESCRIPTION}" libsass0_CATEGORY="Libs" libsass0_CONTENTS="usr/bin/" # libsass-devel libsass_devel_SUMMARY="${SUMMARY} (development)" libsass_devel_DESCRIPTION="${DESCRIPTION}" libsass_devel_CATEGORY="Libs Devel" libsass_devel_CONTENTS="usr/include/ usr/lib/ usr/share/doc/" --------------------------------------- The updated package is available here: http://mural.uv.es/videlsol/libsass/ > I assume you tested it as per > https://github.com/sass/sass-spec Regarding tests, to be honest, I had not run any before. I tried compiling a few Sass using sassc from Bootstrap v4 and it all went fine, so I assumed it was working as expected. I've just now run them, and there are nine parsing errors (out of around five thousands asserts). The execution and the errors and can be seen here: http://pastebin.com/yTcpK3Pj They are probably nothing to worry about: the libsass library is for the 3.3.x version of the specification, while the spec repository only has tests for 3.4 onwards. I suppose the failing tests are caused by newer features not available in the 3.3.x specification. Regards, -- Marcos Vives Del Sol https://github.com/socram8888 miniLock: NscWdW8fh2E5SBoRtrnXWrDwmQmwaR5awMKE78tQW1Ffx