From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23176 invoked by alias); 31 Dec 2011 10:15:46 -0000 Received: (qmail 23165 invoked by uid 22791); 31 Dec 2011 10:15:46 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-pw0-f43.google.com (HELO mail-pw0-f43.google.com) (209.85.160.43) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 31 Dec 2011 10:15:33 +0000 Received: by pbbb11 with SMTP id b11so11416170pbb.2 for ; Sat, 31 Dec 2011 02:15:32 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.73.104 with SMTP id k8mr101658507pbv.104.1325326531396; Sat, 31 Dec 2011 02:15:31 -0800 (PST) Received: by 10.68.17.193 with HTTP; Sat, 31 Dec 2011 02:15:31 -0800 (PST) In-Reply-To: References: Date: Sat, 31 Dec 2011 10:15:00 -0000 Message-ID: Subject: Re: Cygwin Terminal icon broken on case-sensitive systems From: Andy Koppe To: cygwin-apps@cygwin.com Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com X-SW-Source: 2011-12/txt/msg00089.txt.bz2 On 24 November 2011 16:10, Andy Koppe wrote: > On 24 November 2011 15:42, Andy Koppe wrote: >> I'm afraid there's a problem with the new "Cygwin Terminal" icon >> (which I'm sorry not to have spotted when reviewing the change). >> >> Setup.exe creates the mintty shortcuts with '-i /Cygwin-Terminal.ico', >> yet the icon file it creates is called 'cygwin-terminal.ico', i.e. all >> lowercase. This means that users of systems with case sensitivity >> enabled just get to see a dialog box saying "/usr/bin/mintty: could >> not load icon from '/Cygwin-Terminal.ico'". > > Actually, I take it all back. I'd confused myself by still having a > 'cygwin-terminal.ico' lying around from earlier experiments. Setup.exe > does create it with the correct name. > >> Apparently at least two users have fallen foul of this already: >> >> http://georgik.sinusgear.com/2011/11/23/mintty-resizable-terminal-for-windows/ > > Still leaves the question what's going on there. I think I found what triggered this: with a non-default dpi setting, for some reason the ExtractIconEx function used to load the icon doesn't return a small version of the icon along with the normal one. I (somewhat accidentally) fixed this in 1.0.3 by no longer insisting on a small icon being returned, as it's optional when creating a window class anyway. Andy