From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by sourceware.org (Postfix) with ESMTPS id C931F3858D34 for ; Tue, 14 Jul 2020 19:51:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C931F3858D34 Received: by mail-il1-x132.google.com with SMTP id k6so15262192ili.6 for ; Tue, 14 Jul 2020 12:51:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=99CHD+UMoItIHPMZjhycHtQRbFuvdd6Dbtqep/+w0jM=; b=PV/pLHlgyIXYHldSytQckDkuE7fRzPpdDhmko2fi9j3Rl9kzwXrs9P3tjkjQ/N544o CqHdtH5Rw8PxoFr+qHv/ES5nLwgI02PDQr15sOVlvSnZ6qO3fzKJoURfayCxfxxdIxug cKUG7Q7ONuwnPqPt5/XyTmk0r3oiYR/5qaH1X2qF3TaDHhYWJtRtY6XGa3v7tnOE5dUW asK50Kv7bi12JPI3llMNfm4j6tDo6iNfTVUCMP/8oHvaC5wkO6sY5CJhz6uVYqsXpL0Z 5ryiSlaiovKqzkFV58keAUOtuTh3/B+WglxOw2Fzt7c2jVOWSpYh9Uf+mW2By8rQwm4H JHnQ== X-Gm-Message-State: AOAM533gG3+szRdvrhGcCKCC3M61v1yWVdNO5KHAvdeCVICJTslBdy/E 6CoT4sbioz9bIDin2kCsPT6zfaEazMPr0WJ3zNBRGHqI6mk= X-Google-Smtp-Source: ABdhPJwxJ6LNfE8C/F41QyDUmgLyEBDUJ2We4WH8ar7GaG+HkdmmRFs9C9uMzlnvdTq7hLWL9XCDJIKjGegS8BI3jW8= X-Received: by 2002:a92:dd0b:: with SMTP id n11mr6562238ilm.241.1594756286971; Tue, 14 Jul 2020 12:51:26 -0700 (PDT) MIME-Version: 1.0 References: <877dv6oggo.fsf@Otto.invalid> <87365unjpk.fsf@Otto.invalid> In-Reply-To: <87365unjpk.fsf@Otto.invalid> From: Doug Henderson Date: Tue, 14 Jul 2020 13:51:15 -0600 Message-ID: Subject: Re: [ITP] xxhash 0.7.4-1 To: Cygwin Apps Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, FROM_LOCAL_NOVOWEL, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2020 19:51:29 -0000 On Tue, 14 Jul 2020 at 10:29, ASSI <> wrote: > > ASSI writes: > > By patching the Makefile, just like you need to do for all the other > > stuff from the same author. You can have a look at the zstd packages. > > Come to think of it, xxhash is already part of zstd. Can't you just > link to that? > > > Regards, > Achim. I have patched the Makefile as suggested. The newest version of the dist files as located at https://github.com/djhenderson/Temp/raw/master/xxhash.zip I compared the xxhash sources between the xxhash repo and the zstd repo. There are major differences in the code. This is obvious from wc $ wc -l /usr/src/xxhash.src/xxhash-0.7.4-1.x86_64/origsrc/xxHash-0.7.4/xxhash.c /usr/src/zstd-1.4.5-1.src/zstd-1.4.5-1.x86_64/origsrc/zstd-1.4.5/lib/common/xxhash.c 43 /usr/src/xxhash.src/xxhash-0.7.4-1.x86_64/origsrc/xxHash-0.7.4/xxhash.c 864 /usr/src/zstd-1.4.5-1.src/zstd-1.4.5-1.x86_64/origsrc/zstd-1.4.5/lib/common/xxhash.c 907 total $ wc -l /usr/src/xxhash.src/xxhash-0.7.4-1.x86_64/origsrc/xxHash-0.7.4/xxhash.h /usr/src/zstd-1.4.5-1.src/zstd-1.4.5-1.x86_64/origsrc/zstd-1.4.5/lib/common/xxhash.h 2076 /usr/src/xxhash.src/xxhash-0.7.4-1.x86_64/origsrc/xxHash-0.7.4/xxhash.h 285 /usr/src/zstd-1.4.5-1.src/zstd-1.4.5-1.x86_64/origsrc/zstd-1.4.5/lib/common/xxhash.h 2361 total I had a brief look at the code, but did not attempt to judge the merits of either code base. The zstd repo does not include the xxhsum command which has a similar CLI to cksum, md5sum, sha256sum, etc. Apparently xxhash will use the SSE2 instructions for some operations. Someone with an older CPU without those instructions should test to make sure the xxhsum programs works for them. (I'm just saying that, I don't really know what that means.) Any way, I would like some critical feedback on the dist packaging. Thanks, Doug -- Doug Henderson, Calgary, Alberta, Canada - from gmail.com