public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Balaji Venkataraman <balaji.s.venkataraman@gmail.com>
To: cygwin-apps@cygwin.com
Subject: Fwd: Testing ping for cygwin x86_64
Date: Wed, 23 Oct 2013 05:49:00 -0000	[thread overview]
Message-ID: <CALgEz7r5cf2s0yDcO-9bM8d=693s8wp4VuS-hhEoWdkyz1hfdg@mail.gmail.com> (raw)
In-Reply-To: <CALgEz7oEJ0yyUhLmoyqVxvadXHLFPbr9WTPwAoV0mG1WETR4Rg@mail.gmail.com>

On Thu, Oct 17, 2013 at 11:54 AM, Corinna Vinschen wrote:
> On Oct 17 10:17, Balaji wrote:
>> Hi - since ping appears to be currently orphaned, I wanted to see if I
>> can help out. It being a fairly simple package, definitely aided my
>> decision.
>>
>> I downloaded the source for ping (Cygwin32). While I can't seem to get
>> the provided shell script to run right, I was able to apply the
>> included patch file and build the 32bit version. I tried building the
>> 64bit version which did build and run fine on (Cygwin64 1.7.25). There
>> were a bunch of warnings (even without -Wall) in the 64bit build and I
>> patched them - mostly minor fixes like casts etc. and re-built/tested
>> both versions.
>>
>> So, finally getting to my question - are the rudimentary ping tests
>> that I did, good enough to make this package worthy of release?
>
> I think so, yes.  Just keep in mind that Windows disallows using raw
> sockets for non-admin users, which means that this ping implementation
> will neither work for non-admins, nor for admins running a UAC-crippled
> shell.  This shows up as questions on the Cygwin mailing list once in a
> while, which, as a maintainer, you should be prepared to answer.

Thanks for the reply and the information/guidelines above.

>> This being my first attempt at trying to possibly maintain a Cygwin
>> package, I want make sure I'm doing the right thing. One odd thing is
>> that all of the source code and Makefile are in the patch file. Also,
>> am I free to convert the package to cygport/ditch the shell script
>> etc. - I understand all that may typically be the maintainer's choice?
>> Advance thanks for any advice from you seasoned veterans.
>
> Porting a package to cygport is highly appreciated, no worries.  And of
> course you are free to pack it in a cleaner fashion than the existing
> package.

One other question - I remember there was some discussion about noarch
packages a while ago. Are there any rules for/against making something
a noarch package. And the associated pros/cons - both from a
maintainer and user perspective?

Thanks,
Balaji

  parent reply	other threads:[~2013-10-23  5:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-17 17:17 Balaji Venkataraman
2013-10-17 18:54 ` Corinna Vinschen
     [not found]   ` <CALgEz7oEJ0yyUhLmoyqVxvadXHLFPbr9WTPwAoV0mG1WETR4Rg@mail.gmail.com>
2013-10-23  5:49     ` Balaji Venkataraman [this message]
2013-10-23  7:59       ` Corinna Vinschen
2013-10-23 17:42         ` Christopher Faylor
2013-10-23 18:38           ` Achim Gratz
2013-10-23 19:26             ` Christopher Faylor
2013-10-23 18:46           ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALgEz7r5cf2s0yDcO-9bM8d=693s8wp4VuS-hhEoWdkyz1hfdg@mail.gmail.com' \
    --to=balaji.s.venkataraman@gmail.com \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).