Re: mbed TLS package

[Andy Li <andy@onthewings.net>]

Thanks for the review!
I've just updated the cygport file as suggested:

 * moved the dll files to /usr/bin
 * use DIFF_EXCLUDES to exclude the source changes during building
apidoc and tests
 * do not build/install the programs, which are indeed just demos
according to https://github.com/ARMmbed/mbedtls#example-programs

Let me know if there is anything that can improve :)

Best regards,
Andy

On Sat, Apr 29, 2017 at 5:14 AM, Marco Atzeri <marco.atzeri@gmail.com> wrote:
> On 28/04/2017 07:32, Andy Li wrote:
>>
>> Hi,
>>
>> This is Andy, a member of the Haxe Foundation, which is the
>> organization behind the Haxe programming language [1].
>>
>> I would like to maintain a Cygwin package for Haxe. There are some
>> dependencies not packaged for cygwin, so I am going to package and
>> maintain them as well.
>>
>> The first one I worked on is mbed TLS [2], and the cygport file I
>> created can be found at:
>> https://github.com/andyli/cygwinports-mbedtls
>>
>> It would be great if you can review and let me know if it is up to
>> standard for inclusion in the cygwin.com archive. Please bear with me
>> if there is any silly mistake since this is my first time packaging
>> for Cygwin.
>> FYI, here are the Debian and Fedora packages:
>>  * https://anonscm.debian.org/cgit/collab-maint/mbedtls.git/tree/debian
>>  * http://pkgs.fedoraproject.org/cgit/rpms/mbedtls.git/tree/mbedtls.spec
>>
>> Best regards,
>> Andy
>>
>> [1]: https://haxe.org/
>> [2]: https://tls.mbed.org/
>>
>
> Hi Andy,
>
> the shared library are in the wrong place:
>
>>>> libmbedcrypto0-2.4.2-1.tar.xz
> usr/lib/cygmbedcrypto-0.dll
>
>>>> libmbedtls10-2.4.2-1.tar.xz
> usr/lib/cygmbedtls-10.dll
>
>>>> libmbedx509-0-2.4.2-1.tar.xz
> usr/lib/cygmbedx509-0.dll
>
> On cygwin the shared lib are in /usr/bin .
>
> On my build, documentation was rebuilt and most of the
> source was changed:
>
>>>> Creating source patches
>  apidoc/aes_8h.html                                            |  813
>  apidoc/aes_8h__dep__incl.map                                  |    5
>
>  apidoc/xtea_8h__incl.md5                                      |    1
>  apidoc/xtea_8h_source.html                                    |   64
>  566 files changed, 150300 insertions(+)
>
>
> use DIFF_EXCLUDES="apidoc/*" to avoid to include a source patch file.
>
>
> in the list of binaries, I see some that look as test programs;
> may be they should not be installed ?
>
>         usr/bin/aescrypt2.exe
>    ->   usr/bin/benchmark.exe
>         usr/bin/cert_app.exe
>         usr/bin/cert_req.exe
>         usr/bin/cert_write.exe
>         usr/bin/crl_app.exe
>         usr/bin/crypt_and_hash.exe
>         usr/bin/dh_client.exe
>         usr/bin/dh_genprime.exe
>         usr/bin/dh_server.exe
>         usr/bin/dtls_client.exe
>         usr/bin/dtls_server.exe
>         usr/bin/generic_sum.exe
>         usr/bin/gen_entropy.exe
>         usr/bin/gen_key.exe
>         usr/bin/gen_random_ctr_drbg.exe
>         usr/bin/gen_random_havege.exe
>    ->   usr/bin/hello.exe
>         usr/bin/key_app.exe
>         usr/bin/mini_client.exe
>         usr/bin/mpi_demo.exe
>         usr/bin/pem2der.exe
>         usr/bin/pk_decrypt.exe
>         usr/bin/pk_encrypt.exe
>         usr/bin/pk_sign.exe
>         usr/bin/pk_verify.exe
>         usr/bin/req_app.exe
>         usr/bin/rsa_decrypt.exe
>         usr/bin/rsa_encrypt.exe
>         usr/bin/rsa_genkey.exe
>         usr/bin/rsa_sign.exe
>         usr/bin/rsa_verify.exe
>     ->  usr/bin/selftest.exe
>         usr/bin/ssl_cert_test.exe
>         usr/bin/ssl_client1.exe
>         usr/bin/ssl_client2.exe
>         usr/bin/ssl_fork_server.exe
>         usr/bin/ssl_mail_client.exe
>         usr/bin/ssl_pthread_server.exe
>         usr/bin/ssl_server.exe
>         usr/bin/strerror.exe
>         usr/bin/udp_proxy.exe
>
> I have the impression that neither debian nor fedora install
> any of the programs
>
> https://apps.fedoraproject.org/packages/mbedtls/
>
>