From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by sourceware.org (Postfix) with ESMTPS id F22383885C2E; Mon, 23 Mar 2020 12:07:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F22383885C2E Received: by mail-io1-xd2a.google.com with SMTP id y24so13792267ioa.8; Mon, 23 Mar 2020 05:07:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FEItSaXWj3NhEf1VlTY98O2ZFnN0okMjE1YBLwm7VqQ=; b=in5WvximzRPYbu45PV/my8yjkavlu2ijgpLgnBYXzgJd+ndIxzWklQXOqIu0cBO34j S+37uWq5T22OuHQGung9pfa5ewlvSUmskiuSV9C8NgGGxT2O0D7jVBeU/v24Ou5rrY/G 1aXvGk81jP2RxrRtih5LHRskcSrq2KOV+TjDwO2NloKqtQUexHLk2dF79SOuBMPaJq1Q KwTPKtm6ocmD3L/6p7j01+hJUzIhgxPWLRK/hYS0MLigAaH9OTZYMUsmUPqdKeEghGL/ MK7fp2lLDHUQVS/IlAwcMDHQhECnkSeJ+txoi3CEYVP7q+/YnDmvY3mxJN+KRrtGPh9v bmsA== X-Gm-Message-State: ANhLgQ0QZcFJysR2z7hL/UeIxqh2ZMZrdjLTbKbpNx5XuuRgAqXwGtsr TJ6PNy+8gL2Si56VbQOFaOlKv0qYs9P5ax7Z+8V/PgXha48= X-Google-Smtp-Source: ADFU+vsbupolavIQBbzWpkl+dOisrTSXiD7JDd2EkUi1w5yOILAmT7EY/n3rXic1R/tAug79zwNxMgqz3y6Iljxlxdg= X-Received: by 2002:a02:76c2:: with SMTP id z185mr19693845jab.76.1584965272991; Mon, 23 Mar 2020 05:07:52 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jan Nijtmans Date: Mon, 23 Mar 2020 13:07:41 +0100 Message-ID: Subject: Re: Putting packages up for adoption To: Yaakov Selkowitz Cc: cygapps Content-Type: multipart/mixed; boundary="000000000000146cf805a1847c26" X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin-apps mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Mar 2020 12:07:55 -0000 --000000000000146cf805a1847c26 Content-Type: text/plain; charset="UTF-8" Op zo 22 mrt. 2020 om 23:34 schreef Yaakov Selkowitz: > A word of caution wrt Tcl/Tk for Cygwin: upstream incorrectly treats > Cygwin as a Win32 platform, necessitating extensive patches to make it > comply with *NIX/X11 standards. These patches CANNOT be dropped > without breaking compatibility, since Win32 and X11 APIs do not > interact. Fortunately, Tcl/Tk moves rather slowly, so the existing > patches should serve you well for some time. Yes, I'm aware of that. Of course, I'll be very careful to guarantee 100% binary compatibility. Still, I have some questions. At first, I noted that the current Tcl version is 8.6.8, which is two patchlevels behind (released December 22, 2017, more than 3 years old, while 8.6.10 is released November 21, 2019, 4 months ago). Work to do! So, I tried starting with x86_64-w64-mingw32. Here are my remarks. - There are 7 patches included. Only one of them applies cleanly, the others are not really necessary (Please correct me if I'm wrong. Let's go through them. - tcl-8.5.6-mingw.patch This one is wrong. Changing tools for cross-compilations should be done by "configure ... --host=x86_64-w64-mingw32" - tcl-8.6.1-nativezlib.patch OK. Tcl provides its own zlib.dll, in case it's not available externally. In Cygwin it is available (as "mingw64-x86_64-zlib"), which is prefered. (I added "cygautoreconf", so this patch would be part of "configure") - tcl-8.6.3-autopath.patch Not necessary for building, Only needed when we want to run Tcl in a non-standard installed directory. - tcl-8.6.5-hidden.patch Wrong. This exports some internal symbols, which are not supposed to be exported at all. - tcl-8-6-5-paralle-make-fix.patch Already fixed upstream. Besides, it's for unix/Makefile.in, not for mingw. - tcl-mingw-w64-compatibility.patch Already fixed upstream: - tcl-nativetclsh.patch Only needed when running Tcl, not for building the libraries Further on, I noted the the resulting hints file contains: requires: tcl while I would expect: requires: mingw64-x86_64-zlib Here is my cygport file so far. Thanks for your feedback! Regards, Jan Nijtmans --000000000000146cf805a1847c26 Content-Type: application/octet-stream; name="mingw64-x86_64-tcl.cygport" Content-Disposition: attachment; filename="mingw64-x86_64-tcl.cygport" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k84f81ga0 Q1JPU1NfSE9TVD0ieDg2XzY0LXc2NC1taW5ndzMyIgppbmhlcml0IGNyb3NzCgpOQU1FPSJtaW5n dzY0LXg4Nl82NC10Y2wiClZFUlNJT049OC42LjEwClJFTEVBU0U9MQpDQVRFR09SWT0iRGV2ZWwi ClNVTU1BUlk9IlRjbCBpbnRlcnByZXRlciBmb3IgV2luNjQgdG9vbGNoYWluIgpERVBFTkQ9Im1p bmd3NjQteDg2XzY0LXpsaWIiCkRFU0NSSVBUSU9OPSJUaGlzIHBhY2thZ2UgZG9lcyBOT1QgY29u dGFpbiBjeWd3aW4gYmluYXJpZXMuICBJbnN0ZWFkLCBpdApjb250YWlucyBtc3ZjcnQtbGlua2Vk IGJpbmFyaWVzIChha2EgJ21pbmd3JykuICBJdCBpcyBmb3IgdXNlIHdpdGggdGhlCm1pbmd3NjQt eDg2XzY0LWdjYyBjcm9zcyBjb21waWxlciwgYW5kIGluc3RhbGxzIGludG8gdGhlCi91c3IveDg2 XzY0LXc2NC1taW5ndzMyL3N5cy1yb290L21pbmd3L3tsaWIsaW5jbHVkZX0gZGlyZWN0b3JpZXMu IgpIT01FUEFHRT0iaHR0cHM6Ly93d3cudGNsLnRrLyIKU1JDX1VSST0ibWlycm9yOi8vc291cmNl Zm9yZ2UvdGNsL3RjbC1jb3JlJHtWRVJTSU9OfS1zcmMudGFyLmd6IgpTUkNfRElSPSJ0Y2wke1ZF UlNJT059IgojaHR0cDovL3BrZ3MuZmVkb3JhcHJvamVjdC5vcmcvY2dpdC9ycG1zL21pbmd3LXRj bC5naXQvcGxhaW4vdGNsLTguNi4zLWF1dG9wYXRoLnBhdGNoCiMJaHR0cDovL3BrZ3MuZmVkb3Jh cHJvamVjdC5vcmcvY2dpdC9ycG1zL21pbmd3LXRjbC5naXQvcGxhaW4vdGNsLTguNi41LWhpZGRl bi5wYXRjaAojCWh0dHA6Ly9wa2dzLmZlZG9yYXByb2plY3Qub3JnL2NnaXQvcnBtcy9taW5ndy10 Y2wuZ2l0L3BsYWluL3RjbC04LjYuNS1wYXJhbGxlbC1tYWtlLWZpeC5wYXRjaAojCWh0dHA6Ly9w a2dzLmZlZG9yYXByb2plY3Qub3JnL2NnaXQvcnBtcy9taW5ndy10Y2wuZ2l0L3BsYWluL3RjbC04 LjUuNi1taW5ndy5wYXRjaAojCWh0dHA6Ly9wa2dzLmZlZG9yYXByb2plY3Qub3JnL2NnaXQvcnBt cy9taW5ndy10Y2wuZ2l0L3BsYWluL3RjbC1uYXRpdmV0Y2xzaC5wYXRjaAojCWh0dHA6Ly9wa2dz LmZlZG9yYXByb2plY3Qub3JnL2NnaXQvcnBtcy9taW5ndy10Y2wuZ2l0L3BsYWluL3RjbC1taW5n dy13NjQtY29tcGF0aWJpbGl0eS5wYXRjaApQQVRDSF9VUkk9IgoJaHR0cDovL3BrZ3MuZmVkb3Jh cHJvamVjdC5vcmcvY2dpdC9ycG1zL21pbmd3LXRjbC5naXQvcGxhaW4vdGNsLTguNi4xLW5hdGl2 ZXpsaWIucGF0Y2gKIgoKRElGRl9FWENMVURFUz0iTWFrZWZpbGUgdGNsLmhwaiB0Y2xDb25maWcu c2giCgpzbG90PSR7UFZfTUFKX01JTn0KCnNyY19jb21waWxlKCkgewoJbG5kaXJzCgljZCAke0J9 L3dpbgoJY3lnYXV0b3JlY29uZgoJY3lnY29uZiAtLWVuYWJsZS02NGJpdCAtLWhvc3Q9eDg2XzY0 LXc2NC1taW5ndzMyCgljeWdtYWtlIC1qMSBDWUdQQVRIPWVjaG8KfQoKc3JjX2luc3RhbGwoKSB7 CgljZCAke0J9L3dpbgoJVVNFX0RFU1RESVI9MAoJY3lnaW5zdGFsbAoKCXJtIC1mICR7RH0ke0NS T1NTX0JJTkRJUn0vemxpYjEuZGxsCgoJc2VkIC1pIFwKCQktZSAic3xeXChUQ0xfQlVJTERfTElC X1NQRUNcKT0nLip8XDE9Jy1XbCwke0NST1NTX0xJQkRJUn0vbGlidGNsJHtzbG90Ly8ufS5hJ3wi IFwKCQktZSAic3xeXChUQ0xfU1JDX0RJUlwpPScuKid8XDE9JyR7Q1JPU1NfSU5DTFVERURJUn0v dGNsJHtzbG90fSd8IiBcCgkJLWUgInN8XlwoVENMX0JVSUxEX1NUVUJfTElCX1NQRUNcKT0nLip8 XDE9Jy1XbCwke0NST1NTX0xJQkRJUn0vbGlidGNsc3R1YiR7c2xvdC8vLn0uYSd8IiBcCgkJLWUg InN8XlwoVENMX0JVSUxEX1NUVUJfTElCX1BBVEhcKT0nLiovd2lufFwxPScke0NST1NTX0xJQkRJ Un18IiBcCgkJLWUgInN8XlwoVENMX1NUVUJfTElCX1NQRUNcKT0nLip8XDE9Jy1XbCwtbHRjbHN0 dWIke3Nsb3QvLy59J3wiIFwKCQkke0R9JHtDUk9TU19MSUJESVJ9L3RjbENvbmZpZy5zaCB8fCBl cnJvcgoKCSMgaW5zdGFsbCBwcml2YXRlIGhlYWRlcnMKCWluY2x1ZGVpbnRvIHRjbCR7c2xvdH0v d2luCglkb2luY2x1ZGUgJHtTfS93aW4vKi5oCglpbmNsdWRlaW50byB0Y2wke3Nsb3R9L2dlbmVy aWMKCWRvaW5jbHVkZSAke1N9L2dlbmVyaWMvKi5oCn0K --000000000000146cf805a1847c26--