Re: [ITP] python-getdevinfo

[Hamish McIntyre-Bhatty <hamishmb@live.co.uk>]

[-- Attachment #1.1.1: Type: text/plain, Size: 5551 bytes --]

On 20/08/2020 07:01, Marco Atzeri via Cygwin-apps wrote:
> On 19.08.2020 13:22, Hamish McIntyre-Bhatty via Cygwin-apps wrote:
>> On 19/08/2020 06:53, Marco Atzeri via Cygwin-apps wrote:
>>>
>>> something looks wrong on test
>>>
>>> ======================================================================
>>> ERROR: test_get_info (tests.getdevinfo_tests_cygwin.TestGetInfo)
>>> Test that the information can be collected on this system without error
>>> ----------------------------------------------------------------------
>>> Traceback (most recent call last):
>>>    File
>>> "/pub/tmp/python-getdevinfo-1.1.0-1.src/python-getdevinfo-1.1.0-1.x86_64/src/getdevinfo-1.1.0/getdevinfo/tests/getdevinfo_tests_cygwin.py",
>>>
>>> line 218, in test_get_info
>>>      cygwin.get_info()
>>>    File
>>> "/pub/tmp/python-getdevinfo-1.1.0-1.src/python-getdevinfo-1.1.0-1.x86_64/build/getdevinfo/cygwin.py",
>>>
>>> line 101, in get_info
>>>      get_device_info(disk)
>>>    File
>>> "/pub/tmp/python-getdevinfo-1.1.0-1.src/python-getdevinfo-1.1.0-1.x86_64/build/getdevinfo/cygwin.py",
>>>
>>> line 135, in get_device_info
>>>      cmd = subprocess.run([SMARTCTL, "-i", host_disk, "-j"],
>>> stdout=subprocess.PIPE,
>>>    File "/usr/lib/python3.8/subprocess.py", line 489, in run
>>>      with Popen(*popenargs, **kwargs) as process:
>>>    File "/usr/lib/python3.8/subprocess.py", line 854, in __init__
>>>      self._execute_child(args, executable, preexec_fn, close_fds,
>>>    File "/usr/lib/python3.8/subprocess.py", line 1637, in
>>> _execute_child
>>>      self.pid = _posixsubprocess.fork_exec(
>>> BlockingIOError: [Errno 11] Resource temporarily unavailable
>>>
>>> ----------------------------------------------------------------------
>>> Ran 23 tests in 0.679s
>>>
>>> FAILED (errors=1)
>>> NOTE: These tests won't work correctly without administrator
>>> privileges.
>>>
>>> $ id
>>> uid=197609(Marco) gid=544(Administratoren)
>>> groups=544(Administratoren),197121(Kein)
>>
>>
>> Unfortunately I have not been able to reproduce this issue on my end
>> with either 32-bit or 64-bit Cygwin. What happens when you run
>> "/usr/sbin/smartctl.exe -i /dev/sda -j" (assuming /dev/sda is a disk
>> that Cygwin sees)? Note that the output may include the drive serial
>> number - make sure to blank it out if you post the output here.
>>
>> If this is on 32-bit Cygwin, this looks like the good old fork bug to
>> me, seeing as you're getting "11 Resource temporarily unavailable" when
>> attempting to fork. I can't remember what worked to fix that for me the
>> last time I had it, might have been antivirus software exceptions. I
>> would say that maybe some packages need updating, but given you've been
>> releasing packages in the last few days, I highly doubt your Cygwin
>> install is out of date.
>>
>> If the smartctl command works, could you try running the tests again
>> please?
>>
>> Hamish
>>
>
> /usr/sbin/smartctl.exe -i /dev/sda -j
>
> {
>   "json_format_version": [
>     1,
>     0
>   ],
>   "smartctl": {
>     "version": [
>       7,
>       1
>     ],
>     "svn_revision": "5022",
>     "platform_info": "x86_64-pc-cygwin-w10-b19041",
>     "build_info": "(cygwin-7.1-1)",
>     "argv": [
>       "smartctl",
>       "-i",
>       "/dev/sda",
>       "-j"
>     ],
>     "exit_status": 0
>   },
>   "device": {
>     "name": "/dev/sda",
>     "info_name": "/dev/sda",
>     "type": "ata",
>     "protocol": "ATA"
>   },
>   "model_family": "Seagate Mobile HDD",
>   "model_name": "ST1000LM035-1RK172",
>   "serial_number": "WL10S143",
>   "wwn": {
>     "naa": 5,
>     "oui": 3152,
>     "id": 2907615223
>   },
>   "firmware_version": "RSM7",
>   "user_capacity": {
>     "blocks": 1953525168,
>     "bytes": 1000204886016
>   },
>   "logical_block_size": 512,
>   "physical_block_size": 4096,
>   "rotation_rate": 5400,
>   "form_factor": {
>     "ata_value": 3,
>     "name": "2.5 inches"
>   },
>   "in_smartctl_database": true,
>   "ata_version": {
>     "string": "ACS-3 T13/2161-D revision 3b",
>     "major_value": 2032,
>     "minor_value": 31
>   },
>   "sata_version": {
>     "string": "SATA 3.1",
>     "value": 127
>   },
>   "interface_speed": {
>     "max": {
>       "sata_value": 14,
>       "string": "6.0 Gb/s",
>       "units_per_second": 60,
>       "bits_per_unit": 100000000
>     },
>     "current": {
>       "sata_value": 3,
>       "string": "6.0 Gb/s",
>       "units_per_second": 60,
>       "bits_per_unit": 100000000
>     }
>   },
>   "local_time": {
>     "time_t": 1597901572,
>     "asctime": "Thu Aug 20 07:32:52 2020 CEST"
>   }
> }
>
> no change on test error messages, also rebuilding from scratch in an
> Admin enviroment
>
Hmm, that's unfortunate. I tried on another different machine, still
can't reproduce.

I'll get it to retry a few times if the fork error is encountered, but I
do wonder why it's happening at all. I've always seemed to have
intermittent Fork errors with Cygwin but I've never managed to pin down
exactly why it happens.

I'll update the packages with some error handling for that issue, and
some debugging code so we can see in more detail what's going wrong.

Hamish


[-- Attachment #1.1.2: 0x87B761FE07F548D6.asc --]
[-- Type: application/pgp-keys, Size: 3235 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]