From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-4319.protonmail.ch (mail-4319.protonmail.ch [185.70.43.19]) by sourceware.org (Postfix) with ESMTPS id A947C3858C27 for ; Wed, 13 Jul 2022 02:56:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A947C3858C27 Date: Wed, 13 Jul 2022 02:56:18 +0000 To: Jon Turney From: William Hu Cc: "cygwin-apps@cygwin.com" Reply-To: William Hu Subject: Re: [ITA] ocaml 4.14.0 Message-ID: In-Reply-To: <452a0d68-1caf-e618-9107-af1b66366142@dronecode.org.uk> References: <452a0d68-1caf-e618-9107-af1b66366142@dronecode.org.uk> Feedback-ID: 51238035:user:proton MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_4DyaC5XoTGQMTqHOh9mvXW9u3t7pc0UsbvkEsNSuOY" X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_INFOUSMEBIZ, KAM_NUMSUBJECT, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2022 02:56:33 -0000 This is a multi-part message in MIME format. --b1_4DyaC5XoTGQMTqHOh9mvXW9u3t7pc0UsbvkEsNSuOY Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Apologies, meant to click reply-all. Hi Jon, Thanks for all of the detailed feedback - I'll test the package more thoroughly next time. 1) libcamlrun: Oops, that's another oversight, forgot to look at the old patches. The other 3 patches seem unnecessary, but I had trouble linking either libcamlrun_shared.so or libcamlrun_shared.dll.a into a program (unresolved symbol errors). Added but it possibly needs further patching. I'll keep on digging. 1.5) I checked for other differences between the cygports to make sure I didn't miss anything else. I made some edits to src_install: I removed `dod= oc Updating` since there doesn't seem to be a file named "Updating". I also removed symlinking header files to /usr/include. From what I understood, t= he OCaml documentation says the headers should "reside in the caml/ subdirect= ory of the OCaml standard library directory, which is returned by the command ocamlc -where (usually /usr/local/lib/ocaml or /usr/lib/ocaml)". Obviously = the symlink doesn't move anything, but since their location is well documented= I didn't see a reason to have the extra symlinks. Please let me know if this= is too large of a change or there's a Cygwin (or non-Cygwin) convention that precludes this - I'm still getting the hang of this. 2) fma on x86: I'm actually getting the same error, but the tests should ostensibly pass on Cygwin32. I'll also look into this. 3) Interesting - on my machine, the camlheader[di] files had the .exe extensions. I did some digging around and found the files are *built* witho= ut the .exe suffix, and even *initially installed* without the .exe suffix, b= ut ultimately come out with the .exe suffix. I ran cyport in debug mode and apparently the files are being renamed with the suffix post-install: + case "${exe##*/}" in + mv usr/lib/ocaml/camlheaderd usr/lib/ocaml/camlheaderd.exe + exe+=3D.exe and did a little more digging and I think these lines in cygport are the cause: https://github.com/cygwin/cygport/blob/096f27644bd3b28f29d7522e816bebd327cf= 24cb/lib/src_postinst.cygpart#L1010 On the topic of "testing more thoroughly", I attempted to use ocamlc to compile a simple program and it fails with "Cannot find file camlheader" bu= t works when I remove the ".exe", so it seems that the presence of the .exe suffixes breaks the compiler. Is there a way to prevent cygport from adding it? 4) Thanks for the catch. Added --enable-ocamltest to the cygport. William ------- Original Message ------- On Tuesday, July 5th, 2022 at 3:44 PM, Jon Turney wrote: > On 05/07/2022 01:42, William Hu via Cygwin-apps wrote: > > > Hi Jon, > > > > Oops, sorry about that. The patch and updated cygport are now attached. > > Sending SSH key shortly. > > > Thanks. > > Firstly, I notice that you dropped 4.10.0-libcamlrun_shared.patch. Can > you explain the reasoning behind that? > > (After a bit of digging, I found this mail > https://cygwin.com/pipermail/cygwin/2010-October/191524.html which > explains the rationale behind it) > > Next, when I try to build this: > > on x86: > > > checking whether fma works... no > > configure: error: fma does not work, enable emulation with --enable-imp= recise-c99-float-ops > > > I guess perhaps that configure option needs to be conditionally used on x= 86? > > > > > > ocaml-runtime-4.14.0-1.tar.xz > > > > > usr/bin/ocamlrun.exe > > > > > usr/bin/ocamlrund.exe > > > > > usr/bin/ocamlruni.exe > > > > > tar: usr/lib/ocaml/camlheader[di].exe: Cannot stat: No such file = or directory > > [...] > > > tar: Exiting with failure status due to previous errors > > *** ERROR: Binary package creation failed: ocaml-runtime > > > camlheader[di] are made without the .exe extensions (you've changed the > cygport to add the exe, so maybe this was wrong before as they are > executables) > > I'm not sure if that's a missing bit of patching or something different > in your environment? > > > $ cygport ocaml.cygport test > > > > > > > Testing ocaml-4.14.0-1.x86_64 > > > > > Makefile:162: *** ocamltest not found in ../ocamltest. Stop. > > > > > make: *** [Makefile:156: all] Error 2 > > > > > *** ERROR: make failed > > > Seems like this requires the --enable-ocamltest configure option? --b1_4DyaC5XoTGQMTqHOh9mvXW9u3t7pc0UsbvkEsNSuOY Content-Type: application/octet-stream; name=ocaml.cygport Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=ocaml.cygport TkFNRT0ib2NhbWwiClZFUlNJT049NC4xNC4wClJFTEVBU0U9MQpDQVRFR09SWT0iT0NhbWwiClNV TU1BUlk9Ik9DYW1sIGNvbXBpbGVycyIKREVTQ1JJUFRJT049Ik9DYW1sIGlzIGEgZmFzdCBtb2Rl cm4gdHlwZS1pbmZlcnJpbmcgZnVuY3Rpb25hbCBwcm9ncmFtbWluZwpsYW5ndWFnZSBkZXNjZW5k ZWQgZnJvbSB0aGUgTUwgKE1ldGEgTGFuZ3VhZ2UpIGZhbWlseSwgZmVhdHVyaW5nIG9iamVjdHMs Cm1vZHVsZXMsIGFuZCBhIGhpZ2gtcGVyZm9ybWFuY2UgbmF0aXZlLWNvZGUgY29tcGlsZXIuIFRo ZSBPQ2FtbCBjb21waWxlciBpcwpkZXZlbG9wZWQgYnkgYSB3b3JsZHdpZGUgZGlzdHJpYnV0ZWQg dGVhbSBjb29yZGluYXRlZCBieSB0aGUgR2FsbGl1bQpwcm9qZWN0LXRlYW0gYXQgSW5yaWEgUGFy aXMtUm9jcXVlbmNvdXJ0LiIKSE9NRVBBR0U9Imh0dHBzOi8vb2NhbWwub3JnLyIKTElDRU5TRT0i TEdQTC0yLjEtb3ItbGF0ZXIiCkJVSUxEX1JFUVVJUkVTPSJmbGV4ZGxsIgpTUkNfVVJJPSJodHRw czovL2dpdGh1Yi5jb20vb2NhbWwvb2NhbWwvYXJjaGl2ZS8ke1ZFUlNJT059LnRhci5neiIKUEFU Q0hfVVJJPSIKCTQuMTQuMC1jb25maWd1cmUtY2ZsYWdzLnBhdGNoCgk0LjE0LjAtbGliY2FtbHJ1 bl9zaGFyZWQucGF0Y2gKIgoKT0NBTUxfTElCRElSPS91c3IvbGliL29jYW1sCktFRVBESVJTPSIk e0R9L3Vzci9saWIvb2NhbWwvb2NhbWxkb2MvY3VzdG9tIgoKUEtHX05BTUVTPSIke05BTUV9ICR7 TkFNRX0tcnVudGltZSAke05BTUV9LWNvbXBpbGVyLWxpYnMgJHtOQU1FfS1vY2FtbGRvYyAke05B TUV9LXNvdXJjZSAke05BTUV9LWRvYyIKb2NhbWxfT0JTT0xFVEVTPSJvY2FtbC1iYXNlIGVtYWNz LW9jYW1sIgpvY2FtbF9SRVFVSVJFUz0iZmxleGRsbCAke05BTUV9LXJ1bnRpbWUiCm9jYW1sX0NP TlRFTlRTPSIKCS0tZXhjbHVkZT1jYW1saGVhZGVyW2RpXS5leGUKCS0tZXhjbHVkZT1jb21waWxl ci1saWJzCgktLWV4Y2x1ZGU9b2NhbWxkb2MqCgktLWV4Y2x1ZGU9b2NhbWxydW4qCgktLWV4Y2x1 ZGU9c3R1YmxpYnMKCS0tZXhjbHVkZT0qLm1sCgktLWV4Y2x1ZGU9Ki5jbWEKCS0tZXhjbHVkZT0q LmNtaQoJLS1leGNsdWRlPSouY21vCgl1c3IvYmluL2N5ZypydW5fc2hhcmVkLmRsbAoJdXNyL2Jp bi9vY2FtbCoKCSR7T0NBTUxfTElCRElSIy99LwoJdXNyL3NoYXJlL2RvYy8ke05BTUV9LwoJdXNy L3NoYXJlL21hbi9tYW4xLwoiCm9jYW1sX3J1bnRpbWVfU1VNTUFSWT0iT0NhbWwgYnl0ZWNvZGUg cnVudGltZSIKb2NhbWxfcnVudGltZV9DT05URU5UUz0iCgl1c3IvYmluL29jYW1scnVuKgoJJHtP Q0FNTF9MSUJESVIjL30vY2FtbGhlYWRlcltkaV0uZXhlCgkke09DQU1MX0xJQkRJUiMvfS8qLmNt W2Fpb10KCSR7T0NBTUxfTElCRElSIy99L3N0dWJsaWJzLwoJJHtPQ0FNTF9MSUJESVIjL30vdGhy ZWFkcy8qLmNtW2FpXQoJdXNyL3NoYXJlL21hbi9tYW4xL29jYW1scnVuKgoiCm9jYW1sX2NvbXBp bGVyX2xpYnNfU1VNTUFSWT0iT0NhbWwgY29tcGlsZXIgaW50ZXJuYWxzIgpvY2FtbF9jb21waWxl cl9saWJzX1JFUVVJUkVTPSR7TkFNRX0Kb2NhbWxfY29tcGlsZXJfbGlic19DT05URU5UUz0iJHtP Q0FNTF9MSUJESVIjL30vY29tcGlsZXItbGlicy8iCm9jYW1sX29jYW1sZG9jX1NVTU1BUlk9Ik9D YW1sIGRvY3VtZW50YXRpb24gZ2VuZXJhdG9yIgpvY2FtbF9vY2FtbGRvY19DT05URU5UUz0iCgl1 c3IvYmluL29jYW1sZG9jKgoJJHtPQ0FNTF9MSUJESVIjL30vb2NhbWxkb2MvCgl1c3Ivc2hhcmUv bWFuL21hbjEvb2NhbWxkb2MqCiIKb2NhbWxfc291cmNlX1NVTU1BUlk9Ik9DYW1sIHN0YW5kYXJk IGxpYnJhcnkgc291cmNlcyIKb2NhbWxfc291cmNlX0NPTlRFTlRTPSIke09DQU1MX0xJQkRJUiMv fS8qLm1sIgpvY2FtbF9kb2NfU1VNTUFSWT0iT0NhbWwgQVBJIGRvY3VtZW50YXRpb24iCm9jYW1s X2RvY19DT05URU5UUz0idXNyL3NoYXJlL21hbi9tYW4zLyIKCnNyY19jb21waWxlKCkgewoJbG5k aXJzCgljZCAke0J9CgkuL2NvbmZpZ3VyZSAtLXByZWZpeD0vdXNyIC0tZW5hYmxlLW9jYW1sdGVz dCB8fCBlcnJvciAiY29uZmlndXJlIGZhaWxlZCIKCWN5Z21ha2UKfQoKc3JjX3Rlc3QoKSB7IDoK CWNkICR7Qn0vdGVzdHN1aXRlCgljeWdtYWtlIGFsbAp9CgpzcmNfaW5zdGFsbCgpIHsKCWNkICR7 Qn0KCWN5Z2luc3RhbGwKfQo= --b1_4DyaC5XoTGQMTqHOh9mvXW9u3t7pc0UsbvkEsNSuOY Content-Type: application/octet-stream; name=4.14.0-libcamlrun_shared.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=4.14.0-libcamlrun_shared.patch LS0tIG9yaWdzcmMvb2NhbWwtNC4xNC4wL3J1bnRpbWUvTWFrZWZpbGUJMjAyMi0wMy0yOCAwODoy NzozNi4wMDAwMDAwMDAgLTA0MDAKKysrIHNyYy9vY2FtbC00LjE0LjAvcnVudGltZS9NYWtlZmls ZQkyMDIyLTA3LTEwIDIyOjM3OjA2LjMzODcxNTAwMCAtMDQwMApAQCAtNzQsOSArNzQsOSBAQAog aWZlcSAiJChVTklYX09SX1dJTjMyKSIgInVuaXgiCiBpZmVxICIkKFNVUFBPUlRTX1NIQVJFRF9M SUJSQVJJRVMpIiAidHJ1ZSIKIEJZVEVDT0RFX1NUQVRJQ19MSUJSQVJJRVMgKz0gbGliY2FtbHJ1 bl9waWMuJChBKQotQllURUNPREVfU0hBUkVEX0xJQlJBUklFUyArPSBsaWJjYW1scnVuX3NoYXJl ZC4kKFNPKQorQllURUNPREVfU0hBUkVEX0xJQlJBUklFUyArPSBsaWJjYW1scnVuX3NoYXJlZC5k bGwuYQogTkFUSVZFX1NUQVRJQ19MSUJSQVJJRVMgKz0gbGliYXNtcnVuX3BpYy4kKEEpCi1OQVRJ VkVfU0hBUkVEX0xJQlJBUklFUyArPSBsaWJhc21ydW5fc2hhcmVkLiQoU08pCitOQVRJVkVfU0hB UkVEX0xJQlJBUklFUyArPSBsaWJhc21ydW5fc2hhcmVkLmRsbC5hCiBlbmRpZgogZW5kaWYKIApA QCAtMTY0LDYgKzE2NCw3IEBACiBpZm5lcSAiJChCWVRFQ09ERV9TSEFSRURfTElCUkFSSUVTKSIg IiIKIAkkKElOU1RBTExfUFJPRykgJChCWVRFQ09ERV9TSEFSRURfTElCUkFSSUVTKSAiJChJTlNU QUxMX0xJQkRJUikiCiBlbmRpZgorCSQoSU5TVEFMTF9QUk9HKSBjeWdhc21ydW5fc2hhcmVkLmRs bCBjeWdjYW1scnVuX3NoYXJlZC5kbGwgIiQoSU5TVEFMTF9CSU5ESVIpIgogCW1rZGlyIC1wICIk KElOU1RBTExfSU5DRElSKSIKIAkkKElOU1RBTExfREFUQSkgY2FtbC9kb21haW5fc3RhdGUudGJs IGNhbWwvKi5oICIkKElOU1RBTExfSU5DRElSKSIKIApAQCAtMjk0LDYgKzI5NSw5IEBACiBsaWJj YW1scnVuX3NoYXJlZC4kKFNPKTogJChsaWJjYW1scnVucGljX09CSkVDVFMpCiAJJChNS0RMTCkg LW8gJEAgJF4gJChCWVRFQ0NMSUJTKQogCitsaWJjYW1scnVuX3NoYXJlZC5kbGwuYTogJChsaWJj YW1scnVucGljX09CSkVDVFMpCisJJChNS0RMTCkgLW8gY3lnY2FtbHJ1bl9zaGFyZWQuZGxsIC1s aW5rIC1XbCwtLW91dC1pbXBsaWIsJEAgJF4gJChCWVRFQ0NMSUJTKQorCiBsaWJhc21ydW4uJChB KTogJChsaWJhc21ydW5fT0JKRUNUUykKIAkkKGNhbGwgTUtMSUIsJEAsICReKQogCkBAIC0zMDks NiArMzEzLDkgQEAKIGxpYmFzbXJ1bl9zaGFyZWQuJChTTyk6ICQobGliYXNtcnVucGljX09CSkVD VFMpCiAJJChNS0RMTCkgLW8gJEAgJF4gJChOQVRJVkVDQ0xJQlMpCiAKK2xpYmFzbXJ1bl9zaGFy ZWQuZGxsLmE6ICQobGliYXNtcnVucGljX09CSkVDVFMpCisJJChNS0RMTCkgLW8gY3lnYXNtcnVu X3NoYXJlZC5kbGwgLWxpbmsgLVdsLC0tb3V0LWltcGxpYiwkQCAkXiAkKEJZVEVDQ0xJQlMpCisK ICMgVGFyZ2V0LXNwZWNpZmljIHByZXByb2Nlc3NvciBhbmQgY29tcGlsZXIgZmxhZ3MKIAogJS5i ZC4kKE8pOiBPQ19DUFBGTEFHUyArPSAkKE9DX0RFQlVHX0NQUEZMQUdTKQo= --b1_4DyaC5XoTGQMTqHOh9mvXW9u3t7pc0UsbvkEsNSuOY--