Is it my setup or the mirror page that is wrong as to the current status of a mirror

Is it my setup or the mirror page that is wrong as to the current status of a mirror

[Brian Keener]

My install of setup on my Windows XP laptop always looks to the mirror 
sourceware.mirrors.tds.net (ftp) and ftp.gtlib.gatech.edu(ftp) for its 
updates and the web page http://www.cygwin.com/mirrors.html shows these 
mirror current as of 2008-08-29 13:48GMT and yet if I run a setup 
version compiled from cvs in July 2007 or a setup I compiled on 
8/21/2008 from cvs it always tells me that the site 
sourceware.mirrors.tds.net (ftp) is not current.  I also just 
downloaded the version at cygwin.com and it also says that site is not 
current.  Weird thing is this machine (Windows XP) also uses the gatech 
site as I mentioned and I don't get warned about it but....  On another 
machine (Windows 2000) which only uses the gatech site 
ftp.gtlib.gatech.edu(ftp) I do get warned about gatech.

I seem to recall something about the mirror logic changing but I'm 
sure. Anyone else noticed anything.

bk

RE: Is it my setup or the mirror page that is wrong as to the current status of a mirror

[Dave Korn]

Brian Keener wrote on 29 August 2008 19:40:

> My install of setup on my Windows XP laptop always looks to the mirror
> sourceware.mirrors.tds.net (ftp) and ftp.gtlib.gatech.edu(ftp) for its
> updates and the web page http://www.cygwin.com/mirrors.html shows these
> mirror current as of 2008-08-29 13:48GMT and yet if I run a setup
> version compiled from cvs in July 2007 or a setup I compiled on
> 8/21/2008 from cvs it always tells me that the site
> sourceware.mirrors.tds.net (ftp) is not current.

  Can't reproduce.

>  I also just
> downloaded the version at cygwin.com and it also says that site is not
> current.

  Did likewise; can't reproduce.

>  Weird thing is this machine (Windows XP) also uses the gatech
> site as I mentioned and I don't get warned about it but....  On another
> machine (Windows 2000) which only uses the gatech site
> ftp.gtlib.gatech.edu(ftp) I do get warned about gatech.

  Still can't reproducee.

> I seem to recall something about the mirror logic changing but I'm
> sure. Anyone else noticed anything.

  As above.  Do you have a duff caching proxy somewhere inline, perhaps?

    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....

Re: Is it my setup or the mirror page that is wrong as to the current status of a mirror

[Brian Keener]

Dave Korn wrote:
> > I seem to recall something about the mirror logic changing but I'm
> > sure. Anyone else noticed anything.
> 
>   As above.  Do you have a duff caching proxy somewhere inline, perhaps?

Thanks for checking - I'll dig deeper on my side.  I have to plead 
ignorance on "duff caching proxy" though.  To my knowledge I am not using 
a proxy and I'm not familiar with the term duff caching?

bk

Re: Is it my setup or the mirror page that is wrong as to the current status of a mirror

[Sylvain RICHARD]

Brian Keener wrote:
> Dave Korn wrote:
>   
>>> I seem to recall something about the mirror logic changing but I'm
>>> sure. Anyone else noticed anything.
>>>       
>>   As above.  Do you have a duff caching proxy somewhere inline, perhaps?
>>     
>
> Thanks for checking - I'll dig deeper on my side.  I have to plead 
> ignorance on "duff caching proxy" though.  To my knowledge I am not using 
> a proxy and I'm not familiar with the term duff caching?
>
> bk
>
>
>   
Ahem,

My 0.02 € to facilitate parsing:
duff (caching proxy)

Sylvain

Re: Is it my setup or the mirror page that is wrong as to the current status of a mirror

[Brian Keener]

Dave Korn wrote:
> > My install of setup on my Windows XP laptop always looks to the mirror
> > sourceware.mirrors.tds.net (ftp) and ftp.gtlib.gatech.edu(ftp) for its
> > updates and the web page http://www.cygwin.com/mirrors.html shows these
> > mirror current as of 2008-08-29 13:48GMT and yet if I run a setup
> > version compiled from cvs in July 2007 or a setup I compiled on
> > 8/21/2008 from cvs it always tells me that the site
> > sourceware.mirrors.tds.net (ftp) is not current.
> 
>   Can't reproduce.

I think I found a clue and have a hunch what is happening.  I checked the 
mirrors-lst file that was downloaded the last time I ran setup on the 
windows XP machine (which has been warning me about sourceware).  I found 
these line at the end of the mirrors-lst file:

# Following mirrors re-added by setup.exe to warn again about dropped urls.
ftp://sourceware.mirrors.tds.net/pub/sourceware.org/cygwin;sourceware.mirro
rs.tds.net;North America;Wisconsin

If I remove these line then the mirror check proceeds as normal and no 
warning occurs.  I looked at my Windows 2000 machine and found a similar 
line for the gatech mirror which when removed from the mirror-lst file the 
warning goes away in setup on that machine as well.  I then left the line 
there and started setup and the line stays with the updated mirrors-lst 
file leading me to believe that setup is copying those lines each time from 
the old mirrors-lst file to the new.  My hunch is that at some point that 
line got in the mirror-lst file because the mirror was out of date and then 
each time I get the warning dialog I respond to Yes I want to continue 
using the mirror and I do not check "do not warn me again".  My guess is 
that I get the warning because the lines are there and that setup does not 
reaffirm that the lines need to be there.

Thoughts?

bk

Re: Is it my setup or the mirror page that is wrong as to the current status of a mirror

[Brian Keener]

Brian Keener wrote:
> these line at the end of the mirrors-lst file:
> 
> # Following mirrors re-added by setup.exe to warn again about dropped urls.
> ftp://sourceware.mirrors.tds.net/pub/sourceware.org/cygwin;sourceware.mirro
> rs.tds.net;North America;Wisconsin
> 
> If I remove these line then the mirror check proceeds as normal and no 
> warning occurs.  I looked at my Windows 2000 machine and found a similar 
> line for the gatech mirror which when removed from the mirror-lst file the 
> warning goes away in setup on that machine as well.  I then left the line 
> there and started setup and the line stays with the updated mirrors-lst 
> file leading me to believe that setup is copying those lines each time from 
> the old mirrors-lst file to the new.  My hunch is that at some point that 
> line got in the mirror-lst file because the mirror was out of date and then 
> each time I get the warning dialog I respond to Yes I want to continue 
> using the mirror and I do not check "do not warn me again".  My guess is 
> that I get the warning because the lines are there and that setup does not 
> reaffirm that the lines need to be there.

These lines patched into site.cc seem to fix the above problem.  Not sure why it 
keep insisting on leaving the line there in mirrors-lst but this patch causes a 
double check so that mirror gets cleaned up and doesn't keep warning you even when 
the mirror is current again:

Index: site.cc
===================================================================
RCS file: /cvs/cygwin-apps/setup/site.cc,v
retrieving revision 2.44
diff -u -p -r2.44 site.cc
--- site.cc     8 Apr 2008 23:50:54 -0000       2.44
+++ site.cc     5 Sep 2008 20:13:48 -0000
@@ -501,13 +501,21 @@ int check_dropped_mirrors (HWND h)
          SiteList::iterator j = find (cached_site_list.begin(),
                                       cached_site_list.end(), *n);
          if (j != cached_site_list.end())
-           {
-             log (LOG_PLAIN) << "Dropped selected mirror: " << n->url
-                 << endLog;
-             dropped_site_list.push_back (*j);
-             cache_warn_urls += i->url;
+           {
+              SiteList::iterator d = find (all_site_list.begin(), all_site_list
.end(),*j);
+              if (d != all_site_list.end() || d->servername.size())
+              {
+              {
+               log (LOG_PLAIN) << "Should reinstate "<< n->url << " and remove
from dropped mirror list" << endLog;
+             }
+             else
+             {
+               log (LOG_PLAIN) << "Dropped selected mirror: " << n->url
+                   << endLog;
+               dropped_site_list.push_back (*j);
+               if (cache_warn_urls.size())
+                 cache_warn_urls += "\r\n";
+               cache_warn_urls += i->url;
+             }
            }
        }
     }

Re: Is it my setup or the mirror page that is wrong as to the current status of a mirror [I think its setup]

[Brian Keener]

Dave or others,

Could someone check my diagnoses on this and my patch as shown in 
http://cygwin.com/ml/cygwin-apps/2008-09/msg00015.html
and see if you concur with my findings.  I didn't post this to patches as I 
wanted confirmation and I was sure the my code needed checking and there was 
probably a better way.

What I found on this was that when a mirror is found to be out of date it is 
marked at the end of the mirrors-lst file as follows:

> # Following mirrors re-added by setup.exe to warn again about dropped urls.
> ftp://sourceware.mirrors.tds.net/pub/sourceware.org/cygwin;sourceware.mirro
> rs.tds.net;North America;Wisconsin

When I removed these line manually because the mirrors in fact current then the 
mirror check proceeds as normal and no warning occurs.  I looked at my Windows 
2000 machine and found a similar line for the gatech mirror which when removed 
from the mirror-lst file the warning goes away in setup on that machine as well.  
I then left the line there and started setup and the line stays with the updated 
mirrors-lst file leading me to believe that setup is copying those lines each 
time from the old mirrors-lst file to the new and somehow missing the fact the 
mirror is now current.  Looking at the code in site.cc in check_dropped_mirrors 
it does appear to be checking that the server is valid but also check the end of 
list at the same time so something is not quite right.  

I am sure there was a better way but I simply added code to double check the 
server was valid before letting the site get added to the warn dialog or to the 
dropped list.

Just curious if I was right or not.

RE: Is it my setup or the mirror page that is wrong as to the current status of a mirror [I think its setup]

[Dave Korn]

Brian Keener wrote on 09 September 2008 17:17:

> Dave or others,
> 
> Could someone check my diagnoses on this and my patch as shown in
> http://cygwin.com/ml/cygwin-apps/2008-09/msg00015.html
> and see if you concur with my findings.  I didn't post this to patches as
> I wanted confirmation and I was sure the my code needed checking and
> there was probably a better way.

  I think your diagnosis is correct; I haven't had time to look at the patch
owing to pressure of gcc work, but that's about to get to a point where I can
stop for a bit and wait for a sufficient pile of bug reports to pile up and
I'll have time to do it during the rest of the week.


> 
> What I found on this was that when a mirror is found to be out of date it
> is marked at the end of the mirrors-lst file as follows:

  ... snip ... 

> Just curious if I was right or not.

  Very very likely, but a) I'm not familiar with that bit of the code and
don't know how it works yet, b) I'd really like to have the time to reproduce
the bug on a test rig and then verify your diagnosis and test your patch.

  Thanks for your patience; I may be slow but I'll get there in the end.


    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....