From: Brian Keener <bkeener@thesoftwaresource.com>
To: cygwin-apps@cygwin.com
Subject: Re: Is it my setup or the mirror page that is wrong as to the current status of a mirror [I think its setup]
Date: Tue, 09 Sep 2008 16:18:00 -0000 [thread overview]
Message-ID: <VA.000018e9.004db4a3@thesoftwaresource.com> (raw)
In-Reply-To: <VA.000018e5.041608e9@thesoftwaresource.com>
Dave or others,
Could someone check my diagnoses on this and my patch as shown in
http://cygwin.com/ml/cygwin-apps/2008-09/msg00015.html
and see if you concur with my findings. I didn't post this to patches as I
wanted confirmation and I was sure the my code needed checking and there was
probably a better way.
What I found on this was that when a mirror is found to be out of date it is
marked at the end of the mirrors-lst file as follows:
> # Following mirrors re-added by setup.exe to warn again about dropped urls.
> ftp://sourceware.mirrors.tds.net/pub/sourceware.org/cygwin;sourceware.mirro
> rs.tds.net;North America;Wisconsin
When I removed these line manually because the mirrors in fact current then the
mirror check proceeds as normal and no warning occurs. I looked at my Windows
2000 machine and found a similar line for the gatech mirror which when removed
from the mirror-lst file the warning goes away in setup on that machine as well.
I then left the line there and started setup and the line stays with the updated
mirrors-lst file leading me to believe that setup is copying those lines each
time from the old mirrors-lst file to the new and somehow missing the fact the
mirror is now current. Looking at the code in site.cc in check_dropped_mirrors
it does appear to be checking that the server is valid but also check the end of
list at the same time so something is not quite right.
I am sure there was a better way but I simply added code to double check the
server was valid before letting the site get added to the warn dialog or to the
dropped list.
Just curious if I was right or not.
next prev parent reply other threads:[~2008-09-09 16:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 18:41 Is it my setup or the mirror page that is wrong as to the current status of a mirror Brian Keener
2008-08-31 23:45 ` Dave Korn
2008-09-02 19:02 ` Brian Keener
2008-09-02 21:54 ` Sylvain RICHARD
2008-09-03 20:22 ` Brian Keener
2008-09-05 20:24 ` Brian Keener
2008-09-09 16:18 ` Brian Keener [this message]
2008-09-09 18:04 ` Is it my setup or the mirror page that is wrong as to the current status of a mirror [I think its setup] Dave Korn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VA.000018e9.004db4a3@thesoftwaresource.com \
--to=bkeener@thesoftwaresource.com \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).