From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <corinna-cygwin@cygwin.com>
Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.134])
	by sourceware.org (Postfix) with ESMTPS id 8E8E2385B187
	for <cygwin-apps@cygwin.com>; Sat,  3 Dec 2022 19:39:49 +0000 (GMT)
Authentication-Results: sourceware.org; dmarc=permerror header.from=cygwin.com
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cygwin.com
Received: from calimero.vinschen.de ([24.134.7.25]) by
 mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis)
 id 1MIdS1-1pFYbR1Oej-00EhPd for <cygwin-apps@cygwin.com>; Sat, 03 Dec 2022
 20:39:48 +0100
Received: by calimero.vinschen.de (Postfix, from userid 500)
	id DB84DA80891; Sat,  3 Dec 2022 20:39:47 +0100 (CET)
Date: Sat, 3 Dec 2022 20:39:47 +0100
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH 1/2 v2] Filter newlines from BUILD_REQUIRES
Message-ID: <Y4umAxFoUZzGqyTX@calimero.vinschen.de>
Reply-To: cygwin-apps@cygwin.com
Mail-Followup-To: cygwin-apps@cygwin.com
References: <20221203161909.2337873-1-corinna-cygwin@cygwin.com>
 <a25e7053-08e2-deea-2bd0-db54c470c48b@dronecode.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <a25e7053-08e2-deea-2bd0-db54c470c48b@dronecode.org.uk>
X-Provags-ID: V03:K1:YH4/16Vm8n/vV/syV5PkwQ0iqeZvzzAGXqwFjEuF0uoXCqMbSd8
 wIV+z38tOtNfPZ2Ue+dCFhrKKTMv6s+8iMGgvI0mlOwSRO7VRMT0aJGYZTE2OjSi/+sfuMM
 vQpDjr5L8c2OFkZYM2ziOpVIZxglfAEt8blSc9YNr5k6BX5VG6XGipSCnL+Q3CFxE4Sc039
 Vd04wR2yGtsSx5WY6nSOA==
X-UI-Out-Filterresults: notjunk:1;V03:K0:EIkD0ikJHmE=:hL92c/a7xsMEhKlkbi5Aue
 OAz4mu1xP7dZlbwFogKACEkTCJQWjesP7wlHWtSZtZOIXjKa8oNl5h6m10xPaPtH1nB+fxPig
 lcLP2DIdI861hJfpl7cEmck8vEajGrpTm0c0If/Frw0KKP8bKg8+WTtl2efxupn8/s6CXOTfr
 hYYbbIKWZHh7fdk4UFmfWvPEh+SZ4QNClgglqvfCm+TMYt8Pgudd7De5QwNGa+uNPsc7QVff+
 siOXzGTbFmuzpbRiPC6DqqoWTwFCvR+XhPneSgr0SifaRZS3GSBXArOd8AZ1OuIuGVw9dyla0
 Yb4u25flzqVijvggT/XjLzZSyr+vqtgnKpjOyr3yIpAoWqjvDmAzxre2wvcnaEVmbEtPhsnRv
 5gkbUVvw+h6gWoaAQxzom5fzHW7kaBZIkhzCe4X27FD8Au8U8SLjWt+Cd6AVmEcecoo2JtHS3
 3CG3QK19AYLFOjEEbQfenx0FTwDHxT2fozLaUi3czX/RLfwqaNvRl46io5xfBOztVaRGCuQNV
 ZwuuqQbTA4wjHqLp9jjZZ5TS9HjLbRgLO8xWpDKs5wnoUhIH7G3xA7y+orXU79oYMJC45H2XX
 DSbwI9VNN7r10JXj7roYFyNWEmQWmED8W7AYHXELEo5JmAJil5f0xlhPjCZ1gyCWY/HZNdmlX
 6ybmgK/ibnkuPDzvgDh1P+elY1sJq2gdN98onXPSYvlNqwdgkl5umOPSlevBWYRuU13Prd0Ks
 6efiMImgSmroOjkVpe+z6lxzRdnMSl1PdTgqXATjH3GKJPKVefEZJNji3A8ZegRTqbgwv4Ug5
 6x2h8m3sLCza64uIrQvZRxbzMmrOQ==
X-Spam-Status: No, score=-95.5 required=5.0 tests=BAYES_00,GOOD_FROM_CORINNA_CYGWIN,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <cygwin-apps.cygwin.com>

On Dec  3 18:07, Jon Turney via Cygwin-apps wrote:
> On 03/12/2022 16:19, Corinna Vinschen via Cygwin-apps wrote:
> > From: Corinna Vinschen <corinna-fFDxGeQsSAIb1SvskN2V4Q@public.gmane.org>
> > 
> > BUILD_REQUIRES is added verbatim to the build-depends: line in
> > the *-src.hint file.  If the cygport file defines BUILD_REQUIRES
> > with newlines, e. g.
> > 
> >    BUILD_REQUIRES="
> >      a
> >      b
> >    "
> > 
> > The -src.hint file is broken.  Avoid this by filtering out any
> > newline's from BUILD_REQUIRES before using it in the subsequent
> > expression building the -src.hint file.
> 
> Thanks.
> 
> Attached is a patch I wrote taking a slightly more general approach.

Yeah, that looks much better to me.


Thanks,
Corinna