From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.130]) by sourceware.org (Postfix) with ESMTPS id 5095B3858039 for ; Wed, 2 Feb 2022 09:31:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5095B3858039 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N2V8Z-1mEJBR2Cv1-013t4k for ; Wed, 02 Feb 2022 10:31:26 +0100 Received: by calimero.vinschen.de (Postfix, from userid 500) id C36FAA80888; Wed, 2 Feb 2022 10:31:25 +0100 (CET) Date: Wed, 2 Feb 2022 10:31:25 +0100 From: Corinna Vinschen To: cygwin-apps@cygwin.com Subject: Re: [PATCH cygport 1/2] postinst: Never remove an existing .gnu_debuglink Message-ID: Reply-To: cygwin-apps@cygwin.com Mail-Followup-To: cygwin-apps@cygwin.com References: <20220201172519.14881-1-jon.turney@dronecode.org.uk> <20220201172519.14881-2-jon.turney@dronecode.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Provags-ID: V03:K1:BfBY06BlmdrawxRpU2vA5uowLhQ6BTlMTIbMVgnH3WMwyP4kc2t K7R5kBqQ4TGWrpllfLsW8CfB5vImz1fza6dSXLEJ0roSVl0cWLdsIXwaGcIPWaPtTPuLEzl hPSEpnNaJkTcr459ZyNMCxpYUulJ43LDTk+m48q/5wR435EgdyDuF5rP+YD9MZcqxtXy4op 8nYnYlEApWSoLMkUzQBRA== X-UI-Out-Filterresults: notjunk:1;V03:K0:ZhbaNe4EdIg=:F3j8kefdogJbhr/kPi5YC7 SenZeP+TkFJlwklRhslApauwyFxNMxnpnfzFo4jJaqGa1b/+6HfooIY3kdhpc1EuQfy7GDvPW jOD/GdzAWOVLUWtLEFcGBS5KK30pFZBPMFjqgeToV5HfrcjEYZqwAt4PqD1WAjHw1FO+fCwZu L3gYGIhuNIlV3Gw8EiNxUldQFdike9NrJJDrvj+t74ybYduQzkvGaHX6WtKe2sGW2HYqpaemb mmTcpiACnVufqVLrR673efOxh3vrKnx5H+C/9nY2Dp3huq6YAFhK3wMqeabyVOa3qr0VL/0M4 AVO9Cwt8YKLfINqL8Byv9rOpw1HvDqRpNiuCstpufrgtEkIqp8f2lZI2pfuN8+rZ/Kof8yigp AEy2qYu9GjmK3hHDHlrc4glb5+jJC6h9DhYARUsG7m8WPAgCMM24L1mKMoleskDb3pdVHBloi Fo4TrdgZLKH9PXPHsdCgMPr9l0QoncTmkdO58WRQWAaD1Xk+CfvDrumS45qr3Cbxq8Csk6siz REEY5Odguq6GaS9ekX1bvahN2F6DJRen1EG4rL0TeO2DBryKpEI6mFRfzKJJkREVhXF1ud68/ hSHIGs+zajyXA8XBTvF29pmmliffetnvVCzrV1ON3g1PPP9B4dAl1M6fbJCG1Fvegfr/eX4fn LNyUdTdhsI4nlUrVVcw/XFIPrqeNJ4zkmjOaKyiTweC5+QoYcTAI6SxNID8VD8Xw5r64DLhw4 yNCr+D9aeFk+f3DD X-Spam-Status: No, score=-103.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, GOOD_FROM_CORINNA_CYGWIN, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_FAIL, SPF_HELO_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Feb 2022 09:31:30 -0000 On Feb 1 20:33, Jon Turney wrote: > On 01/02/2022 19:22, Corinna Vinschen wrote: > > Hi Jon, > > > > On Feb 1 17:25, Jon Turney wrote: > > > Be more careful not to remove an existing .gnu_debuglink, even if we > > > think this package has no useful debug symbols. > > > > > > (Some versions of 'llvm-objdump -l' fail to find line number info even > > > though it's there. Don't break a package which manages it's own debug > > > symbols (e.g. cygwin) when that happens.) > > > --- > > > lib/src_postinst.cygpart | 28 ++++++++++++++++++---------- > > > 1 file changed, 18 insertions(+), 10 deletions(-) > > > > > > diff --git a/lib/src_postinst.cygpart b/lib/src_postinst.cygpart > > > index d8bb226..e29b2cb 100644 > > > --- a/lib/src_postinst.cygpart > > > +++ b/lib/src_postinst.cygpart > > > @@ -1051,23 +1051,31 @@ __prepstrip() { > > > lines=$(${objdump} -d -l "${exe}" 2>/dev/null | sed -ne "s|.*\(/usr/src/debug/${PF}/.*\):[0-9]*$|\1|gp" | sort -u | tee -a ${T}/.dbgsrc.out | wc -l); > > > > Shouldn't lines be computed *after* the new check for .gnu_deb? After > > all, it's still pretty time-consuming and if the .gnu_deb check kicks in > > it's never tested... > > The objdump invocation has the side effect of creating ${T}/.dbgsrc.out, > which is later used to determine what source files to put into the debuginfo > package. Ah, that explains it☝️