From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <corinna-cygwin@cygwin.com>
Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.75])
 by sourceware.org (Postfix) with ESMTPS id 539B5385840F
 for <cygwin-apps@cygwin.com>; Mon, 18 Jul 2022 08:16:01 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 539B5385840F
Authentication-Results: sourceware.org;
 dmarc=fail (p=none dis=none) header.from=cygwin.com
Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com
Received: from calimero.vinschen.de ([24.134.7.25]) by
 mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis)
 id 1N49Ul-1nVK0M1iPh-0106v4 for <cygwin-apps@cygwin.com>; Mon, 18 Jul 2022
 10:15:59 +0200
Received: by calimero.vinschen.de (Postfix, from userid 500)
 id 70270A806B0; Mon, 18 Jul 2022 10:15:58 +0200 (CEST)
Date: Mon, 18 Jul 2022 10:15:58 +0200
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH rebase] Ensure that no rebaseable DLL overlaps a
 non-rebaseable DLL
Message-ID: <YtUWvsG0m2rWtCzc@calimero.vinschen.de>
Reply-To: cygwin-apps@cygwin.com
Mail-Followup-To: cygwin-apps@cygwin.com
References: <f60fd208-1cf8-8fc3-cf4e-51711647d55b@t-online.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <f60fd208-1cf8-8fc3-cf4e-51711647d55b@t-online.de>
X-Provags-ID: V03:K1:Sui6UgMqRUFdezUqUBywvYfhq63lzvilHCKO5SM+QuQbl83LWxF
 QUtvzjd4ZqBsWZ0tlisCiO2/ZNzGv7hKk9MjuTLoAiAX2yu8CVa3x/eOmbMCEZNEe9Y2dk4
 A/whqrv+XLbZo8BCsSE8FykukYuydWCn5sfygjWW6hOMM84DxTmw0/7xmNQX0+TqhYjBkRS
 1K4PPUQ3DGLaILjRTHUqA==
X-UI-Out-Filterresults: notjunk:1;V03:K0:4QA4pMGozQk=:9XciJbRip35zgc3pPDN1X1
 bkWkKKh2OusQsf8QGcco3hoYfOUgtCiJ0A3WHeN/wnRhoGsyAvWB+PR0YIk0DhCzkFXfW4PoQ
 5yJshEIk3bbtRqjy0mqh4gxgAVLJ5Bd8NPWmn3dQiivYKQGoVBSUUcYrkFesOKR9ReNvcbb5x
 UOYDSUd9jQzP7ZMPB5JmVP8X0F8dsMXWY4O22Zsuwp2OzQmgUdN+R88gwHdgEHyYjRWW2aEeE
 ne0ysl5DhhtVLGcCG+ZhmezVcEaxSEhdZxFv8IW/AwVWw19moIMQ7L7UHhD7J2Qt2nnCRjmXH
 flhZuSgHRCFHn88JLlQ9E35yPVP76yz127cPazpmsisaNK9NN953UEn1rgHUNYACUdAWOxuJU
 kxL/1UkTsxWhs1/neY96Fq6/LEnYKzevoSyTDIa6sK2IsCpqD7mvQ8gm8DsUoMcd3lz659I2j
 7F9wwS2lC7U4JE1EUUHGSuRarwaOGw7OvyQhZ09arFwnl6SrTDMmCn6B6OueOINAV2/J5xuCw
 T81kXA6f0ks4SW7RO6WwNCas1NRajdSk3KrxxpQjPoUWZH/bagrXTT5q5w1ebfk7+Rc/dn/J1
 Q5yxIoms7HtZnb1kWyWe94hcwaTcUUzI8DyvibTOV7tH0qBTLNS6FrHjp6j3hHCUsVzKPa60L
 Rtre+HUIEOgwbWCueuFpxBdUuz1EoLqz0r6j+LZCqWCbTQY7+qd7p/OjWlgHkvXiuD/ZS0Fj9
 +BkB/ykLceKWFhj3jrCcjd1L1gsPcTF3BRnGrYceygNkK8OuUMcfNaZunVk=
X-Spam-Status: No, score=-95.4 required=5.0 tests=BAYES_00,
 GOOD_FROM_CORINNA_CYGWIN, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE,
 RCVD_IN_MSPIKE_H2, SPF_FAIL, SPF_HELO_NONE,
 TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: cygwin-apps@cygwin.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Cygwin package maintainer discussion list <cygwin-apps.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin-apps>,
 <mailto:cygwin-apps-request@cygwin.com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin-apps/>
List-Post: <mailto:cygwin-apps@cygwin.com>
List-Help: <mailto:cygwin-apps-request@cygwin.com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin-apps>,
 <mailto:cygwin-apps-request@cygwin.com?subject=subscribe>
X-List-Received-Date: Mon, 18 Jul 2022 08:16:03 -0000

On Jul 16 18:01, Christian Franke wrote:
> The current check for overlapping non-rebaseable DLLs uses a possible
> outdated base address. It also could not detect multiple overlaps by one
> non-rebaseable DLL.
> 
> Patch size may be misleading due to indentation change.

Yeah, I diff'ed -b it for a better view :)

LGTM, pushed.


Thanks,
Corinna