From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.73]) by sourceware.org (Postfix) with ESMTPS id 5228E3858D28 for ; Thu, 21 Jul 2022 09:09:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5228E3858D28 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MXHBo-1o0nCC2Zzy-00YgQ8 for ; Thu, 21 Jul 2022 11:09:26 +0200 Received: by calimero.vinschen.de (Postfix, from userid 500) id F36AAA80850; Thu, 21 Jul 2022 11:09:25 +0200 (CEST) Date: Thu, 21 Jul 2022 11:09:25 +0200 From: Corinna Vinschen To: cygwin-apps@cygwin.com Subject: Re: [PATCH rebase] Make rebaseall a wrapper around the autorebase postinstall, script Message-ID: Reply-To: cygwin-apps@cygwin.com Mail-Followup-To: cygwin-apps@cygwin.com References: <6d18fb7b-5af2-3c40-3358-c27260a27b48@cornell.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6d18fb7b-5af2-3c40-3358-c27260a27b48@cornell.edu> X-Provags-ID: V03:K1:PuTNnmY2RPovbyW9N6Dbwxhw1Tlubg6skVQyzXbsANvEDypJn4E X4aykoGCg2osVkEALWCImZiwR5F6ZrVa4sQBK98u/M7ky7nGpbgyAZs8d7UKDmmPlJirKzP OB7R5yft3Z5t+VeRzkjpX6nNu1vuAT2uBCXBSuYyKBHgjAGYoDD+Ldf2ezWnXel055pZtT2 sXFL4ByVpoTbdYjD1LCCQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:PfBJm8MLLZI=:q9XNn9sVWPfFJpqbMyMs2j x1/I+udb+Cx24mKvwMkkPSX4+ytyErSAGX5voFwmecz1Qjy32x0ha4NR4++rBKTO6M6RuBcF7 CYMLQvrVej6wPj4dJIXaw/7yBbsFyTSA82LnZt+5Sv1EC57fRH3VNmtF1tQT1OshQvP+0CkPN kPGqA5EzW3qiWyL6z9tMoDQk5epWUrPEAOfzqFKsrLcSO5CNAqJmgDEbG16WGMOBWSW1miOhq CNwhmGIu/9aC0L2Ckw2ptvdSKHzKoBhkfknuWnxv4ojtcJacGCJIkzCaD8W6Ytag+h5SpC7yY ht2ZAsAnPI2MyTCUskv3AAYInNhSus7H+N9xZLE6gDVtpa6jMWu0lfi/Q50Haxc7kGZQctpOL pBfw+aKNYEFC8uvH16y+SSMkOfk7Fv/4tTx9ja7T5o0MXiq3visfT7nru01HoeWFTzhmRP2aF 7yQprMIM6hFFzEWd3DcYruYlLDuOnOX4qqizX3SiA30S7NLHCjdXCHmsgl9hYTmod0HZ4FJH1 dLTnTQBBzFDrMdKUqbBws5nNTmWERrt81+Hyybt1oxBFASh/QRJ6EaePsmBM07zr/EdQamjWd qS0815s6qgWslGdpV5RkIaLanlkHQWpEILadqCi6NY1KwSa45f/PQolrqH5rt5MZ29BipZA3Q qt+Zj+u0Mda5A2j3EFE7dYzXpqo2Fwb3QC6u1UvAhVrPvn2QgjKQoe50p44J+pva9FNLmKG40 4tXI9fmTOv8G7XwGjIjZw1tmYzzrpajO9F1v8Ml/Bj0TzI+WM0koe/PECvs= X-Spam-Status: No, score=-95.1 required=5.0 tests=BAYES_00, GOOD_FROM_CORINNA_CYGWIN, KAM_ASCII_DIVIDERS, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_FAIL, SPF_HELO_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2022 09:09:31 -0000 Hi Ken, On Jul 20 16:14, Ken Brown wrote: > Patch attached. > From bcbc7f9768854a6e6aaf1a450cdaabc61241ea9d Mon Sep 17 00:00:00 2001 > Homepage: > ================================================================================ > The primary rebase web site is: > > - http://www.tishler.net/jason/software/rebase/ > + https://cygwin.com/git/?p=cygwin-apps/rebase.git Shouldn't that be https://sourceware.org/cygwin-apps/ ? I mean, it's the only real web page apart from git access. Also https://cygwin.com/git/?p=cygwin-apps/rebase.git vs. https://cygwin.com/git/cygwin-apps/rebase.git Both work but the 2nd URL avoids that ugly ?p=. We're using the "?p=" URLs on the cygin-apps website, too. Maybe it's just me, but to me it looks better if we change this to the 2nd form where possible. What do you think? > Download: > ================================================================================ > -The primary rebase download site is: > - > - http://www.tishler.net/jason/software/rebase/ > - > -Access to the CVS development sources is available: > +Access to the git development sources is available: > > - cvs -d:pserver:anoncvs@cygwin.com:/cvs/cygwin-apps co rebase > + git clone git://cygwin.com/git/cygwin-apps/rebase.git Better use https here, rather than git. > DefaultFileList= > DefaultSuffixes='dll|so|oct' > > +# Determine platform > +Platform=`uname -s` > +case $Platform in > + *MINGW* | *mingw* ) Platform=mingw ;; > + *CYGWIN* | *cygwin* ) Platform=cygwin ;; > + *MSYS* | *msys* ) Platform=msys ;; > + * ) > + echo "Unsupported platform: $Platform" 1>&2 > + exit 1 > + ;; > +esac > + > +# On Cygwin, just call the _autorebase postinstall script > +case $Platform in > + cygwin) > + if [ "$#" -gt 0 ] > + then > + echo "usage: ${ProgramName}" > + exit 1 > + fi > + exec /etc/postinstall/0p_000_autorebase.dash > + ;; > + *) > + ;; > +esac > + > # Define functions > usage() > { Just a style issue, but the two functions should stay first in the file. Please move this code just right before the trap call. Other than that, LGTM. Thanks, Corinna