From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.131]) by sourceware.org (Postfix) with ESMTPS id 4AEE63854804 for ; Thu, 21 Jul 2022 14:09:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4AEE63854804 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Mw9Lw-1nOtj224qi-00s978 for ; Thu, 21 Jul 2022 16:09:52 +0200 Received: by calimero.vinschen.de (Postfix, from userid 500) id 9240CA809C6; Thu, 21 Jul 2022 16:09:51 +0200 (CEST) Date: Thu, 21 Jul 2022 16:09:51 +0200 From: Corinna Vinschen To: cygwin-apps@cygwin.com Subject: Re: [PATCH rebase] Make rebaseall a wrapper around the autorebase postinstall, script Message-ID: Reply-To: cygwin-apps@cygwin.com Mail-Followup-To: cygwin-apps@cygwin.com References: <6d18fb7b-5af2-3c40-3358-c27260a27b48@cornell.edu> <6b3a9801-6ab9-e910-a55e-2a9d398edc5f@cornell.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6b3a9801-6ab9-e910-a55e-2a9d398edc5f@cornell.edu> X-Provags-ID: V03:K1:mXCywf99AD5tdkIiNJVivq9qvCahHHS+lRQT9XQxHHP7KDeJov1 hxbSu6eHQ19t4XNxWP8NVyt41EfnfmQw8uD1RNr65PBz6jBqI9AlAlJOuStoj0864kgtvOy 8jlquEKMKQxLMYrJH/onEihtAKPvIzWEIwYOyVCMUGh1pHtiv/pjGSYyY/BkBYpMEPupalY Y5YqNy+hLFiLf+xOq/ACA== X-UI-Out-Filterresults: notjunk:1;V03:K0:Rh0zdFYgKys=:bxj1aNuG43I/6QUgm9KR7f 5VSupSUm4Y8BMLTFgSuFpJ/cMLbCG5xk3+KJDRn+nJbHovDdY9BlkIBO/FI3Jai24Ju6nC3eV hUugaHzwCYRE0/8AtWhdUDo25yRmqhaFOzrMAI1yU6EWFxIhecROJs/pK8JxoDNz/c7QivqXc bVo78+x2/un3AM30m++RzI+QsfMtMsnGOfygkw+0fjL0EnlzSwND26CvG/uJspYmDLeaufQH9 3I3Qn9OohFkUJWbAX7cQwpyOTtsMP8GAOZnTM2gCwSVfpVfyAHQ510oy8Ft4F/JkpIOdwpTLy EEvD8xFAIi69fbtYkpE6zukxw4TQ5W8i8NUHRNIiSZD5uAyouhPeOiDBk8+vkvgkWweB8Ij+F +egqv0FKGDmZ4JNZkYhb/7GHOQN9FTmaE1vPl/VsOVMMwvTDfhBqc04PqHjtRVK1dHeLfHQgB kZ6XiuBu627b6jNo4WUWiKbpSEw/ZjFdKzN+d4Qm1Yrol9xvssH5T/SZuN7lS0v1kc+drq3wk RxFAFtdtoSqFqht/Sv7u2qeOu1ELt84EU0S2l82/Fq4XmCaCiYYPY+FreDb462eFxuyjqMXBs 9KEZU6mmHkRtL4cU2j4ATMSdUb/6EZZ1mS0EykV+jdZO0PIOvfy9K0m7ePRzxWC8I2vluHfdE M7PchXeVPbg87gYGXl/VPOCUxrFF4bKTclFtqVnkCxYmn3eiLQ9CfliQvMBMz25/w0JtbyHFl 0iWfuRBdAltNfC/X7p/1x5PKXixW7W1Zq72g+ZRerB1nYqbHmaxVkeDKELM= X-Spam-Status: No, score=-95.5 required=5.0 tests=BAYES_00, GOOD_FROM_CORINNA_CYGWIN, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_FAIL, SPF_HELO_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2022 14:09:59 -0000 On Jul 21 09:50, Ken Brown wrote: > On 7/21/2022 5:09 AM, Corinna Vinschen wrote: > > We're using the "?p=" URLs on the cygin-apps website, too. Maybe it's > > just me, but to me it looks better if we change this to the 2nd form > > where possible. What do you think? > > I agree that it looks better without the ?p=. I have no idea why the latter > is used on the cygwin-apps website. > > > Just a style issue, but the two functions should stay first in the file. > > Please move this code just right before the trap call. > > > > Other than that, LGTM. > > I've made all the changes you suggested and pushed it. Great, I pushed a patch to simplify the URLs and added a link from the Cygwin homepage to the cygwin apps homepage. Thanks, Corinna