From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <corinna@sourceware.org>
Received: by sourceware.org (Postfix, from userid 2155)
	id 55B963858C50; Mon, 17 Apr 2023 09:37:09 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 55B963858C50
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1681724229;
	bh=jhshWDmpcajya24mgHrDQRx651HwHNlVaV0lLPsZ52Y=;
	h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From;
	b=YSj5L0qJR9OY5bE3A9DLaCYH3jI6KOoTj4TBekGThw+pOXy6ejbk99lHvoPXoEN5S
	 N0W6B0LemCkxWH55xm/JH8PBL1ImJ2DeCqIWj/R32kQP1g85N2WaZIVVlT0tl7aACX
	 QvmUcZXyN/dP6EBDn8EfWvc2Tb/6HiEOTy/Tgezc=
Received: by calimero.vinschen.de (Postfix, from userid 500)
	id 0F2FDA80B9C; Mon, 17 Apr 2023 11:37:07 +0200 (CEST)
Date: Mon, 17 Apr 2023 11:37:07 +0200
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: Christoph Reiter <reiter.christoph@gmail.com>
Cc: cygwin-apps@cygwin.com
Subject: Re: [PATCH] peflags: add support for
 IMAGE_DLLCHARACTERISTICS_GUARD_CF
Message-ID: <ZD0TQyt9o5wmcUm2@calimero.vinschen.de>
Reply-To: cygwin-apps@cygwin.com
Mail-Followup-To: Christoph Reiter <reiter.christoph@gmail.com>,
	cygwin-apps@cygwin.com
References: <20230416131103.6480-1-reiter.christoph@gmail.com>
 <CAE6_+UeHtY6BaayVhVwiya9taFFKqBzJp11CxgUH9h93_SfW=g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAE6_+UeHtY6BaayVhVwiya9taFFKqBzJp11CxgUH9h93_SfW=g@mail.gmail.com>
List-Id: <cygwin-apps.cygwin.com>

Hi Christoph,

your patch looks good and I'm happy to merge it into peflags, but...

On Apr 17 09:48, Christoph Reiter via Cygwin-apps wrote:
> Jeremy noted that an option already exists in genpeimage [0] but with
> a different name, which I wasn't aware of: -c/control-flow-guard,
> instead of -g/guard-cf which I used here. I'm open to making them
> match.

yeah, given that peflags and genpeimg use the same single char
flags, it might be a good idea to follow suit.


Thanks,
Corinna