From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2155) id 476CE3858D1E; Tue, 18 Apr 2023 07:44:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 476CE3858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com; s=default; t=1681803858; bh=gTomALLL+qZEmGxaHy7OEFTr3pvhb/pblh7IFYSyp1c=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=MSaLABAS+rDNdH0O9KzpCkl9mIzMnab3YVJTIIYJp2h75a5kTj36qS32Rud1qopBx Q037skjUY0GAJ34v/vG63WR7xA8kVCgVESClx8LcJo9b1CvEUd4DlqpgxJ3QW4RO7a rBU+Kf3C45fXVJ3xxMmgiwWX7vbfNgr44/eNRGn8= Received: by calimero.vinschen.de (Postfix, from userid 500) id 6A2F4A808C0; Tue, 18 Apr 2023 09:44:16 +0200 (CEST) Date: Tue, 18 Apr 2023 09:44:16 +0200 From: Corinna Vinschen To: Christoph Reiter Cc: cygwin-apps@cygwin.com Subject: Re: [PATCH v2] peflags: add support for IMAGE_DLLCHARACTERISTICS_GUARD_CF Message-ID: Reply-To: cygwin-apps@cygwin.com Mail-Followup-To: Christoph Reiter , cygwin-apps@cygwin.com References: <20230417184034.2234-1-reiter.christoph@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230417184034.2234-1-reiter.christoph@gmail.com> List-Id: Hi Christoph, On Apr 17 20:40, Christoph Reiter via Cygwin-apps wrote: > This allows for setting, clearing, and displaying the value of the > "control flow guard" dll characteristics flag. > > The flag for MSVC is called "/guard:cf" and the macro ends with "GUARD_CF". > To keep things consistent, it would make sense to name the option "guard-cf". > However, there's already "-c"/"control-flow-guard" in genpeimg for this flag, > and genpeimg shares all other options with peflags so far. > So, follow genpeimg and go with "-c" and "--control-flow-guard". > > This is motivated by mingw-w64 and llvm v16 gaining support for > CFG (Control Flow Guard). > --- > Renamed the option from -g/--guard-cf to -c/--control-flow-guard > > peflags.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) Pash pushed. I new rebase 4.6.3 release with your patch is just building. Thanks, Corinna