From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <corinna@sourceware.org>
Received: by sourceware.org (Postfix, from userid 2155)
	id C8B803858CDA; Mon,  7 Aug 2023 18:50:07 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C8B803858CDA
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1691434207;
	bh=FraCHIqkfrikcf+RmCEsU1sHX9rarwXXGxTPY0iSn+w=;
	h=Date:From:To:Subject:Reply-To:References:In-Reply-To:From;
	b=ygq2cZ3qXkUaDa3Y/xZ1VZYHrvkgHGqW/mWOvcSVsS5wBm/B35Ict2yqIvQoNyxct
	 X16owQt6GzQMCHW/0V2OoHtkn+vOy+/vs+pPOHf3SXBtdssCW1Qhjc2WHJHVXPN+YZ
	 zE9uS7JD4EE+mDUTp4aZZMyBoFNufvXzG5LYNHeI=
Received: by calimero.vinschen.de (Postfix, from userid 500)
	id 1EC0FA80C13; Mon,  7 Aug 2023 20:50:06 +0200 (CEST)
Date: Mon, 7 Aug 2023 20:50:06 +0200
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH rebase] peflags: Fix ULONG range checks
Message-ID: <ZNE83t0SSaD6yNc3@calimero.vinschen.de>
Reply-To: cygwin-apps@cygwin.com
Mail-Followup-To: cygwin-apps@cygwin.com
References: <e9bdc5e5-f8b6-c8f4-3548-625c402a326f@t-online.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <e9bdc5e5-f8b6-c8f4-3548-625c402a326f@t-online.de>
List-Id: <cygwin-apps.cygwin.com>

Hi Christian,

On Aug  7 16:07, Christian Franke via Cygwin-apps wrote:
> Minor issue found during tests of the upcoming 'peflags --timestamp' patch.
> 
> -- 
> Regards,
> Christian
> 

> From 9da405da78e92dc8263239e25365bee3167f185e Mon Sep 17 00:00:00 2001
> From: Christian Franke <christian.franke@t-online.de>
> Date: Mon, 7 Aug 2023 13:42:50 +0200
> Subject: [PATCH] peflags: Fix ULONG range checks
> 
> Don't use ULONG_MAX from <limits.h> because ULONG is not necessarily
> 'unsigned long'.
> 
> Signed-off-by: Christian Franke <christian.franke@t-online.de>
> ---
>  peflags.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/peflags.c b/peflags.c
> index 93eaa0b..d98b121 100644
> --- a/peflags.c
> +++ b/peflags.c
> @@ -30,7 +30,6 @@
>  #include <unistd.h>
>  #include <getopt.h>
>  #include <errno.h>
> -#include <limits.h>
>  #if defined (__CYGWIN__) || defined (__MSYS__)
>  #include <sys/mman.h>
>  #endif
> @@ -598,7 +597,7 @@ handle_num_option (const char *option_name,
>  	   || sizeof_vals[option_index].value > 0x0000ffffffffffffULL
>  	   /* Just a ULONG value */
>  	   || (sizeof_vals[option_index].is_ulong
> -	       && sizeof_vals[option_index].value > ULONG_MAX))
> +	       && sizeof_vals[option_index].value > 0x00000000ffffffffULL))

What about using MAXDWORD or MAXULONG32 instead?


Corinna