From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2155) id BB9E83858D28; Wed, 30 Aug 2023 18:10:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB9E83858D28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com; s=default; t=1693419019; bh=zDaiAwB0AiQByabVR7jkQ7ik3J3u7NZwrneQE2OBkf8=; h=Date:From:To:Subject:Reply-To:References:In-Reply-To:From; b=PCr6idWLErlC/Vwu9NWX0hFaf9oT8JqXaPJCOwCCBfW/cAmgCkEDWFAuFB7VWQFxU SkLocvlEH0PpzeL614LJmrU+ry/6i6xFTTmDLeh9lcjD/wjBO4XWUH7DcpKigChjKn 0hf7olxFRHgmWOF1l7zNIm7UF6l5Ytq8Nbzsb5vQ= Received: by calimero.vinschen.de (Postfix, from userid 500) id 396DEA80CB0; Wed, 30 Aug 2023 20:10:16 +0200 (CEST) Date: Wed, 30 Aug 2023 20:10:16 +0200 From: Corinna Vinschen To: cygwin-apps@cygwin.com Subject: Re: can't compile coreutils-9.3 any more after upgrade to cygwin-3.4.8 Message-ID: Reply-To: cygwin-apps@cygwin.com Mail-Followup-To: cygwin-apps@cygwin.com References: <83C27059-CB24-48F5-AC91-AB0622DF82CD@Denis-Excoffier.org> <603386c9-d4a0-82cd-a8e4-02f298f9047b@maxrnd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: List-Id: On Aug 30 12:04, Brian Inglis via Cygwin-apps wrote: > On 2023-08-30 06:17, Corinna Vinschen via Cygwin-apps wrote: > > On Aug 30 11:57, Corinna Vinschen via Cygwin-apps wrote: > > > On Aug 30 11:34, Corinna Vinschen via Cygwin-apps wrote: > > > > #define CPU_ZERO_S(siz, set) __cpuset_zero_s (siz, set) > > > > -static __inline void > > > > -__cpuset_zero_s (size_t siz, cpu_set_t *set) > > > > -{ > > > > - (void) memset (set, 0, siz); > > > > -} > > > > +void __cpuset_zero_s (size_t, cpu_set_t *); > > > > [...] > > > > +__cpuset_zero_s (size_t siz, cpu_set_t *set) > > > > +{ > > > > + (void) memset (set, 0, siz); > > > > +} > > > > + > > > > } /* extern C */ > > > > > > Also, we can avoid an external __cpuset_zero_s function by just using a > > > loop, kind of like this: > > > > I attached a matching patch. Please give it a try. > > Shouldn't cpuset.h #include for size_t and for pid_t? It shouldn't need that. sys/cpuset.h is a non-standard header which is only included indirectly via sys/types.h. We may want to change from size_t to __size_t and from pid_t to __pid_t. That should eliminate any further dependency. Corinna