From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-apps@cygwin.com
Subject: Re: can't compile coreutils-9.3 any more after upgrade to cygwin-3.4.8
Date: Fri, 1 Sep 2023 12:38:04 +0200 [thread overview]
Message-ID: <ZPG/DO3WF5FFzU7f@calimero.vinschen.de> (raw)
In-Reply-To: <b8cfbfed-77d9-c5ee-6a2c-66a18478d9bf@maxrnd.com>
On Sep 1 03:28, Mark Geisert via Cygwin-apps wrote:
> Hi Corinna,
>
> Corinna Vinschen via Cygwin-apps wrote:
> > On Aug 30 20:10, Corinna Vinschen via Cygwin-apps wrote:
> > > On Aug 30 12:04, Brian Inglis via Cygwin-apps wrote:
> > > > On 2023-08-30 06:17, Corinna Vinschen via Cygwin-apps wrote:
> > > > > On Aug 30 11:57, Corinna Vinschen via Cygwin-apps wrote:
> > > > > > On Aug 30 11:34, Corinna Vinschen via Cygwin-apps wrote:
> > > > > > > #define CPU_ZERO_S(siz, set) __cpuset_zero_s (siz, set)
> > > > > > > -static __inline void
> > > > > > > -__cpuset_zero_s (size_t siz, cpu_set_t *set)
> > > > > > > -{
> > > > > > > - (void) memset (set, 0, siz);
> > > > > > > -}
> > > > > > > +void __cpuset_zero_s (size_t, cpu_set_t *);
> > > > > > > [...]
> > > > > > > +__cpuset_zero_s (size_t siz, cpu_set_t *set)
> > > > > > > +{
> > > > > > > + (void) memset (set, 0, siz);
> > > > > > > +}
> > > > > > > +
> > > > > > > } /* extern C */
> > > > > >
> > > > > > Also, we can avoid an external __cpuset_zero_s function by just using a
> > > > > > loop, kind of like this:
> > > > >
> > > > > I attached a matching patch. Please give it a try.
> > > >
> > > > Shouldn't cpuset.h #include <stddef.h> for size_t and <sys/types.h> for pid_t?
> > >
> > > It shouldn't need that. sys/cpuset.h is a non-standard header which is
> > > only included indirectly via sys/types.h.
> > >
> > > We may want to change from size_t to __size_t and from pid_t to __pid_t.
> > > That should eliminate any further dependency.
> >
> > Try this:
>
> After applying both patches to my system I was able to build coreutils
> without issues. After updating my local Cygwin tree's sched.cc and
> cygwin.din I rebuilt the Cygwin DLL without issues.
>
> I then tried recompiling a CPU affinity test program of mine (that uses
> cpusets) but it could not link due to missing __cpuset_alloc and
> __cpuset_free. I think this is likely a local issue of mine in copying
> newly-built stuff into place, though I've automated that process and do it
> frequently, so... ?
You missed to copy libcygwin.a to /usr/lib.
> I believe those two patches you wrote are fine. Ship when convenient, I say.
> Cheers & Regards,
Great, thanks for testing!
Corinna
next prev parent reply other threads:[~2023-09-01 10:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <83C27059-CB24-48F5-AC91-AB0622DF82CD@Denis-Excoffier.org>
[not found] ` <aa38a12e-875a-bfaf-6427-2f8d05c0bc47@maxrnd.com>
[not found] ` <ZOh2lNSnYAJmZqUh@calimero.vinschen.de>
[not found] ` <ff004ecd-0bd7-1886-bf81-88daa6b48f2a@maxrnd.com>
[not found] ` <ZOoFxp0yvqK3ZWxX@calimero.vinschen.de>
2023-08-30 7:29 ` Mark Geisert
2023-08-30 9:34 ` Corinna Vinschen
2023-08-30 9:57 ` Corinna Vinschen
2023-08-30 12:17 ` Corinna Vinschen
2023-08-30 18:04 ` Brian Inglis
2023-08-30 18:10 ` Corinna Vinschen
2023-08-31 8:24 ` Corinna Vinschen
2023-09-01 10:28 ` Mark Geisert
2023-09-01 10:38 ` Corinna Vinschen [this message]
2023-09-02 6:51 ` Mark Geisert
2023-08-31 6:54 ` Mark Geisert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPG/DO3WF5FFzU7f@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).