From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <corinna@sourceware.org>
Received: by sourceware.org (Postfix, from userid 2155)
	id 212663858D37; Fri,  1 Sep 2023 10:38:07 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 212663858D37
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1693564687;
	bh=WScLR1bPVWoPGXFZ5tMePmQ3lDCHUCIigf8VU3fB+bs=;
	h=Date:From:To:Subject:Reply-To:References:In-Reply-To:From;
	b=blIQXeeO/VuDwArL4SzA4a1tnGxjOhh9UlmNgoT7WXpqY1whBunnKM0I0fZebfCvD
	 6ekHja6gQ9sohFpmbCxtiDq3MmKZGgSz+er8hyl65uu3eI7X6sPIh/4Y13Mcq57M0/
	 3M9gMmlR7VIcJb8EGNUdApRtUsCUHcF9Kg0oS1Uc=
Received: by calimero.vinschen.de (Postfix, from userid 500)
	id B8180A803AE; Fri,  1 Sep 2023 12:38:04 +0200 (CEST)
Date: Fri, 1 Sep 2023 12:38:04 +0200
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-apps@cygwin.com
Subject: Re: can't compile coreutils-9.3 any more after upgrade to
 cygwin-3.4.8
Message-ID: <ZPG/DO3WF5FFzU7f@calimero.vinschen.de>
Reply-To: cygwin-apps@cygwin.com
Mail-Followup-To: cygwin-apps@cygwin.com
References: <ff004ecd-0bd7-1886-bf81-88daa6b48f2a@maxrnd.com>
 <ZOoFxp0yvqK3ZWxX@calimero.vinschen.de>
 <603386c9-d4a0-82cd-a8e4-02f298f9047b@maxrnd.com>
 <ZO8NLk0PXJj6eGAN@calimero.vinschen.de>
 <ZO8Se08piQ5TE+bA@calimero.vinschen.de>
 <ZO8zUvZ2TAzWy5ZR@calimero.vinschen.de>
 <e4b2e0a1-9926-a082-ae9e-ad1043e8b69e@Shaw.ca>
 <ZO+GCDNn1C58Be7G@calimero.vinschen.de>
 <ZPBOQwNOiWZ5Fpmm@calimero.vinschen.de>
 <b8cfbfed-77d9-c5ee-6a2c-66a18478d9bf@maxrnd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <b8cfbfed-77d9-c5ee-6a2c-66a18478d9bf@maxrnd.com>
List-Id: <cygwin-apps.cygwin.com>

On Sep  1 03:28, Mark Geisert via Cygwin-apps wrote:
> Hi Corinna,
> 
> Corinna Vinschen via Cygwin-apps wrote:
> > On Aug 30 20:10, Corinna Vinschen via Cygwin-apps wrote:
> > > On Aug 30 12:04, Brian Inglis via Cygwin-apps wrote:
> > > > On 2023-08-30 06:17, Corinna Vinschen via Cygwin-apps wrote:
> > > > > On Aug 30 11:57, Corinna Vinschen via Cygwin-apps wrote:
> > > > > > On Aug 30 11:34, Corinna Vinschen via Cygwin-apps wrote:
> > > > > > >    #define CPU_ZERO_S(siz, set) __cpuset_zero_s (siz, set)
> > > > > > > -static __inline void
> > > > > > > -__cpuset_zero_s (size_t siz, cpu_set_t *set)
> > > > > > > -{
> > > > > > > -  (void) memset (set, 0, siz);
> > > > > > > -}
> > > > > > > +void __cpuset_zero_s (size_t, cpu_set_t *);
> > > > > > >    [...]
> > > > > > > +__cpuset_zero_s (size_t siz, cpu_set_t *set)
> > > > > > > +{
> > > > > > > +  (void) memset (set, 0, siz);
> > > > > > > +}
> > > > > > > +
> > > > > > >    } /* extern C */
> > > > > > 
> > > > > > Also, we can avoid an external __cpuset_zero_s function by just using a
> > > > > > loop, kind of like this:
> > > > > 
> > > > > I attached a matching patch. Please give it a try.
> > > > 
> > > > Shouldn't cpuset.h #include <stddef.h> for size_t and <sys/types.h> for pid_t?
> > > 
> > > It shouldn't need that. sys/cpuset.h is a non-standard header which is
> > > only included indirectly via sys/types.h.
> > > 
> > > We may want to change from size_t to __size_t and from pid_t to __pid_t.
> > > That should eliminate any further dependency.
> > 
> > Try this:
> 
> After applying both patches to my system I was able to build coreutils
> without issues.  After updating my local Cygwin tree's sched.cc and
> cygwin.din I rebuilt the Cygwin DLL without issues.
> 
> I then tried recompiling a CPU affinity test program of mine (that uses
> cpusets) but it could not link due to missing __cpuset_alloc and
> __cpuset_free.  I think this is likely a local issue of mine in copying
> newly-built stuff into place, though I've automated that process and do it
> frequently, so...  ?

You missed to copy libcygwin.a to /usr/lib.

> I believe those two patches you wrote are fine.  Ship when convenient, I say.
> Cheers & Regards,

Great, thanks for testing!


Corinna