From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-4324.protonmail.ch (mail-4324.protonmail.ch [185.70.43.24]) by sourceware.org (Postfix) with ESMTPS id 18B633853547 for ; Sun, 2 Oct 2022 20:49:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 18B633853547 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=proton.me Date: Sun, 02 Oct 2022 20:49:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1664743767; x=1665002967; bh=xHfkaJJ3/y4UzrOv5KKyHc1SfAD2hy/iiXXmvzhrI00=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=D0K64Goi8TDGF/dTs2axSllRcgg/1pjg5H/nsT3CA4B8xVSR/TRwof8v1LRjcbw+t FKye19/Tu+Z+bWHQsTSCufm2N0zhdM6qf9d4wyPhNu9Gt0E5hoBAD4RWq0x+nr0PX5 T3rqGJE3nDpwRTZ11LpN0tvaGkH24t5lac+9Gk2TVlgUaoq97/39GIzOo/aAqZMqVc +d8fYG7ltcE+KsTYHvewM0sTJKoD+c6BafXfxcXPe+eXRSduZrPaipY7WmMA405c83 g0u/0uSnA0XqIG5cVnWR+BdQti653p9AiX+0v3Ca+DQ8JUHt5sVYwyeS+jC+Tm52Dx +LsT7ZmE0X2vw== To: Jon Turney From: William Hu Cc: "cygwin-apps@cygwin.com" Subject: Re: Cygport Bug: "find: No such file" Errors When Packaging Message-ID: <_pSvDjVpHcqGBZuFHsXs6DrWlNOAtZ9cmYrKJ_Hmm96KOpEgvVgj-8ptZa7-OV5gLVJ_mU4nmqmR455wEEfTv08UrRjCzCDvlWxRF1JfUFs=@proton.me> In-Reply-To: <36e04564-451e-f569-4f08-6dd79901b87c@dronecode.org.uk> References: <9e4a2d4b-528e-f19f-048f-cc07f824c47a@dronecode.org.uk> <8mDrr73_tuJ35T8Yyn_WTxWpsSPecUSaqm6bGgkdd-8L0Ty4BVLJHjZD1X6yoVCSaKbzluKR5UXShhDTTy0C42Ata9HRD2nC_ZKdt3ndkJ4=@proton.me> <36e04564-451e-f569-4f08-6dd79901b87c@dronecode.org.uk> Feedback-ID: 51238035:user:proton MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_Ot4OPFUn7m1rzNdKAX1Af7v0ww0s2q4xyJyREif44Q" X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_INFOUSMEBIZ,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --b1_Ot4OPFUn7m1rzNdKAX1Af7v0ww0s2q4xyJyREif44Q Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Jon, > This change is probably safe and does what you say, but it looks like it > could potentially misbehave when ${mldir} doesn't exist, but > ${D}/${mldir} does (a situation which probably can't occur, as it > doesn't seem to make sense to build ocaml libraries when ocaml isn't > installed?) Sorry for the delay - I fell ill but I'm better now. You make a very good= =20 point which was actually the edge case I initially intended to fix. Thanks= =20 for the catch! > In future, please try to use git-format-patch, if possible, as that > saves me having to write patch commentary, and ensures correct patch > attribution. Patch attached. Please let me know if I did it properly (first time using= =20 git format). William --b1_Ot4OPFUn7m1rzNdKAX1Af7v0ww0s2q4xyJyREif44Q Content-Type: application/octet-stream; name=0001-Fix-find-errors-for-nonexistent-mldir.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Fix-find-errors-for-nonexistent-mldir.patch RnJvbSBiYzZiZTJiYjRiY2I5NGE3MzMxZGI2MWZlN2MxNzQ2NDhhYTQ0ZGJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBXaWxsaWFtIEh1IDxwdXJwbGVhcm1hZGlsbG83N0Bwcm90b24u bWU+CkRhdGU6IFN1biwgMiBPY3QgMjAyMiAxNjoyMDozNSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hd IEZpeCBmaW5kIGVycm9ycyBmb3Igbm9uZXhpc3RlbnQgJHttbGRpcn0KCi0tLQogbGliL3BrZ19p bmZvLmN5Z3BhcnQgfCA5ICsrKysrKystLQogMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygr KSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saWIvcGtnX2luZm8uY3lncGFydCBiL2xp Yi9wa2dfaW5mby5jeWdwYXJ0CmluZGV4IDRjNTE0ODMuLmMzOTljYzUgMTAwNjQ0Ci0tLSBhL2xp Yi9wa2dfaW5mby5jeWdwYXJ0CisrKyBiL2xpYi9wa2dfaW5mby5jeWdwYXJ0CkBAIC0zNjQsMTMg KzM2NCwxOCBAQCBfX2xpc3RfZGVwcygpIHsKIAlpZiBjaGVja19wcm9nIG9jYW1sYy5vcHQKIAl0 aGVuCiAJCW1sZGlyPSQob2NhbWxjLm9wdCAtd2hlcmUpCisJCXN5c19tbGRpcj0kbWxkaXIKKwkJ aWYgWyAhIC1kICR7c3lzX21sZGlyfSBdCisJCXRoZW4KKwkJCXN5c19tbGRpcj0iIgorCQlmaQog CQlpZiBbIC1kICR7RH0ke21sZGlyfSBdCiAJCXRoZW4KLQkJCWZvciBjbWEgaW4gJChmaW5kICR7 RH0ke21sZGlyfSAke21sZGlyfSAtbmFtZSAnKi5jbWEnKQorCQkJZm9yIGNtYSBpbiAkKGZpbmQg JHtEfSR7bWxkaXJ9ICR7c3lzX21sZGlyfSAtbmFtZSAnKi5jbWEnKQogCQkJZG8KIAkJCQlvY2Ft bG9iamluZm8gJGNtYSB8IHNlZCAtbnIgInMjKFVuaXR8TW9kdWxlKSBuYW1lOiAjJGNtYTojcCIK IAkJCWRvbmUgPiAke1R9Ly5jbWFvYmppbmZvLm91dAotCQkJZm9yIGNteGEgaW4gJChmaW5kICR7 RH0ke21sZGlyfSAke21sZGlyfSAtbmFtZSAnKi5jbXhhJykKKwkJCWZvciBjbXhhIGluICQoZmlu ZCAke0R9JHttbGRpcn0gJHtzeXNfbWxkaXJ9IC1uYW1lICcqLmNteGEnKQogCQkJZG8KIAkJCQlv Y2FtbG9iamluZm8gJGNteGEgfCBzZWQgLW5yICJzIyhVbml0fE1vZHVsZSkgbmFtZTogIyRjbXhh OiNwIgogCQkJZG9uZSA+ICR7VH0vLmNteGFvYmppbmZvLm91dAotLSAKMi4zNy4zCgo= --b1_Ot4OPFUn7m1rzNdKAX1Af7v0ww0s2q4xyJyREif44Q--