From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39973 invoked by alias); 6 Mar 2018 19:31:52 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 39962 invoked by uid 89); 6 Mar 2018 19:31:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: limerock02.mail.cornell.edu Received: from limerock02.mail.cornell.edu (HELO limerock02.mail.cornell.edu) (128.84.13.242) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Mar 2018 19:31:50 +0000 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock02.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id w26JVm2Q029227 for ; Tue, 6 Mar 2018 14:31:48 -0500 Received: from [192.168.0.4] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id w26JVkX4020384 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Tue, 6 Mar 2018 14:31:47 -0500 Subject: Re: setup: problems with local install To: cygwin-apps@cygwin.com References: <3cd80653-6a63-ae3d-d79c-a1642ad63fce@cornell.edu> <76209447-c5a7-2fa4-941e-4040a2de484f@dronecode.org.uk> From: Ken Brown Message-ID: Date: Tue, 06 Mar 2018 19:31:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <76209447-c5a7-2fa4-941e-4040a2de484f@dronecode.org.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00011.txt.bz2 On 3/6/2018 10:18 AM, Jon Turney wrote: > (I also note we have also have another 'erase an element from a vector > while we are iterating over it' here, so that needs fixing, as well) I think this one might be OK. If I'm not mistaken, pkg.versions.erase(i++) passes a copy of i to erase, and then increments i before erase() has done its work. But I'm no expert on this. Ken