public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Ken Brown <kbrown@cornell.edu>
To: cygwin-apps <cygwin-apps@cygwin.com>
Subject: setup: uninstalling an orphaned package
Date: Mon, 26 Mar 2018 17:55:00 -0000	[thread overview]
Message-ID: <a384c4a5-6ce5-6633-1719-64589cc67673@cornell.edu> (raw)

In ChooserPage::applyCommandLinePackageSelection() we have the following 
code:

       bool wanted    = pkg.isManuallyWanted();
       bool deleted   = pkg.isManuallyDeleted();
       bool basemisc  = (pkg.categories.find ("Base") != 
pkg.categories.end ()
		     || pkg.categories.find ("Orphaned") != pkg.categories.end ());
[...]
       bool reinstall = (wanted  || basemisc) && deleted;

One strange consequence of this is that if the user tries to uninstall 
an orphaned package on the command line, then setup will instead try to 
reinstall it.

This behavior was introduced in the following commit:

commit a667a8b289ccb6e70ec6bf4c70cceeca4d3fb5d3
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Thu Jul 25 12:03:49 2013 +0000

[...]
Uninstalled packages in categories "Base" or "Misc" are always selected 
for installation; installed packages in these categories are not 
eligible for deletion and will be reinstalled or upgraded instead.
[...]

I can't understand the rationale for this.  Did "Misc" (which has since 
been renamed to "Orphaned") used to have a different meaning?

I found it very surprising when I tried to uninstall a bunch of packages 
in unattended mode, and setup failed with download errors because it 
tried to reinstall orphaned packages.

Ken

             reply	other threads:[~2018-03-26 17:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-26 17:55 Ken Brown [this message]
2018-03-27 19:05 ` Ken Brown
2018-06-10 20:58   ` Jon Turney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a384c4a5-6ce5-6633-1719-64589cc67673@cornell.edu \
    --to=kbrown@cornell.edu \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).