From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id D2DD03858420 for ; Sun, 31 Oct 2021 19:05:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D2DD03858420 Received: by mail-ed1-x52e.google.com with SMTP id f8so35717982edy.4 for ; Sun, 31 Oct 2021 12:05:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-language; bh=GHuUnImjEgHvOxsXHxtMSYnGHJy9JP+CVPMCTd31Ks0=; b=5X/oMWgiqw5P+YFz+Sy2i0PsMXuewMezvhHRYjFFQrPAobCi+Ub6aH/1r4XgGfQY3L EGqpC9AcuoYn81ZRo6JDSClxCdazqlzRsCD77eVkolT847W6K6bKs5oocYJ2HYajuA4w XL3UfKYT7STh/WZ2qCPy9gjaid/oC/gqwWm5coTapxkaCvUkoh60RipttHNDc14vgJUa Vi0QT3HmNJVRukgsMzrh/Jg22hLc/vhB6aqmZIcuYcs8ez3Lb6IDPo264FGgCLHOjsLv GETjU22UdkmgwAgV/L/27ck+D3s/qVpWPHuf97X/U4NS58fZsYIfvL6rZJ2FyIOThRZ7 5tiA== X-Gm-Message-State: AOAM531SjTtJqf8Emoc1zTbi2Y1Z5c4ihJuaCEVdgtFNl0n2LnG4VGCv ERCArd7ugqXFrr5g1eYQ24GtFCypA08= X-Google-Smtp-Source: ABdhPJzgjZps2zEmElMe5c8bWDcfCta+ZWqEunm/4WD1c0ubLCeaW5QSo8p30a5krVYFsM4dTUId3g== X-Received: by 2002:a17:907:a088:: with SMTP id hu8mr25490166ejc.416.1635707116948; Sun, 31 Oct 2021 12:05:16 -0700 (PDT) Received: from [192.168.178.26] (ip5b40c175.dynamic.kabel-deutschland.de. [91.64.193.117]) by smtp.gmail.com with ESMTPSA id bm2sm6109692edb.39.2021.10.31.12.05.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 31 Oct 2021 12:05:16 -0700 (PDT) Subject: Re: cmus To: cygwin-apps@cygwin.com References: <23fcd06d-6c16-d031-1cb7-7cf7faae188f@gmail.com> <20211023173951.00003408@online.de> <4869d78b-4704-cf7b-197f-7ebbb45f9224@gmail.com> <96f80d13-0bd5-70be-8ada-f813838a36a3@dronecode.org.uk> From: Federico Kircheis Message-ID: Date: Sun, 31 Oct 2021 20:00:53 +0100 MIME-Version: 1.0 In-Reply-To: <96f80d13-0bd5-70be-8ada-f813838a36a3@dronecode.org.uk> Content-Type: multipart/mixed; boundary="------------0173024D7285CF41416F6075" Content-Language: en-US X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2021 19:05:19 -0000 This is a multi-part message in MIME format. --------------0173024D7285CF41416F6075 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 31/10/2021 16.29, Jon Turney wrote: > On 23/10/2021 19:01, Federico Kircheis via Cygwin-apps wrote: >> On 23/10/2021 17.39, Oliver Schoede wrote: >>> On Fri, 22 Oct 2021 15:06:46 +0200 >>> Federico Kircheis via Cygwin-apps >>> wrote: >>>> >>>> Hello to everyone, >>>> >>>> I'm interested in becoming a package maintainer for the program cmus. >>>> >>> >>> Very cool! My go-to music player, been using it for years, also in >>> Cygwin. ;) It's actually one of the reasons I started using it, knew it >>> from Linux and there being no port, building it on Windows turned out >>> easier in Cygwin. There was no WSL yet. An actual package is another >>> story of course, but if there's a problem and I could possibly be of any >>> help feel free to ask. >>> >>> Looks like you appended the wrong .hint file. >>> >>> Best regards, >>> Oliver >>> >> >> Let me try it again with the attachment... >> >> Cool to know I'm not the only one using it under Windows :) >> >> I did not notice any issue, but I'm just a casual user, thank you for >> proposing to help, I'll keep it in mind ;) > > Thanks. > > I've added 'cmus' to your list of packages. > > A few small comments on the cygport: > >> # cmus.cygport >> NAME="cmus" >> VERSION=2.9.1 >> TAG=2.9.1 > > Why not just use ${VERSION} throughout? > Good point >> RELEASE=1 >> SUMMARY="cmus is a small, fast and powerful console music player for >> Unix-like operating systems." >> DESCRIPTION="cmus is a lightweight ncurses music player. It supports >> various output methods by using dynamically-loaded output plugins." >> CATEGORY="Audio" >> >> HOMEPAGE="https://cmus.github.io/" >> SRC_URI="https://github.com/cmus/cmus/archive/v${TAG}.tar.gz" >> SRC_DIR="cmus-${TAG}" >> >> DEPEND="libncurses-devel libmad-devel libvorbis-devel flac-devel" > > DEPEND is deprecated, please use BUILD_REQUIRES instead > Ah, did not know it. IF it's deprecated, unless I did not see it, is there any type of warning when executing cygport? If not, it would be a nice addition, so that automatically packagers are aware of it. BUILD_REQUIRES is a much better name, I'm going to use it immediately. >> REQUIRES="libncursesw10 libmad0 libvorbis flac" >> >> PKG_NAMES="cmus" >> >> src_compile() { >>     lndirs >>     cd ${B} >> >>     sh ./configure \ >>         CONFIG_MAD=y CONFIG_VORBIS=y CONFIG_FLAC=y \ >>         prefix=/usr bindir=/usr/bin libdir=/usr/lib datadir=/usr/share >> mandir=/usr/share/man >> >>     cygmake CC="${CC}" CXX="${CXX}" AR="${AR}" RANLIB="${RANLIB}" >> STRIP=/usr/bin/true > > I'm not sure any of these env vars are needed (and something here seems > to cause me some problem with "undefined reference to `xstrndup'" when > linking) > I have to admit that I've copy-pasted the cygmake line from another cygport, probably also in that other package it's not necessary. I've built (modulo errors) the packages in a "clean" environment, ie a cygwin installation where I installed with setupx.exe gcc,gdb,cygport,calm and the BUILD_REQUIRES packages. I rechecked, and could not find anything related to xstrndup. Could you share the exact error message? I've dropped all the env vars and it does not seem to make any difference. >> } >> >> >> #src_install() { > > Please drop these commented out lines. > >> #    cd ${B} >> #    cyginstall >> #} >> >> #src_test() { >> #    # There is no test suite yet >> #    : >> #} I've reattached the cygport file, everything seems to work as before. Before uploading, I would like to see the error you have, if possible. --------------0173024D7285CF41416F6075 Content-Type: text/plain; charset=UTF-8; name="cmus.cygport" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="cmus.cygport" IyBjbXVzLmN5Z3BvcnQKTkFNRT0iY211cyIKVkVSU0lPTj0yLjkuMQpSRUxFQVNFPTEKU1VN TUFSWT0iY211cyBpcyBhIHNtYWxsLCBmYXN0IGFuZCBwb3dlcmZ1bCBjb25zb2xlIG11c2lj IHBsYXllciBmb3IgVW5peC1saWtlIG9wZXJhdGluZyBzeXN0ZW1zLiIKREVTQ1JJUFRJT049 ImNtdXMgaXMgYSBsaWdodHdlaWdodCBuY3Vyc2VzIG11c2ljIHBsYXllci4gSXQgc3VwcG9y dHMgdmFyaW91cyBvdXRwdXQgbWV0aG9kcyBieSB1c2luZyBkeW5hbWljYWxseS1sb2FkZWQg b3V0cHV0IHBsdWdpbnMuIgpDQVRFR09SWT0iQXVkaW8iCgpIT01FUEFHRT0iaHR0cHM6Ly9j bXVzLmdpdGh1Yi5pby8iClNSQ19VUkk9Imh0dHBzOi8vZ2l0aHViLmNvbS9jbXVzL2NtdXMv YXJjaGl2ZS92JHtWRVJTSU9OfS50YXIuZ3oiClNSQ19ESVI9ImNtdXMtJHtWRVJTSU9OfSIK CkJVSUxEX1JFUVVJUkVTPSJsaWJuY3Vyc2VzLWRldmVsIGxpYm1hZC1kZXZlbCBsaWJ2b3Ji aXMtZGV2ZWwgZmxhYy1kZXZlbCIKUkVRVUlSRVM9ImxpYm5jdXJzZXN3MTAgbGlibWFkMCBs aWJ2b3JiaXMgZmxhYyIKClBLR19OQU1FUz0iY211cyIKCnNyY19jb21waWxlKCkgewoJbG5k aXJzCgljZCAke0J9CgoJc2ggLi9jb25maWd1cmUgXAoJCUNPTkZJR19NQUQ9eSBDT05GSUdf Vk9SQklTPXkgQ09ORklHX0ZMQUM9eSBcCgkJcHJlZml4PS91c3IgYmluZGlyPS91c3IvYmlu IGxpYmRpcj0vdXNyL2xpYiBkYXRhZGlyPS91c3Ivc2hhcmUgbWFuZGlyPS91c3Ivc2hhcmUv bWFuCgoJY3lnbWFrZQp9Cg== --------------0173024D7285CF41416F6075--