From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49479 invoked by alias); 7 Oct 2018 19:46:15 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 49093 invoked by uid 89); 7 Oct 2018 19:46:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=UD:cz, HContent-Transfer-Encoding:8bit X-HELO: rgout0802.bt.lon5.cpcloud.co.uk Received: from rgout0802.bt.lon5.cpcloud.co.uk (HELO rgout0802.bt.lon5.cpcloud.co.uk) (65.20.0.149) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 07 Oct 2018 19:46:13 +0000 X-OWM-Source-IP: 31.51.205.159 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-SNCR-VADESECURE: CLEAN Received: from [192.168.1.102] (31.51.205.159) by rgout08.bt.lon5.cpcloud.co.uk (9.0.019.26-1) (authenticated as jonturney@btinternet.com) id 5B72D9E304D0DF58 for cygwin-apps@cygwin.com; Sun, 7 Oct 2018 20:46:06 +0100 Subject: Re: Zstandard support for setup To: "cygwin-apps@cygwin.com" References: <874lg0d6l8.fsf@Rainer.invalid> <267037c7-7757-25ec-4b80-7ffcbc5768d6@dronecode.org.uk> <87r2icl2th.fsf@Rainer.invalid> <87ftyr3k93.fsf@Rainer.invalid> From: Jon Turney Message-ID: Date: Sun, 07 Oct 2018 19:46:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87ftyr3k93.fsf@Rainer.invalid> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2018-10/txt/msg00007.txt.bz2 On 02/09/2018 18:02, Achim Gratz wrote: > Achim Gratz writes: >>> + using namespace std; >>> >>> Please don't >> >> That's a copy from the compress_xz files and it's used in many files >> elsewhere. Care to explain why you'd want it removed? If there's a >> good reason I'd tend to move this to a clean-up commit that touches all >> those files. We should do that before hauling Zstdandard in. > > What an unholy mess… Here's that patch, only lightly tested: > http://repo.or.cz/cygwin-setup/local.git/patch/e9802f50304f66984f6aad5544def465e9f8033b Yeah. Thanks, and sorry for the delay. Applied.