From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-44.mimecast.com (us-smtp-delivery-44.mimecast.com [207.211.30.44]) by sourceware.org (Postfix) with ESMTPS id 6989B3858D39 for ; Fri, 11 Mar 2022 05:38:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6989B3858D39 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-197-NSCBWL90OhKhEnUz6NrLDg-1; Fri, 11 Mar 2022 00:38:50 -0500 X-MC-Unique: NSCBWL90OhKhEnUz6NrLDg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7649951DF for ; Fri, 11 Mar 2022 05:38:49 +0000 (UTC) Received: from yselkowitz.remote.redhat.com (unknown [10.22.16.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 250454EC96 for ; Fri, 11 Mar 2022 05:38:48 +0000 (UTC) Message-ID: Subject: Re: Cygport configure script argument handling From: Yaakov Selkowitz To: cygwin-apps@cygwin.com Date: Fri, 11 Mar 2022 00:38:47 -0500 In-Reply-To: <20220310164157.r5nejhdgz4tcaprc@lucy.dinwoodie.org> References: <20220310164157.r5nejhdgz4tcaprc@lucy.dinwoodie.org> User-Agent: Evolution 3.42.2 (3.42.2-1.module_f35+13513+2c5bddf4) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=yselkowitz@cygwin.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: cygwin.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, BODY_8BITS, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_FAIL, SPF_HELO_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2022 05:39:00 -0000 On Thu, 2022-03-10 at 16:41 +0000, Adam Dinwoodie wrote: > I've fallen down a slight rabbit hole looking at the cygconf function in > Cygport's autotools.cygclass.=C2=A0 The specific bit of code that's causi= ng > me consternation is thus: >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0case "x${confver}" in > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0x2.6[0-9]*) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0con= fargs+=3D" --docdir=3D/usr/share/doc/${PN} --htmldir=3D/usr/share/doc/${PN}= /html" > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0;; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0*) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0con= fargs+=3D" --infodir=3D${prefix}/share/info --mandir=3D${prefix}/share/man" > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0;; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0esac >=20 > Firstly, I think the glob is incorrect: it looks like it was intended to > match files that came from Autoconf versions 2.60 and up -- 2.60 is when > Autoconf added the docdir and htmldir arguments -- but it has stopped > working as expected: Autoconf released 2.70 in December 2020, and is now > up to 2.71.=C2=A0 The above code won't match those versions. Yes, this likely needs to be updated for 2.70+. > Secondly -- and I'm not sure if this is intended or not -- I don't > understand why --infodir and --mandir are only defined for versions > prior to 2.60 (and, apparently unintentionally, 2.70 onwards).=C2=A0 Thos= e > are valid both before and after 2.60.=C2=A0 My best guess is that the int= ent > was for the first option to fall through to the second, so for 2.60+ all > four options would be defined, but that would have required `;&` or > `;;&` rather than `;;`. No. 2.60 included changes for these (and other) directory values: https://lists.gnu.org/archive/html/autotools-announce/2006-06/msg00002.html docdir and htmldir were added in 2.60, hence we don't want to pass them whe= n <=3D2.59 is detected. infodir and mandir were changed in 2.60, from $prefix/{info,man} (which cygport needed to override for FHS compliance) to $datarootdir/{info,man}, where the new datarootdir is $prefix/share, meanin= g they no longer needed to be overriden by cygport. HTH, --=20 Yaakov