From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2188 invoked by alias); 16 May 2017 14:00:52 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 1874 invoked by uid 89); 16 May 2017 14:00:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:sk:mail.me, H*r:sk:mail.me, Hx-languages-length:1210, H*RU:sk:mail.me X-HELO: out4-smtp.messagingengine.com Received: from out4-smtp.messagingengine.com (HELO out4-smtp.messagingengine.com) (66.111.4.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 May 2017 14:00:36 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id C712B208D6; Tue, 16 May 2017 10:00:36 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Tue, 16 May 2017 10:00:36 -0400 X-ME-Sender: Received: from [192.168.1.102] (host86-166-190-52.range86-166.btcentralplus.com [86.166.190.52]) by mail.messagingengine.com (Postfix) with ESMTPA id 56AC37E98A; Tue, 16 May 2017 10:00:36 -0400 (EDT) Subject: Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY) References: <20170428121205.12240-1-jon.turney@dronecode.org.uk> <20170428121205.12240-12-jon.turney@dronecode.org.uk> <3d79b33e-e067-c1df-9b90-084fb10dd272@dronecode.org.uk> <9452ab7f-986c-2394-8c24-6208e042787e@dronecode.org.uk> <506da115-b976-fdb2-bf1b-cec6addfbbbb@dronecode.org.uk> <0b6ab083-d470-c940-5557-d33be5c523cb@gmail.com> <664411e6-ac32-ab77-1b62-72bafc8bacd8@dronecode.org.uk> <60ed2d4e-7c89-a9b8-e3ab-e3d0819b7e56@gmail.com> To: cygwin-apps@cygwin.com Cc: =?UTF-8?Q?=c3=85ke_Rehnman?= From: Jon Turney Message-ID: Date: Tue, 16 May 2017 14:00:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2017-05/txt/msg00117.txt.bz2 On 04/05/2017 11:11, Jon Turney wrote: > On 03/05/2017 18:08, Åke Rehnman wrote: >> On 2017-05-03 18:37, Jon Turney wrote: >>> >>> * Allow wininet to handle file:// URLs >>> >>> I'm a little bit concerned that there may be current uses which rely >>> on the incorrect parsing we do of file:// URLs to work. >>> >>> Otoh, this should fix the file:// URL format we currently mishandle, >>> so is probably worth doing. >> I don't know how that could have ever worked... (or does it?) > > Not really, see the other branch of this thread. So, I taking another look at this: I am a bit confused about the behaviour I'm seeing, though. I'm expecting "file:///c:/path" and "file://host/path" to work, but they don't seem to. However, "file://c:/path" now works, which is good, and "file:////host/path" continues to work The documentation for InternetOpenUrl() says "Only URLs beginning with ftp:, http:, or https: are supported" so I'm wondering if this is really something we should be expecting to work... Also, is there a reason for the hunk in nio-file.cc removing the reporting of a problem opening the file?