From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from re-prd-fep-049.btinternet.com (mailomta17-re.btinternet.com [213.120.69.110]) by sourceware.org (Postfix) with ESMTPS id 6FDB23858D1E for ; Sat, 13 Jan 2024 14:49:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6FDB23858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dronecode.org.uk ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6FDB23858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=213.120.69.110 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705157389; cv=none; b=apUz7RRTcgw+RkPiSGan1bxuf5ESPxFHxIqXl/ef1f+HECyc7wYs5ELd2B5g4o7smlT+oE2Wj/yC5fAyR8/ps+vlGZAJEFUJyzvK/zwhLuhzgNfw6Qi7Jtj7/xzVVWIahfeh/7InM3Y+J9gJk6Nos3OzxLznUokskZFnNd6Np/4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705157389; c=relaxed/simple; bh=XZmHKXcOOLfBoduqVYPxncuCTQlMhAUTTjMSemLz4CI=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=K6/y92zDvorIm23ASeQ4to7wlqxxh22I+NHbMvHCNtKLjGU2Y7HuGZp+fXBi4Qwlqb2Fbm0FQZZT5I9Ibw2NqW6UlUbXHykfmltpzWpkiyFJU2krcqIZwRl/NhVnN+uBZyCA4D5ohjRikOFi74wN3pDQ/lynnVqkH0EEYfnS62A= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from re-prd-rgout-005.btmx-prd.synchronoss.net ([10.2.54.8]) by re-prd-fep-049.btinternet.com with ESMTP id <20240113144946.UWAH8012.re-prd-fep-049.btinternet.com@re-prd-rgout-005.btmx-prd.synchronoss.net>; Sat, 13 Jan 2024 14:49:46 +0000 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 6577B9C503E4121F X-Originating-IP: [86.139.158.103] X-OWM-Source-IP: 86.139.158.103 X-OWM-Env-Sender: jon.turney@dronecode.org.uk X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeijedgieelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuueftkffvkffujffvgffngfevqffopdfqfgfvnecuuegrihhlohhuthemuceftddunecunecujfgurhepkfffgggfuffvfhfhvegjtgfgsehtjeertddtvdejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpeevvdekgfffteetueehgfdugefgkeevleejudduheevuedtveejfeevvdevvdfgvdenucfkphepkeeirddufeelrdduheekrddutdefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurddutdejngdpihhnvghtpeekiedrudefledrudehkedruddtfedpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepsghoohhlvggrnhhlrggsvghlsehgmhgrihhlrdgtohhmpdhrtghpthhtoheptgihghifihhnqdgrphhpshestgihghifihhnrdgtohhmpdhrvghvkffrpehhohhsthekiedqudefledqudehkedquddtfedrrhgrnhhgvgekiedqudefledrsghttggvnhhtrhgrlhhplhhushdrtghomhdprghuthhhpghushgvrhepjhhonhhtuhhrnhgvhiessghtihhnthgvrhhnvghtrdgtohhmpdhgvghokffrpefiuedpoffv tefjohhstheprhgvqdhprhguqdhrghhouhhtqddttdeh X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.107] (86.139.158.103) by re-prd-rgout-005.btmx-prd.synchronoss.net (authenticated as jonturney@btinternet.com) id 6577B9C503E4121F; Sat, 13 Jan 2024 14:49:46 +0000 Message-ID: Date: Sat, 13 Jan 2024 14:49:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH cygport] git.cygclass: Suppress the depth option Content-Language: en-GB To: Daisuke Fujimura References: From: Jon Turney Cc: cygwin-apps@cygwin.com In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 16/12/2023 15:38, Daisuke Fujimura via Cygwin-apps wrote: > I have implemented a curl-based smart transport check. How about this one? Thanks. Again, sorry about my terrible slowness in reviewing this. > diff --git a/cygclass/git.cygclass b/cygclass/git.cygclass > index e53a7985..f3ed343e 100644 > --- a/cygclass/git.cygclass > +++ b/cygclass/git.cygclas [...] > > + check_prog_req curl > + curl -is ${GIT_URI}/info/refs?service=git-upload-pack | grep > --binary-files=text -i '^content-type:\sapplication/x-git-upload-pack' >> & /dev/null && _branch="${_depth} ${_branch}" > + It seems like this is going to give a false negative on 'git://' transport URLs? Maybe we should check if GIT_URI starts 'http(|s)://' ?