From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2796 invoked by alias); 15 Jan 2018 19:02:29 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 2155 invoked by uid 89); 15 Jan 2018 19:01:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=criteria, replicate, consequences, our X-HELO: out1-smtp.messagingengine.com Received: from out1-smtp.messagingengine.com (HELO out1-smtp.messagingengine.com) (66.111.4.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 15 Jan 2018 19:01:45 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 9020720D3E for ; Mon, 15 Jan 2018 14:01:43 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Mon, 15 Jan 2018 14:01:43 -0500 X-ME-Sender: Received: from [192.168.1.102] (host86-179-112-242.range86-179.btcentralplus.com [86.179.112.242]) by mail.messagingengine.com (Postfix) with ESMTPA id 3A19E246CA for ; Mon, 15 Jan 2018 14:01:43 -0500 (EST) Subject: Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP) To: cygwin-apps@cygwin.com References: <20170531105015.162228-1-jon.turney@dronecode.org.uk> <488ba627-de58-ddc7-7f69-696adae76b8a@cornell.edu> <7a173f99-a2e1-a07c-a9df-5bebcf377957@cornell.edu> <87poau9znx.fsf@Rainer.invalid> <050204e5-0ed3-8e47-3825-58ec6a10f44f@cornell.edu> <87ingltcn0.fsf@Rainer.invalid> <4ed6c549-dddd-fc45-3ed8-f7339548d7cd@cornell.edu> <1ec0f4de-380f-c6d1-59e7-03570f36b80b@cornell.edu> <87609alczj.fsf@Rainer.invalid> <31df6cf0-1abd-9cb0-a5c3-3c2b0a7d069c@cornell.edu> <87e4ba12-ed92-1959-d8ae-ab51986f7036@dronecode.org.uk> <79d71e69-57a9-8303-79c8-ba2bfdd098d8@cornell.edu> <1ecbad19-013e-6cf2-7dd8-019f72f7be3b@cornell.edu> From: Jon Turney Message-ID: Date: Mon, 15 Jan 2018 19:02:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1ecbad19-013e-6cf2-7dd8-019f72f7be3b@cornell.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2018-01/txt/msg00053.txt.bz2 On 13/01/2018 19:56, Ken Brown wrote: > On 1/13/2018 9:14 AM, Jon Turney wrote: >> On 09/01/2018 15:49, Ken Brown wrote: >>> On 1/9/2018 10:37 AM, Ken Brown wrote: >>>> >>>> I just did a quick test, trying to uninstall B in the situation above, >>>> and it didn't work as expected.  Even though "Uninstall A" was the >>>> first >>>> solution, A didn't get uninstalled. >>> >>> In case you want to replicate this, what I actually tried was >>> uninstalling ImageMagick, which is required, directly or indirectly, >>> by asymptote, dblatex, and xmlto.  Solution 1 was to uninstall these >>> three but it didn't happen. >> >> Doh. >> >> solver_take_solution() modifies the task list (and I went to the >> trouble of refactoring things to make it available to it), but I >> didn't then re-solve with the modified task list. >> >> Also, looking at this again, it looks like the solver places solutions >> which remove a task at the end of of the solution list, so this should >> be the default >> >> (This matches the previous behaviour, where the default is to accept >> dependencies i.e. if you try to remove a package required by other >> packages, the default solution should be to cancel the removal) >> >> Maybe we need more complex criteria to identify the default, but this >> seems to work in my limited testing. > > I noticed two things: > > 1. I think the code you added to PrereqPage::OnNext() also needs to be > added to PrereqPage::OnBack(). Hmm... not sure. I don't think we want to applyDefaultProblemSolutions(), because the user should solve the problems their way. As to finalize(): Not doing augmentTasks() means that a reinstall would disappear when we go back, so I guess we need that. I don't think we want to addSource() as the consequences of that are never shown in the chooser, currently. > 2. We should probably remove, or at least reword, the dire warning about > accepting the default solutions.  I'm not sure we want to "strongly > recommend" the default solution over the other solution(s).  I guess > what we really want to say is that we strongly recommend resolving the > problems before continuing. Yes, good point. I added your patch.