From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2136.outbound.protection.outlook.com [40.107.223.136]) by sourceware.org (Postfix) with ESMTPS id 283C93857C4A for ; Sat, 15 Aug 2020 21:50:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 283C93857C4A ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jMZhT0CxP8Y/YFUimmKeLDP2JFFbpn0o7oVA+sZpMdAkoq3ovwnXgnhW9lszGyUEpUi8uJs19sw3PXzUF/9eijMQCFTjGTBfh7co23rP7LeRMJWIBe3Chd2OX2tX9uhmS+CyeWAhAJSz+7lMCfi5JpU8Covm7btUJzH0u7zCJSpHmgAw1xGPsCdEIz0Qd7ZGY3MscKddQMcRruz5/zbS535lRhAggoKIJi5enznBtdqAh+PBRlr2D31UFq2Lm1OQJLcRBnAP0Hzv3uF9YINvRhTLBXXf+iExPjm5OFvkoNVCI+hW64DiFulT9sFwboIEwRt9vqblnzNFvF5RfGUW1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dRAemqAVra0CvZH1QypSaynze35hJMCXDDCZa2wUEDs=; b=Ff5KOsBFIbv/CunZpYliwWmLOAEm1Faft7PzYfzrlY7MOctNvHU7ZL7807CUjjeWHcKoRu9MxOAdfS8xQZNUtO00VWq/cmrnqe74Hp4tU5uWnmnCTQ+o5psUThNDbOsDmMsWjtcf10JIBVDgmOBjsilHk04OwIEm7OUgy6hDXPb5+le9223Yc0r+KTKZ0G/GZy6nITUfIHjs2Qd9y/pYAJK8wFB7eb1Y7Nyt07uZFRXZ2Oumfd/pj40wwfvLStpqWokkiBdfOfX3JEyoppSeD1vHBRJxt6v6brw/zcoDzfeOSvM1imBronIFLOXfoo3MP8NfFZTbo33UXntLUaXKBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none Received: from MN2PR04MB6176.namprd04.prod.outlook.com (2603:10b6:208:e3::13) by MN2PR04MB5904.namprd04.prod.outlook.com (2603:10b6:208:a6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.16; Sat, 15 Aug 2020 21:50:29 +0000 Received: from MN2PR04MB6176.namprd04.prod.outlook.com ([fe80::184d:a265:1d48:499a]) by MN2PR04MB6176.namprd04.prod.outlook.com ([fe80::184d:a265:1d48:499a%7]) with mapi id 15.20.3283.020; Sat, 15 Aug 2020 21:50:29 +0000 Subject: Re: [ANNOUNCEMENT] Updated: curl 7.71.1-1 To: cygwin-apps@cygwin.com References: <4f1d6241-c86b-f2f9-7b49-a9f5b998b0eb@SystematicSw.ab.ca> <53c7f2a7-3bd8-f90c-b574-969d6b31f300@cornell.edu> <71031f78-b1be-aec2-4e54-72ff49e07543@SystematicSw.ab.ca> <11d99d00-55fb-f6a2-893d-f5ebb6e7a14b@cornell.edu> <8c14a6d0-7c52-ee29-5026-a306166c2e87@SystematicSw.ab.ca> <09023890-2068-f323-14aa-df7848ddb681@SystematicSw.ab.ca> <87f28e0d-b815-2368-6c6b-335ccfa69f6f@SystematicSw.ab.ca> <26ba008f-fcb1-0953-6136-946abb12aa48@cornell.edu> From: Ken Brown Message-ID: Date: Sat, 15 Aug 2020 17:50:27 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BL0PR02CA0141.namprd02.prod.outlook.com (2603:10b6:208:35::46) To MN2PR04MB6176.namprd04.prod.outlook.com (2603:10b6:208:e3::13) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.17] (68.175.129.7) by BL0PR02CA0141.namprd02.prod.outlook.com (2603:10b6:208:35::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.16 via Frontend Transport; Sat, 15 Aug 2020 21:50:29 +0000 X-Originating-IP: [68.175.129.7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a59755fe-e6bd-40c9-6959-08d841653a20 X-MS-TrafficTypeDiagnostic: MN2PR04MB5904: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bE8pBbz3RBEVkBVgWIy474947uO1tOJ9EUbtaTZk5S5x7VyRz2IL/hu3YGkUuSlUEnpus0yotNOR5dcjaOq5K9tVbgkm6STOrof1wzYXwtFy5wWGt8hBs3sTM735Efwwfw2Ikkp7tYV2ZXEbJELR7q6V0zLqBsedFUsBxWNJwo1qg6IWV/Xy/6NbGHVxJPqnHVrkcbXaSAdR0YDZ42YsyzEa5zbpR6uF971V4knGT7E+yxZ7hZBKCJtCnmbzkxfrZRUvDwawmVSbypWVF1+BNzZlWFzYdtWhvjfCw5qpHf8u0L3Gne91vpia6Fuk2Hnp8YNqmpkWWLTYuRNZf/560Zq8xVAPRe6BkKhIYmdS98RKzpafDjgqkyrRKCVH7Pu+lsCzZiZPXNoO74goMq0QIwCO4dYmJuNYhhKFe7vuRJKKAI16uUDjFPy10usLOdUeymMv2y4Pu2D6/yfmRcSc8w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR04MB6176.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(39860400002)(346002)(136003)(396003)(786003)(316002)(16526019)(26005)(16576012)(186003)(2616005)(75432002)(53546011)(478600001)(2906002)(966005)(6916009)(86362001)(52116002)(5660300002)(66946007)(66556008)(956004)(66476007)(36756003)(31696002)(8936002)(31686004)(6486002)(83380400001)(8676002)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: kAnr8GwUI6fdNGURmhnpQzvrxIFi9/IA0AtqmlCEXEwn3H7Ve66fdtW8k9v0PEwO16eg9u5N0b+T9hcn3SCx7MtjTm/OjifWjhEay8AsLcBsdmw3qfLxSGReDkHtBPO5CxtEagSwjVpi4aYVCPlDocbHuXq/GfysKkQDpXjAcGOlJ+kYEeP09bSy3R6+qxNScpzmQKCFlpRH1TOTNsf31pSaypqeJSrefiA2H634MGjBrrEtYE+1ra6S8cv/kmCn9CjjjwTZcch0RWCJ+JHMy1CIkxg+yAwK6ZVNTqcyVBEjXlHysb6cmWXb+rSyKJSF2UeGFqTvtvJiJj4KnKOQ35Qr5Rm8RKad7TTcXh1AXumodxMZod9f+P+V+VX9j/4jXxk4aDIApyHWhGli6fsjEBVZ1mWV9YfdXuKeNwTqUZS9K+d5n3xHpZ30qR/VZKmDAToxy4c0KYHvXH2tpwSZbzJrfFv90YP0K9b5zzHMdyAkEizkGSt0DwdJyvYXuTeOa/EDRuiBcVBTKKTwa1rvs3XUAjkoYaZ1WtQdcuymU5ADmgRaqyJvMDOXtLgydBhFrcTf+IbZJcbbtnSf/SstG8T5V8f0XpUeppNyEm0CL8SNXaiVf11kkktbOf4+LOi9mbffDBgIoHXGLCF4rp4jZw== X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: a59755fe-e6bd-40c9-6959-08d841653a20 X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6176.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2020 21:50:29.7099 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pEEjxjP97efln8eaBB+iXgsDetdrJPBS239exQa7Ri21ZTP+qpdaFNsLGc/nGIhaVv4M0yduNpIhHRwtEpXMWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB5904 X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_INVALID, DKIM_SIGNED, KAM_DMARC_STATUS, KAM_NUMSUBJECT, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Aug 2020 21:50:34 -0000 On 8/15/2020 5:32 PM, Brian Inglis wrote: > On 2020-08-14 13:36, Ken Brown via Cygwin-apps wrote: >> On 8/14/2020 2:45 PM, Brian Inglis wrote: >>> On 2020-08-14 12:19, Brian Inglis wrote: >>>> On 2020-08-11 16:00, Brian Inglis wrote: >>>>> On 2020-08-11 05:27, Adam Dinwoodie wrote: >>>>>> On Tue, 11 Aug 2020 at 12:14, Ken Brown via Cygwin wrote: >>>>>>>> In that case, it looks to me as if the generated curl-config --libs >>>>>>>> statements: >>>>>>>> >>>>>>>>           if test "Xyes" = "Xno" -o "Xyes" = "Xyes"; then >>>>>>>>             echo ${CURLLIBDIR}-lcurl -lnghttp2 -lidn2 -lssh -lpsl -lssl >>>>>>>> -lcrypto >>>>>>>> -lldap -llber -lbrotlidec -lbrotlidec -lz >>>>>>>> >>>>>>>> based on curl-config.in: >>>>>>>> >>>>>>>>           if test "X@ENABLE_SHARED@" = "Xno" -o "X@REQUIRE_LIB_DEPS@" = >>>>>>>> "Xyes"; then >>>>>>>>             echo ${CURLLIBDIR}-lcurl @LIBCURL_LIBS@ >>>>>>>> >>>>>>>> REQUIRE_LIB_DEPS should be no, derived from configure.ac: >>>>>>>> >>>>>>>> if test "X$enable_shared" = "Xyes" -a "X$link_all_deplibs" = "Xno" >>>>>>>> then >>>>>>>>       REQUIRE_LIB_DEPS=no >>>>>>>> else >>>>>>>>       REQUIRE_LIB_DEPS=yes >>>>>>>> fi >>>>>>>> AC_SUBST(REQUIRE_LIB_DEPS) >>>>>>>> AM_CONDITIONAL(USE_EXPLICIT_LIB_DEPS, test x$REQUIRE_LIB_DEPS = xyes) >>>>>>>> >>>>>>>> but for Cygwin link_all_deplibs remains defaulted to unknown, so either that >>>>>>>> variable should be set in configure, or that condition should perhaps be >>>>>>>> changed >>>>>>>> to: >>>>>>>> >>>>>>>> if test "X$enable_shared" = "Xyes" -a "X$link_all_deplibs" != "Xyes" >>>>>>>> >>>>>>>> with appropriate bug reports and changes to be made upstream if possible. >>>>>>> >>>>>>> If you want to look into ways of fixing curl-config different from what >>>>>>> Yaakov >>>>>>> did, that's fine; you're the maintainer.  All I did was look at Yaakov's >>>>>>> patch >>>>>>> and port it to curl 7.71.1, that being a quick and easy way to fix the >>>>>>> reported >>>>>>> problem. >>>>>> >>>>>> Someone else did raise this problem upstream at >>>>>> https://github.com/curl/curl/issues/5793, and the comments there imply >>>>>> they'd be interested in integrating patches Cygwin uses into the >>>>>> upstream code, although the upstream maintainers aren't going to do >>>>>> that without someone proactively submitting the patch to them. >>>>> >>>>> I'll copy these comments and suggestions and follow up there, as that >>>>> appears to >>>>> be the official bug tracker, and they appear receptive to discussing and fixing >>>>> issues. >>>>> >>>>>> For my part, I'm not particularly fussed whether this is fixed with an >>>>>> upstream patch or a Cygwin patch; I just want my use cases to work, >>>>>> and as of 7.71.1-1 they don't. That said, my experience of being a >>>>>> package maintainer would lead me to want to submit patches upstream if >>>>>> at all possible, just to reduce the need to handle these sorts of >>>>>> problems. My inclination would be to restore the patched behaviour >>>>>> with Ken's new patch as a short-term fix, then get this submitted >>>>>> upstream so that in the long-term this patch can be retired. >>>>> >>>>> I did not see or get your original email, and could not reproduce your issue >>>>> using the current git source package, curl package, and cygport. >>>>> That could be due to two missing perl modules (solved in another sub-thread by >>>>> Achim). >>>>> Any suggestions as to what may be required to get curl-config to act up in a >>>>> build would be appreciated. >>>>> It is always easier to check if a problem is actually fixed when you can >>>>> perform >>>>> an in situ regression test. >>>>> Running curl-config and reading the docs, it does not appear to me to be >>>>> clearly >>>>> specified why and when dynamic and static library parameters are either >>>>> built in >>>>> or generated, whereas the conditions for reproducing the output are well >>>>> specified for pkgconf/pkg-config. >>>>> That may become more apparent in follow ups on the bug tracker. >>>> >>>> [Followed up on Github curl bug tracker and may have patch, but subsequent >>>> problems building tests, which KB may know something about, so moving to >>>> cygwin-apps] >>> >>> Test build failures - tried adding to cygport: >>> >>> src_test() { >>>          cd ${B} >>>          cygtest LDFLAGS="${LDFLAGS} -no-undefined" >>> } >>> >>> but no change: >>> >>> Making all in libtest >>> make[2]: Entering directory >>> '/home/$USER/src/cygwin/curl/curl-7.71.1-2.x86_64/build/tests/libtest' >>>    CCLD     libstubgss.la >>> libtool:   error: can't build x86_64-pc-cygwin shared library unless >>> -no-undefined is specified >>> make[2]: *** [Makefile:2547: libstubgss.la] Error 1 >>> make[2]: Target 'all' not remade because of errors. >>> make[2]: Leaving directory >>> '/home/$USER/src/cygwin/curl/curl-7.71.1-2.x86_64/build/tests/libtest' >>> Making all in unit >>> make[2]: Entering directory >>> '/home/$USER/src/cygwin/curl/curl-7.71.1-2.x86_64/build/tests/unit' >>> make[2]: Nothing to be done for 'all'. >>> make[2]: Leaving directory >>> '/home/$USER/src/cygwin/curl/curl-7.71.1-2.x86_64/build/tests/unit' >>> make[2]: Entering directory >>> '/home/$USER/src/cygwin/curl/curl-7.71.1-2.x86_64/build/tests' >>> make[2]: Nothing to be done for 'all-am'. >>> make[2]: Leaving directory >>> '/home/$USER/src/cygwin/curl/curl-7.71.1-2.x86_64/build/tests' >>> make[1]: *** [Makefile:513: all-recursive] Error 1 >>> make[1]: Target 'all' not remade because of errors. >>> make[1]: Target 'quiet-test' not remade because of errors. >>> make[1]: Leaving directory >>> '/home/$USER/src/cygwin/curl/curl-7.71.1-2.x86_64/build/tests' >>> make: *** [Makefile:1437: test] Error 2 >> >> The attached patch should fix it.  I didn't take the trouble to write the patch >> in a way that's suitable for sending upstream.  If you want to do that, you >> could imitate what's done for libhostname.la a little earlier in the same >> Makefile.am.  But I recommend that you first get curl 7.71.1-2 released before >> spending time polishing the patch. > > Thanks for the patches, pointers, and help understanding more of the autotools > granular infrastructure. You're welcome. Glad I could help. > I was able to polish the patch thanks to your pointers while waiting for the 32 > bit x86 build, rebuild and retest both arches last night, and upload and > announce today. > I will submit that upstream to the curl project developer on Github, now I know > the project lives there. Great. I think it would be good if we maintainers did more of that (sending patches upstream). I'm as guilty as anyone here. Sometimes it just seems like too much trouble. Ken