From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout12.t-online.de (mailout12.t-online.de [194.25.134.22]) by sourceware.org (Postfix) with ESMTPS id D97D6384602A for ; Wed, 29 Jun 2022 18:35:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D97D6384602A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=t-online.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=t-online.de Received: from fwd71.dcpf.telekom.de (fwd71.aul.t-online.de [10.223.144.97]) by mailout12.t-online.de (Postfix) with SMTP id E3F92EBFB for ; Wed, 29 Jun 2022 20:35:30 +0200 (CEST) Received: from [192.168.2.102] ([87.187.34.65]) by fwd71.t-online.de with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted) esmtp id 1o6cXB-3blxZY0; Wed, 29 Jun 2022 20:35:29 +0200 Subject: Re: [PATCH setup] Add perpetual support for preremove scripts From: Christian Franke To: "cygwin-apps@cygwin.com" References: Message-ID: Date: Wed, 29 Jun 2022 20:35:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 SeaMonkey/2.53.12 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------7ABB17A586EC2EB3B84BCB95" X-TOI-EXPURGATEID: 150726::1656527729-014319F2-FE57AC3E/0/0 CLEAN NORMAL X-TOI-MSGID: 95cc2f1a-9acc-43ef-ab0a-5c580b451296 X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2022 18:35:41 -0000 This is a multi-part message in MIME format. --------------7ABB17A586EC2EB3B84BCB95 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Christian Franke wrote: > Jon Turney wrote: >> On 26/06/2022 17:33, Christian Franke wrote: >>> ... >>> This patch adds the missing functionality to run the pre-install >>> hook. It is limited to /etc/preremove/0p_* because there is possibly >>> no use case for /etc/preremove/zp_*. >> >> Thanks. >> >> I'm not sure what you mean by 'there is possibly no use case': That >> you don't have one currently, or that you've reasoned that there >> can't be one? >> > > I don't have one currently and found none which is useful in practice, > but cannot prove that there is none. If desired, I could provide a > patch which adds 'zp_*' support. > Meantime I realized that this is one of these cases where discussion may take longer than implementation. Attached is a patch ... >> ... >> >> I applied this patch. >> > > Thanks. I found a minor GUI issue during testing: Script filename > display persists during package remove phase. Fixed with attached patch. ... which should be applied on top of this last patch. --------------7ABB17A586EC2EB3B84BCB95 Content-Type: text/plain; charset=UTF-8; name="0001-Also-run-stratum-z-perpetual-preremove-scripts.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Also-run-stratum-z-perpetual-preremove-scripts.patch" RnJvbSA3ZTMzNTBmNjMzZjE4ZTU2MzlhMTA5ZTBkNzc5NDczZTk0OWViZTU3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDaHJpc3RpYW4gRnJhbmtlIDxjaHJpc3RpYW4uZnJh bmtlQHQtb25saW5lLmRlPgpEYXRlOiBXZWQsIDI5IEp1biAyMDIyIDE5OjU3OjI2ICswMjAw ClN1YmplY3Q6IFtQQVRDSF0gQWxzbyBydW4gc3RyYXR1bSAneicgcGVycGV0dWFsIHByZXJl bW92ZSBzY3JpcHRzCgotLS0KIGluc3RhbGwuY2MgfCAyOSArKysrKysrKysrKysrKysrKy0t LS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDEyIGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL2luc3RhbGwuY2MgYi9pbnN0YWxsLmNjCmluZGV4IDBj ZWIwNWYuLjFmZGM2OTkgMTAwNjQ0Ci0tLSBhL2luc3RhbGwuY2MKKysrIGIvaW5zdGFsbC5j YwpAQCAtNzYsMjYgKzc2LDI4IEBAIHN0cnVjdCBzdGRfZGlyc190IHsKICAgbW9kZV90IG1v ZGU7CiB9OwogCi1jbGFzcyBQZXJwZXR1YWwwUmVtb3ZlRmluZFZpc2l0b3IgOiBwdWJsaWMg RmluZFZpc2l0b3IKK2NsYXNzIFBlcnBldHVhbFJlbW92ZUZpbmRWaXNpdG9yIDogcHVibGlj IEZpbmRWaXNpdG9yCiB7CiBwdWJsaWM6Ci0gIGV4cGxpY2l0IFBlcnBldHVhbDBSZW1vdmVG aW5kVmlzaXRvciAoc3RkOjp2ZWN0b3I8U2NyaXB0PiAqc2NyaXB0cykKLSAgICA6IF9zY3Jp cHRzKHNjcmlwdHMpCisgIFBlcnBldHVhbFJlbW92ZUZpbmRWaXNpdG9yIChzdGQ6OnZlY3Rv cjxTY3JpcHQ+ICpzY3JpcHRzLCBjb25zdCBzdGQ6OnN0cmluZyYgc3RyYXR1bSkKKyAgICA6 IF9zY3JpcHRzKHNjcmlwdHMpLAorICAgICAgc3RyYXR1bShzdHJhdHVtKQogICB7fQogICB2 aXJ0dWFsIHZvaWQgdmlzaXRGaWxlKGNvbnN0IHN0ZDo6c3RyaW5nJiBiYXNlUGF0aCwKICAg ICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBXSU4zMl9GSU5EX0RBVEEgKnRoZUZpbGUp CiAgICAgewogICAgICAgc3RkOjpzdHJpbmcgZm4gPSBzdGQ6OnN0cmluZygiL2V0Yy9wcmVy ZW1vdmUvIikgKyB0aGVGaWxlLT5jRmlsZU5hbWU7CiAgICAgICBTY3JpcHQgc2NyaXB0KGZu KTsKLSAgICAgIGlmIChzY3JpcHQuaXNfcCgiMCIpKQorICAgICAgaWYgKHNjcmlwdC5pc19w KHN0cmF0dW0pKQogCSAgX3NjcmlwdHMtPnB1c2hfYmFjayhTY3JpcHQgKGZuKSk7CiAgICAg fQotICB2aXJ0dWFsIH4gUGVycGV0dWFsMFJlbW92ZUZpbmRWaXNpdG9yICgpIHt9CisgIHZp cnR1YWwgfiBQZXJwZXR1YWxSZW1vdmVGaW5kVmlzaXRvciAoKSB7fQogcHJvdGVjdGVkOgot ICBQZXJwZXR1YWwwUmVtb3ZlRmluZFZpc2l0b3IgKFBlcnBldHVhbDBSZW1vdmVGaW5kVmlz aXRvciBjb25zdCAmKTsKLSAgUGVycGV0dWFsMFJlbW92ZUZpbmRWaXNpdG9yICYgb3BlcmF0 b3I9IChQZXJwZXR1YWwwUmVtb3ZlRmluZFZpc2l0b3IgY29uc3QgJik7CisgIFBlcnBldHVh bFJlbW92ZUZpbmRWaXNpdG9yIChQZXJwZXR1YWxSZW1vdmVGaW5kVmlzaXRvciBjb25zdCAm KTsKKyAgUGVycGV0dWFsUmVtb3ZlRmluZFZpc2l0b3IgJiBvcGVyYXRvcj0gKFBlcnBldHVh bFJlbW92ZUZpbmRWaXNpdG9yIGNvbnN0ICYpOwogcHJpdmF0ZToKICAgc3RkOjp2ZWN0b3I8 U2NyaXB0PiAqX3NjcmlwdHM7CisgIGNvbnN0IHN0ZDo6c3RyaW5nIHN0cmF0dW07CiB9Owog CiBjbGFzcyBJbnN0YWxsZXIKQEAgLTEwNSw3ICsxMDcsNyBAQCBjbGFzcyBJbnN0YWxsZXIK ICAgICBJbnN0YWxsZXIoKTsKICAgICB2b2lkIGluaXREaWFsb2coKTsKICAgICB2b2lkIHBy b2dyZXNzIChpbnQgYnl0ZXMpOwotICAgIHZvaWQgcHJlcmVtb3ZlUGVycGV0dWFsMCAoKTsK KyAgICB2b2lkIHByZXJlbW92ZVBlcnBldHVhbCAoY29uc3Qgc3RkOjpzdHJpbmcmIHN0cmF0 dW0pOwogICAgIHZvaWQgcHJlcmVtb3ZlT25lIChwYWNrYWdlbWV0YSAmKTsKICAgICB2b2lk IHVuaW5zdGFsbE9uZSAocGFja2FnZW1ldGEgJik7CiAgICAgdm9pZCByZXBsYWNlT25SZWJv b3RGYWlsZWQgKGNvbnN0IHN0ZDo6c3RyaW5nJiBmbik7CkBAIC0xNzcsMTYgKzE3OSwxNiBA QCBJbnN0YWxsZXI6OlN0YW5kYXJkRGlyc1tdID0gewogc3RhdGljIGludCBudW1faW5zdGFs bHMsIG51bV91bmluc3RhbGxzOwogCiB2b2lkCi1JbnN0YWxsZXI6OnByZXJlbW92ZVBlcnBl dHVhbDAgKCkKK0luc3RhbGxlcjo6cHJlcmVtb3ZlUGVycGV0dWFsIChjb25zdCBzdGQ6OnN0 cmluZyYgc3RyYXR1bSkKIHsKICAgc3RkOjp2ZWN0b3I8U2NyaXB0PiBwZXJwZXR1YWw7Ci0g IFBlcnBldHVhbDBSZW1vdmVGaW5kVmlzaXRvciB2aXNpdG9yICgmcGVycGV0dWFsKTsKKyAg UGVycGV0dWFsUmVtb3ZlRmluZFZpc2l0b3IgdmlzaXRvciAoJnBlcnBldHVhbCwgc3RyYXR1 bSk7CiAgIEZpbmQgKGN5Z3BhdGggKCIvZXRjL3ByZXJlbW92ZSIpKS5hY2NlcHQgKHZpc2l0 b3IpOwogICBpZiAocGVycGV0dWFsLmVtcHR5KCkpCiAgICAgcmV0dXJuOwogCiAgIFByb2dy ZXNzLlNldFRleHQxIChJRFNfUFJPR1JFU1NfUFJFUkVNT1ZFKTsKLSAgUHJvZ3Jlc3MuU2V0 VGV4dDIgKCIwL1BlcnBldHVhbCIpOworICBQcm9ncmVzcy5TZXRUZXh0MiAoKHN0cmF0dW0g KyAiL1BlcnBldHVhbCIpLmNfc3RyICgpKTsKICAgc3RkOjpzb3J0IChwZXJwZXR1YWwuYmVn aW4oKSwgcGVycGV0dWFsLmVuZCgpKTsKICAgZm9yIChzdGQ6OnZlY3RvcjxTY3JpcHQ+Ojpp dGVyYXRvciBpID0gcGVycGV0dWFsLmJlZ2luICgpOyBpICE9IHBlcnBldHVhbC5lbmQgKCk7 ICsraSkgewogICAgIFByb2dyZXNzLlNldFRleHQzIChpLT5mdWxsTmFtZSAoKS5jX3N0cigp KTsKQEAgLTkwNSw3ICs5MDcsNyBAQCBkb19pbnN0YWxsX3RocmVhZCAoSElOU1RBTkNFIGgs IEhXTkQgb3duZXIpCiAKICAgLyogc3RhcnQgd2l0aCB1bmluc3RhbGxzIC0gcmVtb3ZlIGZp bGVzIHRoYXQgbmV3IHBhY2thZ2VzIG1heSByZXBsYWNlICovCiAgIFByb2dyZXNzLlNldEJh cjIoMCk7Ci0gIG15SW5zdGFsbGVyLnByZXJlbW92ZVBlcnBldHVhbDAgKCk7CisgIG15SW5z dGFsbGVyLnByZXJlbW92ZVBlcnBldHVhbCAoIjAiKTsKIAogICBQcm9ncmVzcy5TZXRCYXIy KDApOwogICBmb3IgKHN0ZDo6dmVjdG9yIDxwYWNrYWdldmVyc2lvbj46Oml0ZXJhdG9yIGkg PSB1bmluc3RhbGxfcS5iZWdpbiAoKTsKQEAgLTkxNyw2ICs5MTksOSBAQCBkb19pbnN0YWxs X3RocmVhZCAoSElOU1RBTkNFIGgsIEhXTkQgb3duZXIpCiAgICAgUHJvZ3Jlc3MuU2V0QmFy MihzdGQ6OmRpc3RhbmNlKHVuaW5zdGFsbF9xLmJlZ2luKCksIGkpICsgMSwgdW5pbnN0YWxs X3Euc2l6ZSgpKTsKICAgfQogCisgIFByb2dyZXNzLlNldEJhcjIoMCk7CisgIG15SW5zdGFs bGVyLnByZXJlbW92ZVBlcnBldHVhbCAoInoiKTsKKwogICBQcm9ncmVzcy5TZXRCYXIyKDAp OwogICBmb3IgKHN0ZDo6dmVjdG9yIDxwYWNrYWdldmVyc2lvbj46Oml0ZXJhdG9yIGkgPSB1 bmluc3RhbGxfcS5iZWdpbiAoKTsKICAgICAgICBpICE9IHVuaW5zdGFsbF9xLmVuZCAoKTsg KytpKQotLSAKMi4zNi4xCgo= --------------7ABB17A586EC2EB3B84BCB95--