From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout09.t-online.de (mailout09.t-online.de [194.25.134.84]) by sourceware.org (Postfix) with ESMTPS id CEB24385828D for ; Sun, 10 Mar 2024 16:33:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CEB24385828D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=t-online.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=t-online.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CEB24385828D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=194.25.134.84 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710088417; cv=none; b=eVMIdjiKbE2dZti7oIAUsRHokR0BcNrpyLUm3iYqcxn/zX+eSdLRHObsmQGKLnhhBesYxw3NqMtf/8FHSUT0c3imh+UCXgvVHYrZkZpHGK6QPU3J2HY0sOYUBqGxpZdZGlfhiH8Ws+Nhn3SYSJtfwTWLGxwmmIQIjew3z1GdR/8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710088417; c=relaxed/simple; bh=ODarpVRBwGEf77oCP8mOEB6PMqKvWdZ2S2yrJ3qmgKk=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=pmSay/NzuUuP7fyfLxLui7XSMJj4ikeCoWNVM4Pw3frHck1UF646nVGz4/HozdQYb2dx1cSVKgHD55GfTT2yThw+uv2NUlPGx6Yy1BgYBYgtkR5HQ7WQx9llMJuU/EiIith5XWizl4VQHgSkf9+BfHVE5pc87NOBYiCrxpH3QAE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fwd73.aul.t-online.de (fwd73.aul.t-online.de [10.223.144.99]) by mailout09.t-online.de (Postfix) with SMTP id EF9F439B26 for ; Sun, 10 Mar 2024 17:33:31 +0100 (CET) Received: from [192.168.2.102] ([87.187.47.57]) by fwd73.t-online.de with (TLSv1.3:TLS_AES_256_GCM_SHA384 encrypted) esmtp id 1rjM78-0RsXQm0; Sun, 10 Mar 2024 17:33:30 +0100 Subject: Re: [PATCH cygport] Add customization support for announce command To: cygwin-apps@cygwin.com References: <2c21353b-f249-d03f-a9fa-68f0e56b9dcb@t-online.de> <20d64930-9c17-4fb0-861e-3145b5d67601@dronecode.org.uk> Reply-To: cygwin-apps@cygwin.com From: Christian Franke Message-ID: Date: Sun, 10 Mar 2024 17:33:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 SeaMonkey/2.53.16 MIME-Version: 1.0 In-Reply-To: <20d64930-9c17-4fb0-861e-3145b5d67601@dronecode.org.uk> Content-Type: multipart/mixed; boundary="------------EADBBCA58531FC5A583F08B2" X-TOI-EXPURGATEID: 150726::1710088410-DD1C2917-98EA773C/0/0 CLEAN NORMAL X-TOI-MSGID: 719911f4-f201-429b-a7bf-3f106f304949 X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_FILL_THIS_FORM_SHORT,T_SCC_BODY_TEXT_LINE,WEBMAIL_BODY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------EADBBCA58531FC5A583F08B2 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Jon Turney wrote: > On 23/02/2024 11:23, Christian Franke via Cygwin-apps wrote: >> Christian Franke wrote: >>> The email generated by the cygport announce command is useful, but >>> actual use cases are somewhat limited due to the hard-coded email >>> submission. >>> >>> The attached patch adds more flexibility. The patch is on top of the >>> "Use correct wording if only one package is announced" patch. >> >> Slightly changed patch attached. Also adjusted to new version of "Use >> correct wording if only one package is announced" patch. >> >> > [...] > > Thanks for this. > >> Possible (better?) alternative names for the new settings: >> ANNOUNCEMENT_EDITOR >> ANNOUNCEMENT_MAILER > > Hmmm... I think "ANNOUNCE_EDITOR" and "ANNOUNCE_MAILER" would be > the best for clarity and conciseness. New patch attached. Is still on top of "Use correct wording ..." patch. I also added HOMEPAGE to the propagated variables as this should be included in an announcement. > > >> -From: ${SMTP_SENDER} >> -To: cygwin-announce@cygwin.com >> +${SMTP_SENDER:+From: ${SMTP_SENDER} >> +}To: cygwin-announce@cygwin.com >>  Date: $(date -R --date=${msgat}) >> -Message-Id: <$(date "+%Y%m%d%H%M%S.$$" --date=${msgat})-1-$(echo >> ${SMTP_SENDER} | sed 's|.*<\(.*\)>.*|\1|')> >> +Message-Id: <$(date "+%Y%m%d%H%M%S.$$" --date=${msgat})-1-$(echo >> ${SMTP_SENDER:-cygport} | sed 's|.*<\(.*\)>.*|\1|')> >>  Subject: ${NAME} ${PVR} > > Can you also explain what this is doing in the commit message, since > it's not immediately apparent. > > If the mail infrastructure always replaces the "From:" line or the default one is sufficient, then there is no need to generate one. SMTP_SENDER could be left alone then. I added a related comment to cygport.conf --------------EADBBCA58531FC5A583F08B2 Content-Type: text/plain; charset=UTF-8; name="0001-Add-customization-support-for-announce-command.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Add-customization-support-for-announce-command.patch" RnJvbSAzMzVjYmRlM2M2YzI0NTAwNTFjYzczOWNlZTYwYTU1NWIyMzY4NDNlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDaHJpc3RpYW4gRnJhbmtlIDxjaHJpc3RpYW4uZnJh bmtlQHQtb25saW5lLmRlPgpEYXRlOiBTdW4sIDEwIE1hciAyMDI0IDE3OjI4OjA5ICswMTAw ClN1YmplY3Q6IFtQQVRDSF0gQWRkIGN1c3RvbWl6YXRpb24gc3VwcG9ydCBmb3IgYW5ub3Vu Y2UgY29tbWFuZAoKVHdvIG5ldyBjb25maWd1cmF0aW9uIHNldHRpbmdzIGFsbG93IHRvIG92 ZXJyaWRlIHRoZSBsYXVuY2ggb2YKYSB0ZXh0IGVkaXRvciAoQU5OT1VOQ0VfRURJVE9SKSBh bmQgdGhlIGJ1aWx0aW4gZW1haWwgc3VibWlzc2lvbgooQU5OT1VOQ0VfTUFJTEVSKS4gIERv bid0IGNyZWF0ZSBhICJGcm9tOiIgaGVhZGVyIGxpbmUgaWYKU01UUF9TRU5ERVIgaXMgdW5k ZWZpbmVkIG9yIGVtcHR5LgotLS0KIGRhdGEvY3lncG9ydC5jb25mICAgICAgfCAyNyArKysr KysrKysrKysrKysrKysrLQogbGliL3BrZ191cGxvYWQuY3lncGFydCB8IDU3ICsrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCA3 NyBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RhdGEvY3ln cG9ydC5jb25mIGIvZGF0YS9jeWdwb3J0LmNvbmYKaW5kZXggMzRjY2QyOTEuLjNkYTc0NGQ5 IDEwMDY0NAotLS0gYS9kYXRhL2N5Z3BvcnQuY29uZgorKysgYi9kYXRhL2N5Z3BvcnQuY29u ZgpAQCAtMTAxLDEwICsxMDEsMzUgQEAKICNQQUdFUj0KIAogCisjKioqKnYqIENvbmZpZ3Vy YXRpb24vQU5OT1VOQ0VfRURJVE9SCisjICBERVNDUklQVElPTgorIyAgU2hlbGwgY29tbWFu ZCBzdHJpbmcgdG8gcHJvY2VzcyB0aGUgZW1haWwgbWVzc2FnZSBjcmVhdGVkIGJ5IGN5Z3Bv cnQncworIyAgYW5ub3VuY2UgY29tbWFuZCBiZWZvcmUgc2VuZGluZyB0aGUgZW1haWwuICBJ ZiB1bmRlZmluZWQsIGEgdGV4dCBlZGl0b3IKKyMgIHdpbGwgYmUgcnVuLCBzZWUgRURJVE9S IHNldHRpbmcgYWJvdmUuICBJZiBlbXB0eSwgbm90aGluZyB3aWxsIGJlIHJ1bi4KKyMgIElm IG5vdCBlbXB0eSwgJy9iaW4vYmFzaCcgd2lsbCBiZSBsYXVuY2hlZCB3aXRoIHRoZSBjb21t YW5kIHN0cmluZyBwYXNzZWQKKyMgIHdpdGggJy1jJyBvcHRpb24gYW5kIHRoZSBwYXRoIG9m IHRoZSB0ZW1wb3JhcnkgZW1haWwgbWVzc2FnZSBmaWxlIGFzICckMScuCisjICBUaGUgd29y a2luZyBkaXJlY3Rvcnkgb2YgdGhlIHNoZWxsIHdpbGwgYmUgdGhlIGRpcmVjdG9yeSBvZiB0 aGUgY3lncG9ydAorIyAgZmlsZS4gIFRoZSBzcGVjaWZpZWQgY29tbWFuZCBzdHJpbmcgd2ls bCBiZSBwcmVwZW5kZWQgYnkgc2hlbGwgYXNzaWdubWVudHMKKyMgIG9mIHRoZSBjeWdwb3J0 IHZhcmlhYmxlcyBIT01FUEFHRSwgUCwgUEYsIFBOLCBQUiBhbmQgUFYgYW5kIGFsbCBTTVRQ XyoKKyMgIHNldHRpbmdzIGRlc2NyaWJlZCBiZWxvdy4KKyNBTk5PVU5DRV9FRElUT1I9CisK KyMqKioqdiogQ29uZmlndXJhdGlvbi9BTk5PVU5DRV9NQUlMRVIKKyMgIERFU0NSSVBUSU9O CisjICBTaGVsbCBjb21tYW5kIHN0cmluZyB0byBwcm9jZXNzIHRoZSBlbWFpbCBtZXNzYWdl IGNyZWF0ZWQgYnkgY3lncG9ydCdzCisjICBhbm5vdW5jZSBjb21tYW5kIGFmdGVyIGVkaXRp bmcuICBJZiB1bmRlZmluZWQsIHRoZSBlbWFpbCB3aWxsIGJlIHNlbnQKKyMgIHVzaW5nIHRo ZSBidWlsdGluIHBlcmwtYmFzZWQgU01UUCBzdXBwb3J0LiAgSWYgZW1wdHksIG5vdGhpbmcg d2lsbCBiZSBydW4uCisjICBJZiBub3QgZW1wdHksIHRoZSBjb21tYW5kIHN0cmluZyB3aWxs IGJlIGhhbmRsZWQgc2ltaWxhciB0byBBTk5PVU5DRV9FRElUT1IKKyMgIGRlc2NyaWJlZCBh Ym92ZS4KKyNBTk5PVU5DRV9NQUlMRVI9CisKKwogIyoqKip2KiBDb25maWd1cmF0aW9uL1NN VFBfU0VOREVSCiAjICBERVNDUklQVElPTgogIyAgTmFtZSBhbmQgZW1haWwgYWRkcmVzcywg aW4gdGhlIGZvcm0gb2YgIkZpcnN0IExhc3QgPHVzZXJAZG9tYWluPiIgdG8gYmUgdXNlZAot IyAgYnkgY3lncG9ydCdzIGFubm91bmNlbWVudCBjb21tYW5kLgorIyAgYnkgY3lncG9ydCdz IGFubm91bmNlbWVudCBjb21tYW5kLiAgSWYgdW5kZWZpbmVkIG9yIGVtcHR5LCBubyAiRnJv bToiIGVtYWlsCisjICBoZWFkZXIgbGluZSB3aWxsIGJlIGdlbmVyYXRlZC4gIFRoZSBsb2Nh bCBtYWlsIHRvb2wgb3IgdGhlIG1haWwgcHJvdmlkZXIgbWF5CisjICB1bmNvbmRpdGlvbmFs bHkgcmVwbGFjZSB0aGlzIGhlYWRlciBsaW5lIG9yIG9ubHkgdGhlICI8dXNlckBkb21haW4+ IiBwYXJ0LgogIyAgTk9URQogIyAgTWFueSB3ZWJtYWlsIHNlcnZpY2VzIGRvIG5vdCBhbGxv dyB1c2luZyBhcmJpdHJhcnkgc2VuZGVyIGFkZHJlc3MgaW4gU01UUAogIyAgbWFpbCwgb3Ig bWF5IGZpcnN0IHJlcXVpcmUgcmVnaXN0ZXJpbmcgb3RoZXIgZW1haWwgYWRkcmVzc2VzIGFz IGF1dGhvcml6ZWQKZGlmZiAtLWdpdCBhL2xpYi9wa2dfdXBsb2FkLmN5Z3BhcnQgYi9saWIv cGtnX3VwbG9hZC5jeWdwYXJ0CmluZGV4IDM3YmMyZDYzLi45Y2VkMWZiNSAxMDA2NDQKLS0t IGEvbGliL3BrZ191cGxvYWQuY3lncGFydAorKysgYi9saWIvcGtnX3VwbG9hZC5jeWdwYXJ0 CkBAIC0xNjgsNiArMTY4LDM0IEBAIEVPRgogCWVjaG8gIlVwbG9hZCBjb21wbGV0ZS4iCiB9 CiAKK19fcGtnX2Fubm91bmNlX3J1bl9jbWRfb25fbXNnKCkgeworCWxvY2FsIGNtZHZhcj0k MQorCWxvY2FsIG1zZz0kMgorCWxvY2FsIGNtZAorCisJZXZhbCBjbWQ9IlwkeyR7Y21kdmFy fX0iCisKKwlpZiBbICIke2NtZDoreX0iICE9ICJ5IiBdCisJdGhlbgorCQlpbmZvcm0gIlwk eyR7Y21kdmFyfX0gaXMgZW1wdHkiCisJCXJldHVybiAwCisJZmkKKwllY2hvCisJaW5mb3Jt ICJMYXVuY2hpbmcgJ1wkeyR7Y21kdmFyfX0gJHttc2d9JyIKKworCS9iaW4vYmFzaCAtYyAi Y2QgJHt0b3B9IHx8IGV4aXQgMQorJHtIT01FUEFHRStIT01FUEFHRT0ke0hPTUVQQUdFQFF9 fQorUD0ke1BAUX07IFBGPSR7UEZAUX07IFBOPSR7UE5AUX07IFBSPSR7UFJAUX07IFBWPSgk e1BWWypdQFF9KQorJHtTTVRQX1NFTkRFUitTTVRQX1NFTkRFUj0ke1NNVFBfU0VOREVSQFF9 fQorJHtTTVRQX1NFUlZFUitTTVRQX1NFUlZFUj0ke1NNVFBfU0VSVkVSQFF9fQorJHtTTVRQ X1NFUlZFUl9QT1JUK1NNVFBfU0VSVkVSX1BPUlQ9JHtTTVRQX1NFUlZFUl9QT1JUQFF9fQor JHtTTVRQX0VOQ1JZUFRJT04rU01UUF9FTkNSWVBUSU9OPSR7U01UUF9FTkNSWVBUSU9OQFF9 fQorJHtTTVRQX1VTRVIrU01UUF9VU0VSPSR7U01UUF9VU0VSQFF9fQorJHtTTVRQX1BBU1Mr U01UUF9QQVNTPSR7U01UUF9QQVNTQFF9fQorJHtjbWR9CisiIAkJJDAgJHttc2d9IHx8IGVy cm9yICJDb21tYW5kICdcJHske2NtZHZhcn19ICR7bXNnfScgKGN3ZD0ke3RvcH0pIGZhaWxl ZCIKK30KKwogX19wa2dfYW5ub3VuY2UoKSB7CiAJbG9jYWwgbXNnPSQobWt0ZW1wIC10IGN5 Z3dpbi1hbm5vdW5jZS0ke1BGfS5YWFhYWFgpCiAJbG9jYWwgbXNnYXQ9JChkYXRlICtAJXMp CkBAIC0xNzgsMTAgKzIwNiwxMCBAQCBfX3BrZ19hbm5vdW5jZSgpIHsKIAogCWNhdCA+ICR7 bXNnfSA8PF9FT0YKIEZyb20gY3lnd2luLWFubm91bmNlLSR7UEZ9ICQoZGF0ZSAnKyVhICVi ICVkICVIOiVNOiVTICVZJyAtLWRhdGU9JHttc2dhdH0pCi1Gcm9tOiAke1NNVFBfU0VOREVS fQotVG86IGN5Z3dpbi1hbm5vdW5jZUBjeWd3aW4uY29tCiske1NNVFBfU0VOREVSOitGcm9t OiAke1NNVFBfU0VOREVSfQorfVRvOiBjeWd3aW4tYW5ub3VuY2VAY3lnd2luLmNvbQogRGF0 ZTogJChkYXRlIC1SIC0tZGF0ZT0ke21zZ2F0fSkKLU1lc3NhZ2UtSWQ6IDwkKGRhdGUgIisl WSVtJWQlSCVNJVMuJCQiIC0tZGF0ZT0ke21zZ2F0fSktMS0kKGVjaG8gJHtTTVRQX1NFTkRF Un0gfCBzZWQgJ3N8Lio8XCguKlwpPi4qfFwxfCcpPgorTWVzc2FnZS1JZDogPCQoZGF0ZSAi KyVZJW0lZCVIJU0lUy4kJCIgLS1kYXRlPSR7bXNnYXR9KS0xLSQoZWNobyAke1NNVFBfU0VO REVSOi1jeWdwb3J0fSB8IHNlZCAnc3wuKjxcKC4qXCk+Lip8XDF8Jyk+CiBTdWJqZWN0OiAk e05BTUV9ICR7UFZSfQogCiBUaGUgZm9sbG93aW5nIHBhY2thZ2Uke3NfaGF2ZX0gYmVlbiB1 cGxvYWRlZCB0byB0aGUgQ3lnd2luIGRpc3RyaWJ1dGlvbjoKQEAgLTE5OSw3ICsyMjcsMjQg QEAgX0VPRgogJHtERVNDUklQVElPTn0KIF9FT0YKIAotCSR7RURJVE9SOi12aX0gJG1zZyB8 fCBlcnJvciAiRWRpdG9yIGV4aXRlZCBhYm9ybWFsbHksIGFib3J0aW5nIGFubm91Y2VtZW50 IgorCWlmIFsgIiR7QU5OT1VOQ0VfRURJVE9SK3l9IiA9ICJ5IiBdCisJdGhlbgorCQlfX3Br Z19hbm5vdW5jZV9ydW5fY21kX29uX21zZyBBTk5PVU5DRV9FRElUT1IgJHttc2d9CisJZWxz ZQorCQkke0VESVRPUjotdml9ICR7bXNnfSB8fCBlcnJvciAiRWRpdG9yIGV4aXRlZCBhYm5v cm1hbGx5LCBhYm9ydGluZyBhbm5vdW5jZW1lbnQiCisJZmkKKworCWlmIFsgIiR7QU5OT1VO Q0VfTUFJTEVSK3l9IiA9ICJ5IiBdCisJdGhlbgorCQlfX3BrZ19hbm5vdW5jZV9ydW5fY21k X29uX21zZyBBTk5PVU5DRV9NQUlMRVIgJHttc2d9CisJZWxzZQorCQlfX3BrZ19hbm5vdW5j ZV90b19zbXRwICR7bXNnfQorCWZpCisJcm0gJHttc2d9Cit9CisKK19fcGtnX2Fubm91bmNl X3RvX3NtdHAoKSB7CisJbG9jYWwgbXNnPSQxCiAKIAlwZXJsIDwoY2F0IDw8RU9GCiB1c2Ug c3RyaWN0OwpAQCAtMjQyLDggKzI4Nyw4IEBAIGlmIChkZWZpbmVkIFwkc210cF91c2VyKSB7 CiBcJHNtdHAtPnF1aXQoKTsKIHByaW50ICJBbm5vdW5jZW1lbnQgc2VudFxuIjsKIEVPRgot KSAmJiBybSAkbXNnIHx8IGVycm9yICJTZW5kaW5nIGFubm91bmNlbWVudCBmYWlsZWQsIG1i b3ggaXMgJG1zZyIKKykgfHwgZXJyb3IgIlNlbmRpbmcgYW5ub3VuY2VtZW50IGZhaWxlZCwg bWJveCBpcyAkbXNnIgogfQogCiAjIHByb3RlY3QgZnVuY3Rpb25zCi1yZWFkb25seSAtZiBf X3BrZ191cGxvYWQgX19wa2dfYW5ub3VuY2UKK3JlYWRvbmx5IC1mIF9fcGtnX3VwbG9hZCBf X3BrZ19hbm5vdW5jZSBfX3BrZ19hbm5vdW5jZV9ydW5fY21kX29uX21zZyBfX3BrZ19hbm5v dW5jZV90b19zbXRwCi0tIAoyLjQzLjAKCg== --------------EADBBCA58531FC5A583F08B2--