From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout05.t-online.de (mailout05.t-online.de [194.25.134.82]) by sourceware.org (Postfix) with ESMTPS id 018F2385AE5D for ; Wed, 29 Jun 2022 07:55:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 018F2385AE5D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=t-online.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=t-online.de Received: from fwd86.dcpf.telekom.de (fwd86.aul.t-online.de [10.223.144.112]) by mailout05.t-online.de (Postfix) with SMTP id CBDA69F26 for ; Wed, 29 Jun 2022 09:55:13 +0200 (CEST) Received: from [192.168.2.102] ([87.187.34.65]) by fwd86.t-online.de with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted) esmtp id 1o6SXZ-02ODMO0; Wed, 29 Jun 2022 09:55:13 +0200 Subject: Re: [ITP] etckeeper 1.18.17-1 From: Christian Franke To: cygwin-apps@cygwin.com References: <36cc4e85-d20c-0f52-214d-88262f704efa@t-online.de> <20220628174122.arrqtskqzt6gzhxc@lucy.dinwoodie.org> <11b99205-0b36-a700-5a07-0ed35b3df641@t-online.de> Message-ID: Date: Wed, 29 Jun 2022 09:55:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 SeaMonkey/2.53.12 MIME-Version: 1.0 In-Reply-To: <11b99205-0b36-a700-5a07-0ed35b3df641@t-online.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TOI-EXPURGATEID: 150726::1656489313-01434903-BC488B90/0/0 CLEAN NORMAL X-TOI-MSGID: fdb689b1-dcee-4036-a331-01cc044bde27 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, FREEMAIL_FROM, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2022 07:55:34 -0000 Christian Franke wrote: > Adam Dinwoodie wrote: > ... > >> I'm also vaguely pondering whether it's worth adding git as a >> dependency.  That's not strictly right, since etckeeper doesn't *need* >> git, but it's going to be the use case for 99.9% of users, and in the >> absence of Cygwin having a "recommends" style dependency, just adding >> git seems like it might be sensible.  But I'm far from convinced there. > > I'm also not sure and decided to add no git dependency. 99.8% of the > users considering to install etckeeper may already have git installed :-) > > The Debian package does not use "rec" but "dep (git or hg or brz or > darcs)" which defaults to git. > If git is installed, the Debian postinst script runs 'etckeeper init > && etckeeper commit' on fresh installs. I decided to leave this to the > user. > A possible simple extension which would allow the user to choose between manual or automatic installation+initialization: Provide an optional package, for example "etckeeper-git-init", which depends on etckeeper+git and only contains /etc/postinstall/etckeeper-git-init.sh which triggers new initialization code in /etc/postinstall/zp_zzz_etckeeper-postinstall.sh via some file in /var/cache/etckeeper. This code performs 'etckeeper init && etckeeper commit' if and only if VCS=git is selected and /etc/.git does not exist. -- Regards, Christian