From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40811 invoked by alias); 4 May 2017 10:11:39 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 40601 invoked by uid 89); 4 May 2017 10:11:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=expectation, site, Hx-spam-relays-external:ESMTPA, HContent-Transfer-Encoding:8bit X-HELO: out4-smtp.messagingengine.com Received: from out4-smtp.messagingengine.com (HELO out4-smtp.messagingengine.com) (66.111.4.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 May 2017 10:11:26 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 32E5720AA1; Thu, 4 May 2017 06:11:27 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Thu, 04 May 2017 06:11:27 -0400 X-ME-Sender: Received: from [192.168.1.102] (host31-51-207-210.range31-51.btcentralplus.com [31.51.207.210]) by mail.messagingengine.com (Postfix) with ESMTPA id BB7C2244AB; Thu, 4 May 2017 06:11:26 -0400 (EDT) Subject: Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY) References: <20170428121205.12240-1-jon.turney@dronecode.org.uk> <20170428121205.12240-12-jon.turney@dronecode.org.uk> <3d79b33e-e067-c1df-9b90-084fb10dd272@dronecode.org.uk> <9452ab7f-986c-2394-8c24-6208e042787e@dronecode.org.uk> <506da115-b976-fdb2-bf1b-cec6addfbbbb@dronecode.org.uk> <0b6ab083-d470-c940-5557-d33be5c523cb@gmail.com> <664411e6-ac32-ab77-1b62-72bafc8bacd8@dronecode.org.uk> <60ed2d4e-7c89-a9b8-e3ab-e3d0819b7e56@gmail.com> Cc: =?UTF-8?Q?=c3=85ke_Rehnman?= To: cygwin-apps@cygwin.com From: Jon Turney Message-ID: Date: Thu, 04 May 2017 10:11:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <60ed2d4e-7c89-a9b8-e3ab-e3d0819b7e56@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2017-05/txt/msg00033.txt.bz2 On 03/05/2017 18:08, Åke Rehnman wrote: > On 2017-05-03 18:37, Jon Turney wrote: >> Thanks for the patch. So there are a few separate things here: >> >> * Pass unknown protocols to wininet >> >> This seems a fine idea, but isn't what this patch does. > Yea, I know, I tested a few different solutions but it was difficult to > make something clean and proper. Ok. >> >> * Allow wininet to handle file:// URLs >> >> I'm a little bit concerned that there may be current uses which rely >> on the incorrect parsing we do of file:// URLs to work. >> >> Otoh, this should fix the file:// URL format we currently mishandle, >> so is probably worth doing. > I don't know how that could have ever worked... (or does it?) Not really, see the other branch of this thread. >> >> * What to do with non-URL (i.e. pathname) addresses? >> >> Perhaps WinInet can handle these, but assuming it does, is there a >> good reason to change from using NetIO_File()? > No. WinInet need proper file://host/path syntax. But the patch I made > send those unknown protocols to NetIO_File(), right? Yes. I'll add a comment that "URLs we can't parse are assumed to be paths" and apply this, after I've released 2.878. Thanks for working on this. >> There are also some associated UI issues, in that we give no clue that >> a pathname is acceptable as a download site, and pathnames and file:// >> URLs are presented terribly in the download site list. >> > I saw that. Perhaps fixing that is another patch? Sure. I just mention that for completeness, not out of any expectation it's going to get fixed :)