From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118019 invoked by alias); 6 Mar 2018 16:38:16 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 118008 invoked by uid 89); 6 Mar 2018 16:38:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: out1-smtp.messagingengine.com Received: from out1-smtp.messagingengine.com (HELO out1-smtp.messagingengine.com) (66.111.4.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Mar 2018 16:38:14 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 9B8752094E for ; Tue, 6 Mar 2018 11:38:12 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Tue, 06 Mar 2018 11:38:12 -0500 X-ME-Sender: Received: from [192.168.1.102] (host86-151-121-236.range86-151.btcentralplus.com [86.151.121.236]) by mail.messagingengine.com (Postfix) with ESMTPA id 08C6524805 for ; Tue, 6 Mar 2018 11:38:11 -0500 (EST) Subject: Re: setup: problems with local install To: "cygwin-apps@cygwin.com" References: <3cd80653-6a63-ae3d-d79c-a1642ad63fce@cornell.edu> From: Jon Turney Message-ID: Date: Tue, 06 Mar 2018 16:38:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------F32AB8112DB41BE7A3A49292" X-SW-Source: 2018-03/txt/msg00009.txt.bz2 This is a multi-part message in MIME format. --------------F32AB8112DB41BE7A3A49292 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-length: 1516 On 06/03/2018 02:18, Ken Brown wrote: > On 3/5/2018 1:34 PM, Ken Brown wrote: >> This is a followup to the thread started here: >> >>    https://cygwin.com/ml/cygwin/2018-03/msg00027.html >> >> There are two problems with installing from a local directory. >> >> 1. In the Category view, "No packages found" is displayed where it >> should say "All" in the first line of the list.  This is probably just >> a cosmetic issue, and I haven't tried to track it down yet. > > This actually happens in all setup runs, not just local installs.  It > looks like it was caused by the rearranging that was done in the > following commit: > > commit 0c539f7f7d86fb100f260f21367682fa2c0bb529 > Author: Jon Turney > Date:   Sat Nov 4 18:01:49 2017 +0000 > >     Correctly order preparing packagedb for chooser > > I think the problem might be that createListview() is now called too > early in ChooserPage::OnInit().  But it's not immediately obvious to me > how to fix this without breaking something else. I'm kind of inclined to fix this with the attached: I think we only ever got "No packages found" before if there were 0 packages, which presumably doesn't happen very often :) We don't update this header if a search reduces the number of packages shown to 0, which might make some sort of sense. (Also, weirdly, we don't remove empty categories from view, except if we are doing a search, but this seems to be deliberate? (PickView.cc:311)) --------------F32AB8112DB41BE7A3A49292 Content-Type: text/plain; charset=UTF-8; name="0001-Always-give-the-fake-root-category-the-name-All.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Always-give-the-fake-root-category-the-name-All.patch" Content-length: 1940 RnJvbSAxYTBjZjBhODYwODhiNGFhZTdkNWExODk1M2Y3YzIxNGIwN2Q4YTAz IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gVHVybmV5IDxq b24udHVybmV5QGRyb25lY29kZS5vcmcudWs+CkRhdGU6IFR1ZSwgNiBNYXIg MjAxOCAxNjoxNzozMCArMDAwMApTdWJqZWN0OiBbUEFUQ0ggc2V0dXBdIEFs d2F5cyBnaXZlIHRoZSBmYWtlIHJvb3QgY2F0ZWdvcnkgdGhlIG5hbWUgJ0Fs bCcKCkFmdGVyIHdlIHJlYXJyYW5nZWQgdGhpbmdzIGluIDBjNTM5ZjdmLCBp dCdzIG5vdyB0b28gZWFybHkgdG8gdGVsbCBpZiB3ZQpoYXZlIGFueSBwYWNr YWdlcyBvciBub3QuCgpUaGUgb25seSB0aGluZyBhYm91dCB0aGlzIGNhdGVn b3J5IHRoYXQgaXMgZXZlciB1c2VkIGlzIGl0J3MgbmFtZSwgc28gd2UKZG9u J3QgYWN1YWxseSBuZWVkIHRvIHVzZSB0aGUgcmVhbCAnQWxsJyBjYXRlZ29y eSBoZXJlLgoKU2F5aW5nICdObyBwYWNrYWdlcyBmb3VuZCcgd2FzIG5ldmVy IHBhcnRpY3VsYXJseSBoZWxwZnVsIGhlcmUsIHNvIGp1c3QgdXNlCmEgZmFr ZSBjYXRlZ29yeSB3aXRoIHRoZSBmaXhlZCBuYW1lICdBbGwnLgotLS0KIGNo b29zZS5jYyB8IDcgKystLS0tLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0 aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9jaG9vc2Uu Y2MgYi9jaG9vc2UuY2MKaW5kZXggOWNmM2E1MC4uNWE0ZDNhZCAxMDA2NDQK LS0tIGEvY2hvb3NlLmNjCisrKyBiL2Nob29zZS5jYwpAQCAtMTM3LDExICsx MzcsOCBAQCBDaG9vc2VyUGFnZTo6Y3JlYXRlTGlzdHZpZXcgKCkKIHsKICAg U2V0QnVzeSAoKTsKICAgc3RhdGljIHN0ZDo6dmVjdG9yPHBhY2thZ2VtZXRh ICo+IGVtcHR5X2NhdDsKLSAgc3RhdGljIENhdGVnb3J5IGR1bW15X2NhdCAo c3RkOjpzdHJpbmcgKCJObyBwYWNrYWdlcyBmb3VuZC4iKSwgZW1wdHlfY2F0 KTsKLSAgcGFja2FnZWRiIGRiOwotICBwYWNrYWdlZGI6OmNhdGVnb3JpZXNU eXBlOjppdGVyYXRvciBpdCA9IGRiLmNhdGVnb3JpZXMuZmluZCgiQWxsIik7 Ci0gIENhdGVnb3J5ICZjYXQgPSAoaXQgPT0gZGIuY2F0ZWdvcmllcy5lbmQg KCkpID8gZHVtbXlfY2F0IDogKml0OwotICBjaG9vc2VyID0gbmV3IFBpY2tW aWV3IChjYXQpOworICBzdGF0aWMgQ2F0ZWdvcnkgZHVtbXlfY2F0IChzdGQ6 OnN0cmluZyAoIkFsbCIpLCBlbXB0eV9jYXQpOworICBjaG9vc2VyID0gbmV3 IFBpY2tWaWV3IChkdW1teV9jYXQpOwogICBSRUNUIHIgPSBnZXREZWZhdWx0 TGlzdFZpZXdTaXplKCk7CiAgIGlmICghY2hvb3Nlci0+Q3JlYXRlKHRoaXMs IFdTX0NISUxEIHwgV1NfSFNDUk9MTCB8IFdTX1ZTQ1JPTEwgfCBXU19WSVNJ QkxFLCZyKSkKICAgICB0aHJvdyBuZXcgRXhjZXB0aW9uIChUT1NUUklORyhf X0xJTkVfXykgIiAiIF9fRklMRV9fLAotLSAKMi4xNi4yCgo= --------------F32AB8112DB41BE7A3A49292--