* [PATCH libtirpc] Disable libtirpc's own bindresvport{,_sa}() in favor of Cygwin's [not found] ` <80645451-e2d6-56bf-87c4-c02ac801f201@maxrnd.com> @ 2018-02-07 7:29 ` Mark Geisert 2018-02-07 15:38 ` Eric Blake 2018-02-07 19:08 ` Yaakov Selkowitz 0 siblings, 2 replies; 6+ messages in thread From: Mark Geisert @ 2018-02-07 7:29 UTC (permalink / raw) To: cygwin-apps I don't have libtirpc in git so I'm submitting a text patch. Sorry for any inconvenience. This is Cygwin-specific and against src/bindresvport.c of libtirpc 1.0.1. Unsure if it ought to go upstream; appreciate input on that. Thanks much, ..mark --------8<-------- 35a36,38 > /* On Cygwin prefer Cygwin's bindresvport{,_sa}() to portable version here */ > #if !defined(__CYGWIN__) > 247a251,252 > > #endif /* !defined(__CYGWIN__) */ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH libtirpc] Disable libtirpc's own bindresvport{,_sa}() in favor of Cygwin's 2018-02-07 7:29 ` [PATCH libtirpc] Disable libtirpc's own bindresvport{,_sa}() in favor of Cygwin's Mark Geisert @ 2018-02-07 15:38 ` Eric Blake 2018-02-07 18:51 ` Brian Inglis 2018-02-07 19:08 ` Yaakov Selkowitz 1 sibling, 1 reply; 6+ messages in thread From: Eric Blake @ 2018-02-07 15:38 UTC (permalink / raw) To: cygwin-apps On 02/07/2018 01:29 AM, Mark Geisert wrote: > I don't have libtirpc in git so I'm submitting a text patch. Sorry for > any inconvenience. This is Cygwin-specific and against > src/bindresvport.c of libtirpc 1.0.1. Unsure if it ought to go > upstream; appreciate input on that. > Thanks much, > > ..mark > > --------8<-------- > 35a36,38 > > /* On Cygwin prefer Cygwin's bindresvport{,_sa}() to portable version > here */ An ed-script diff is practically useless; without context, it is too easy to misapply the patch if the file has been edited differently in the meantime. ALWAYS use 'diff -u' (what git does by default) or 'diff -c' when generating a patch, so that it has proper context. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH libtirpc] Disable libtirpc's own bindresvport{,_sa}() in favor of Cygwin's 2018-02-07 15:38 ` Eric Blake @ 2018-02-07 18:51 ` Brian Inglis 2018-02-07 21:03 ` Mark Geisert 0 siblings, 1 reply; 6+ messages in thread From: Brian Inglis @ 2018-02-07 18:51 UTC (permalink / raw) To: cygwin-apps On 2018-02-07 08:38, Eric Blake wrote: > On 02/07/2018 01:29 AM, Mark Geisert wrote: >> I don't have libtirpc in git so I'm submitting a text patch. Sorry for any >> inconvenience. This is Cygwin-specific and against src/bindresvport.c of >> libtirpc 1.0.1. Unsure if it ought to go upstream; appreciate input on that. >> Thanks much, >> >> ..mark >> >> --------8<-------- >> 35a36,38 >>  > /* On Cygwin prefer Cygwin's bindresvport{,_sa}() to portable version here */ > > An ed-script diff is practically useless; without context, it is too easy to > misapply the patch if the file has been edited differently in the meantime. > ALWAYS use 'diff -u' (what git does by default) or 'diff -c' when generating a > patch, so that it has proper context. Also mandatory to add -p, --show-c-function for patches, and in general for directory or recursive patch diffs -N, --new-file so new files are diffed as if against an empty file; --strip-trailing-cr is useful if some files may have CRs. -- Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH libtirpc] Disable libtirpc's own bindresvport{,_sa}() in favor of Cygwin's 2018-02-07 18:51 ` Brian Inglis @ 2018-02-07 21:03 ` Mark Geisert 0 siblings, 0 replies; 6+ messages in thread From: Mark Geisert @ 2018-02-07 21:03 UTC (permalink / raw) To: cygwin-apps Brian Inglis wrote: > On 2018-02-07 08:38, Eric Blake wrote: >> On 02/07/2018 01:29 AM, Mark Geisert wrote: >>> I don't have libtirpc in git so I'm submitting a text patch. Sorry for any >>> inconvenience. This is Cygwin-specific and against src/bindresvport.c of >>> libtirpc 1.0.1. Unsure if it ought to go upstream; appreciate input on that. >>> Thanks much, >>> >>> ..mark >>> >>> --------8<-------- >>> 35a36,38 >>> > /* On Cygwin prefer Cygwin's bindresvport{,_sa}() to portable version here */ >> >> An ed-script diff is practically useless; without context, it is too easy to >> misapply the patch if the file has been edited differently in the meantime. >> ALWAYS use 'diff -u' (what git does by default) or 'diff -c' when generating a >> patch, so that it has proper context. > > Also mandatory to add -p, --show-c-function for patches, and in general for > directory or recursive patch diffs -N, --new-file so new files are diffed as if > against an empty file; --strip-trailing-cr is useful if some files may have CRs. > Understood. Thanks for the advice. I knowingly took a risk here on the assumption nobody else would be working on this specific file. But with your advice I don't need to take that kind of risk again. And the patch will be more robust too. Cheers, ..mark ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH libtirpc] Disable libtirpc's own bindresvport{,_sa}() in favor of Cygwin's 2018-02-07 7:29 ` [PATCH libtirpc] Disable libtirpc's own bindresvport{,_sa}() in favor of Cygwin's Mark Geisert 2018-02-07 15:38 ` Eric Blake @ 2018-02-07 19:08 ` Yaakov Selkowitz 2018-02-07 21:04 ` Mark Geisert 1 sibling, 1 reply; 6+ messages in thread From: Yaakov Selkowitz @ 2018-02-07 19:08 UTC (permalink / raw) To: cygwin-apps [-- Attachment #1.1: Type: text/plain, Size: 567 bytes --] On 2018-02-07 01:29, Mark Geisert wrote: > I don't have libtirpc in git so I'm submitting a text patch. Sorry for > any inconvenience. This is Cygwin-specific and against > src/bindresvport.c of libtirpc 1.0.1. Unsure if it ought to go > upstream; appreciate input on that. As Eric mentioned, ed-script diffs are useless. Nonetheless, I have been following the discussion, and the correct fix is: https://github.com/cygwinports/libtirpc/blob/master/1.0.2-cygwin-bindresvport.patch libtirpc 1.0.2-2 is on its way to the mirrors. -- Yaakov [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH libtirpc] Disable libtirpc's own bindresvport{,_sa}() in favor of Cygwin's 2018-02-07 19:08 ` Yaakov Selkowitz @ 2018-02-07 21:04 ` Mark Geisert 0 siblings, 0 replies; 6+ messages in thread From: Mark Geisert @ 2018-02-07 21:04 UTC (permalink / raw) To: cygwin-apps Yaakov Selkowitz wrote: > On 2018-02-07 01:29, Mark Geisert wrote: >> I don't have libtirpc in git so I'm submitting a text patch. Sorry for >> any inconvenience. This is Cygwin-specific and against >> src/bindresvport.c of libtirpc 1.0.1. Unsure if it ought to go >> upstream; appreciate input on that. > > As Eric mentioned, ed-script diffs are useless. Nonetheless, I have > been following the discussion, and the correct fix is: > > https://github.com/cygwinports/libtirpc/blob/master/1.0.2-cygwin-bindresvport.patch > > libtirpc 1.0.2-2 is on its way to the mirrors. > Thank you for following the discussion and reworking the patch, Yaakov. Cheers, ..mark ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-07 21:04 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <59D90AF8D70E9740907BACDE2BCB520836E4AA63@RESW102.resdom01.local> [not found] ` <20180206142012.GB30794@calimero.vinschen.de> [not found] ` <80645451-e2d6-56bf-87c4-c02ac801f201@maxrnd.com> 2018-02-07 7:29 ` [PATCH libtirpc] Disable libtirpc's own bindresvport{,_sa}() in favor of Cygwin's Mark Geisert 2018-02-07 15:38 ` Eric Blake 2018-02-07 18:51 ` Brian Inglis 2018-02-07 21:03 ` Mark Geisert 2018-02-07 19:08 ` Yaakov Selkowitz 2018-02-07 21:04 ` Mark Geisert
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).