From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66011 invoked by alias); 27 Oct 2017 19:52:10 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 65999 invoked by uid 89); 27 Oct 2017 19:52:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: limerock04.mail.cornell.edu Received: from limerock04.mail.cornell.edu (HELO limerock04.mail.cornell.edu) (128.84.13.244) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Oct 2017 19:52:08 +0000 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id v9RJq6lX023761 for ; Fri, 27 Oct 2017 15:52:06 -0400 Received: from [10.13.22.3] (65-112-130-194.dia.static.qwest.net [65.112.130.194]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id v9RJq5xV029579 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Fri, 27 Oct 2017 15:52:05 -0400 Subject: Re: setup with experimental libsolv-based dependency solving To: cygwin-apps@cygwin.com References: <21eaf4d9-8014-bff3-64c1-eace55132a8b@cornell.edu> From: Ken Brown Message-ID: Date: Fri, 27 Oct 2017 19:52:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <21eaf4d9-8014-bff3-64c1-eace55132a8b@cornell.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-PMX-Cornell-Gauge: Gauge=X X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00155.txt.bz2 On 10/27/2017 2:57 PM, Ken Brown wrote: > On 10/25/2017 3:18 PM, Jon Turney wrote: >> >> This has a lot of internal changes, so could use some wider testing. >> Please test. > > I've just discovered a serious bug.  When installing from a local > directory that either doesn't exist or isn't a valid repository, setup > doesn't correctly read/write the installed file database > (/etc/setup/installed.db). I *think* the problem is that packagedb::read is never called. Since do_local_dir returns false, LocalDirPage::OnNext takes us directly to the chooser. This means that do_ini_thread never gets to the line that calls db.read. I could be completely wrong, but I'm throwing this out there because I don't have time to look at this any more right now. Ken