From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 6FA723858025 for ; Fri, 30 Oct 2020 10:23:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6FA723858025 Received: by mail-ej1-x636.google.com with SMTP id za3so7855938ejb.5 for ; Fri, 30 Oct 2020 03:23:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=htSJWjlov4Gi2N4S14hOS7B+BvWHmudBG996VKujL08=; b=VZXC5olbcr8Z6omaYNiw+B4TMiaPCx8ZwTRu3APR+FplZEwicbAJHuRydRllNU2c6g RIl0acqe95AgaPhY1hTMI0r3prtIGk2UbFZom5Xtq4cmGNWgrfeZYgRWLeSwwVp2XvBJ Yd9+/DogitrkJ/OBcjCs+8D0Q2vwThHVmxPz4JiIetuHQ9ulF0/cSNYeDaZyyFxpBBZl omwy9lwYxjtpt4vTeeKhY/Ym5pvR9wCOzBdNM67mK/1M+gUUKek3MzzW6nK/b/BhJFFx dGGFSn2b6VgFUc9iQNJnYOhsRPnFse0NaDknhYP6QEPiafiLn+f9qi9wbEFGEWHKF5v9 XMUg== X-Gm-Message-State: AOAM532dWHGFr9cf6NPT7S5LVdWl6Ir/8O5QPYyErdn85NoXqPVvcT99 bmNmy297+FBmfVAuIDg0w5y1N8pFaoewtQ== X-Google-Smtp-Source: ABdhPJy1rgygFaPP8Srsy8JSApZHLbCHyZ/CwpNZh19hPV+7QeffiXDxcPc0RuaJ73dh+OFdtOOCjA== X-Received: by 2002:a17:906:95d1:: with SMTP id n17mr1765277ejy.75.1604053393759; Fri, 30 Oct 2020 03:23:13 -0700 (PDT) Received: from [192.168.2.121] (p4fdb35c7.dip0.t-ipconnect.de. [79.219.53.199]) by smtp.gmail.com with ESMTPSA id p1sm2768056ejd.33.2020.10.30.03.23.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Oct 2020 03:23:13 -0700 (PDT) Subject: Re: [Attn.Maintainer] libarchive To: cygwin-apps@cygwin.com References: <87o8kovu0n.fsf@Rainer.invalid> From: Marco Atzeri Message-ID: Date: Fri, 30 Oct 2020 11:23:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <87o8kovu0n.fsf@Rainer.invalid> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: it Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2020 10:23:19 -0000 On 27.10.2020 11:32, Achim Gratz wrote: > > Hi Marco, > > the last release of libarchive hasn't been pushed to > > https://cygwin.com/git-cygwin-packages/?p=git/cygwin-packages/libarchive.git > > could that please be corrected? > > Also it is built without ZStd and LZO support (the former presumably > because you didn't have the headers installed and the latter because it > requires a configure argument). Looking into that I noticed that the > configury rolls in Cygwin with MSys and MinGW and produces the expected > nonsense, in particular the SSL library is not found that way. It works > slightly better via cmake, but that doesn't produce a correctly named > DLL, so I stopped there. Likewise there are tests for lrzip/grzip that > don't seem to have a corresponding configure option (or configure > tests), so I didn't try if they work. > > Here are the fixed up cygport file plus the configury patch: > > --8<---------------cut here---------------start------------->8--- > # -*- mode: sh; sh-shell: bash -*- > # inherit cmake # doesn't produce a correctly named library > BUILD_REQUIRES=" libbz2-devel zlib-devel libzstd-devel liblzo2-devel liblz4-devel liblzma-devel" > BUILD_REQUIRES+=" libiconv-devel libxml2-devel libssl-devel" > NAME="libarchive" > VERSION="3.4.3" > RELEASE="2" > CATEGORY="Archive" > SUMMARY="Multiple-format archive and compression library" > DESCRIPTION="Libarchive is a programming library that can create and read > several different streaming archive formats, including most popular tar > variants, several cpio formats, and both BSD and GNU ar variants. It can also > write shar archives and read ISO9660 CDROM images and ZIP archives. The bsdtar > program is an implementation of tar(1) that is built on top of libarchive. It > started as a test harness, but has grown into a feature-competitive replacement > for GNU tar." > HOMEPAGE="https://www.libarchive.org/" > SRC_URI="https://www.libarchive.org/downloads/${P}.tar.gz" > SRC_DIR="${P}" > > PKG_NAMES="${PN}13 ${PN}-devel bsdtar bsdcpio bsdcat" > eval ${PN}13_CONTENTS='"usr/bin/cygarchive-13.dll"' > libarchive_devel_CONTENTS="usr/include/ usr/lib/ usr/share/doc/ usr/share/man/man[35]/" > bsdtar_CONTENTS="usr/bin/bsdtar.exe usr/share/man/man1/bsdtar.*" > bsdcpio_CONTENTS="usr/bin/bsdcpio.exe usr/share/man/man1/bsdcpio.*" > bsdcat_CONTENTS="usr/bin/bsdcat.exe usr/share/man/man1/bsdcat.*" > > CYGCONF_ARGS="--with-lzo2" > --8<---------------cut here---------------end--------------->8--- > > --8<---------------cut here---------------start------------->8--- > --- origsrc/libarchive-3.4.3/configure.ac > +++ src/libarchive-3.4.3/configure.ac > @@ -86,13 +86,10 @@ AC_CANONICAL_HOST > > dnl Compilation on mingw and Cygwin needs special Makefile rules > inc_windows_files=no > -inc_cygwin_files=no > case "$host_os" in > *mingw* ) inc_windows_files=yes ;; > - *cygwin* | *msys*) inc_cygwin_files=yes ;; > esac > AM_CONDITIONAL([INC_WINDOWS_FILES], [test $inc_windows_files = yes]) > -AM_CONDITIONAL([INC_CYGWIN_FILES], [test $inc_cygwin_files = yes]) > > dnl Defines that are required for specific platforms (e.g. -D_POSIX_SOURCE, etc) > PLATFORMCPPFLAGS= > @@ -243,7 +240,7 @@ AM_CONDITIONAL([STATIC_BSDCPIO], [ test > > # Set up defines needed before including any headers > case $host in > - *mingw* | *cygwin* | *msys* ) > + *mingw* | *msys* ) > AC_DEFINE([_WIN32_WINNT], 0x0502, [Define to '0x0502' for Windows Server 2003 APIs.]) > AC_DEFINE([WINVER], 0x0502, [Define to '0x0502' for Windows Server 2003 APIs.]) > AC_DEFINE([NTDDI_VERSION], 0x05020000, [Define to '0x05020000' for Windows Server 2003 APIs.]) > @@ -316,7 +313,7 @@ AC_ARG_WITH([bz2lib], > if test "x$with_bz2lib" != "xno"; then > AC_CHECK_HEADERS([bzlib.h]) > case "$host_os" in > - *mingw* | *cygwin* | *msys*) > + *mingw* | *msys*) > dnl AC_CHECK_LIB cannot be used on the Windows port of libbz2, therefore > dnl use AC_LINK_IFELSE. > AC_MSG_CHECKING([for BZ2_bzDecompressInit in -lbz2]) > @@ -1089,7 +1086,7 @@ main(int argc, char **argv) > ]) > > case "$host_os" in > - *mingw* | *cygwin* | *msys*) > + *mingw* | *msys*) > ;; > *) > CRYPTO_CHECK(MD5, LIBC, md5) > @@ -1157,7 +1154,7 @@ if test "x$with_openssl" != "xno"; then > AC_CHECK_HEADERS([openssl/evp.h]) > saved_LIBS=$LIBS > case "$host_os" in > - *mingw* | *cygwin* | *msys*) > + *mingw* | *msys*) > case "$host_cpu" in > x86_64) > AC_CHECK_LIB(eay64,OPENSSL_config) > @@ -1198,7 +1195,7 @@ if test "x$found_LIBMD" != "xyes"; then > fi > > case "$host_os" in > - *mingw* | *cygwin* | *msys*) > + *mingw* | *msys*) > CRYPTO_CHECK_WIN(MD5, CALG_MD5) > CRYPTO_CHECK_WIN(SHA1, CALG_SHA1) > CRYPTO_CHECK_WIN(SHA256, CALG_SHA_256) > --8<---------------cut here---------------end--------------->8--- > > With these, the package builds correctly. I have a few test fails that > all look like ATWIL / permission problems to me and none look like they > weren't present before. > > If you'd rather have me co-maintain or adopt the package, let me know. You are the new maintainer > > Regards, > Achim. > Thanks Marco