From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cygwin-apps-return-39742-listarch-cygwin-apps=sources.redhat.com@cygwin.com>
Received: (qmail 83276 invoked by alias); 7 Sep 2019 15:08:05 -0000
Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm
Precedence: bulk
Sender: cygwin-apps-owner@cygwin.com
List-Id: <cygwin-apps.cygwin.com>
List-Subscribe: <mailto:cygwin-apps-subscribe@cygwin.com>
List-Archive: <http://sourceware.org/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps@cygwin.com>
List-Help: <mailto:cygwin-apps-help@cygwin.com>, <http://sourceware.org/lists.html#faqs>
Mail-Followup-To: cygwin-apps@cygwin.com
Received: (qmail 83263 invoked by uid 89); 7 Sep 2019 15:08:05 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FORGED_SPF_HELO,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=no version=3.3.1 spammy=Attached
X-HELO: sa-prd-fep-046.btinternet.com
Received: from mailomta17-sa.btinternet.com (HELO sa-prd-fep-046.btinternet.com) (213.120.69.23) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 07 Sep 2019 15:08:03 +0000
Received: from sa-prd-rgout-001.btmx-prd.synchronoss.net ([10.2.38.4])          by sa-prd-fep-046.btinternet.com with ESMTP          id <20190907150801.IBEI3834.sa-prd-fep-046.btinternet.com@sa-prd-rgout-001.btmx-prd.synchronoss.net>;          Sat, 7 Sep 2019 16:08:01 +0100
Authentication-Results: btinternet.com;    auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com
X-OWM-Source-IP: 86.173.196.55 (GB)
X-OWM-Env-Sender: jonturney@btinternet.com
X-VadeSecure-score: verdict=clean score=0/300, class=clean
Received: from [192.168.1.102] (86.173.196.55) by sa-prd-rgout-001.btmx-prd.synchronoss.net (5.8.337) (authenticated as jonturney@btinternet.com)        id 5D6FCC7300B4803E; Sat, 7 Sep 2019 16:08:01 +0100
Subject: Re: Updated cygport for for wxwidgets 3.0 package
To: "cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
References: <AM6PR04MB6101BDFF4D4C770CD54F82F2E7BB0@AM6PR04MB6101.eurprd04.prod.outlook.com>
From: Jon Turney <jon.turney@dronecode.org.uk>
Cc: hamishmb@live.co.uk
Message-ID: <b22bda6f-9886-8c7d-9b82-833d653f6e82@dronecode.org.uk>
Date: Sat, 07 Sep 2019 15:08:00 -0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <AM6PR04MB6101BDFF4D4C770CD54F82F2E7BB0@AM6PR04MB6101.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-09/txt/msg00010.txt.bz2

On 05/09/2019 17:36, Hamish MB wrote:
> Attached is a patch from git format-patch to upgrade the wxwxidgets
> version to 3.0.4. Next up I'll try to make a package for wxPython 4, but
> I have to get it to build first.

Thanks for attempting this.

Going forward, please consider that this patch does (at least) the 
following things:

* Removes existing patches
* Updates the version number
* Adds '-D_XOPEN_SOURCE=500 -D_DEFAULT_SOURCE' to CPPFLAGS
* Disables the webviewwebkit configuration option
* Removes the tests

It makes it a lot easier for someone to evaluate your patch if you give 
reasons for the changes in the patch commentary.