public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: Federico Kircheis <federico.kircheis@gmail.com>,
	"cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: nnn
Date: Mon, 10 Oct 2022 14:02:58 +0100	[thread overview]
Message-ID: <b37a11a3-833d-100e-4f7f-37d9f3174e6a@dronecode.org.uk> (raw)
In-Reply-To: <4d509e0f-bba2-477e-bd60-e82b5a730764@kircheis.it>

On 09/10/2022 14:54, Federico Kircheis wrote:
> Hello to everyone,
> 
> I would like to package nnn for cygwin
> 
> https://github.com/jarun/nnn/
> 
[...]

A few minor comments on the cygport:

> SUMMARY="nnn is a full-featured terminal file manager. It's tiny, nearly 0-config and incredibly fast."

SUMMARY probably shouldn't start with the name of the package, because 
it's often used in contexts where the name of the package appears 
immediately before it.

Generally, I think it should be just a noun phrase, not an entire sentence.

I'd suggest just "a full-featured terminal file manager"

> REQUIRES="libncursesw10 libreadline7"

It looks like these dependencies are successfully auto-detected, so you 
don't need to explicitly list them.

I added this to your authorized packages.


  reply	other threads:[~2022-10-10 13:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-09 13:54 nnn Federico Kircheis
2022-10-10 13:02 ` Jon Turney [this message]
2022-10-13 19:11   ` nnn Federico Kircheis
2022-10-14 16:35     ` nnn Jon Turney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b37a11a3-833d-100e-4f7f-37d9f3174e6a@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=cygwin-apps@cygwin.com \
    --cc=federico.kircheis@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).