From: Jon Turney <jon.turney@dronecode.org.uk>
To: Takashi Yano <takashi.yano@nifty.ne.jp>
Cc: cygwin-apps@cygwin.com
Subject: Re: [ITP] svt-av1
Date: Sun, 14 Jan 2024 18:59:19 +0000 [thread overview]
Message-ID: <b41e64c4-4129-4eb6-9351-c962e0d551ba@dronecode.org.uk> (raw)
In-Reply-To: <20240115002016.72eccc2e3f34d93bee027570@nifty.ne.jp>
On 14/01/2024 15:20, Takashi Yano via Cygwin-apps wrote:
> Thanks for reviewing.
No problem!
> On Sat, 13 Jan 2024 16:06:45 +0000
> Jon Turney wrote:
>> On 07/01/2024 10:42, Takashi Yano via Cygwin-apps wrote:
>>> #ifdef _WIN32
>>> -#define FOPEN(f, s, m) fopen_s(&f, s, m)
>>> +#define SVT_FOPEN(f, s, m) fopen_s(&f, s, m)
>>> #else
>>> -#define FOPEN(f, s, m) f = fopen(s, m)
>>> +#define SVT_FOPEN(f, s, m) f = fopen(s, m)
>>
>> This provokes my curiosity. Is there some reason for renaming this macro?
>>
>> (In general, feel free to provide commentary at the start of the patch
>> file on why it's doing what it's doing :))
>
> This is because FOPEN macro conflicts with the same name macro in
> cygwin's /usr/include/sys/_default_fcntl.h.
>
> I'll add comment. Thanks!
Hmm... go ahead.
How interesting. It seems like that might be also fixed by defining an
appropriate feature test macro e.g. _XOPEN_SOURCE, which turns off those
definitions in that header?
next prev parent reply other threads:[~2024-01-14 18:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-07 10:42 Takashi Yano
2024-01-13 15:40 ` Takashi Yano
2024-01-13 16:06 ` Jon Turney
2024-01-14 15:20 ` Takashi Yano
2024-01-14 18:59 ` Jon Turney [this message]
2024-01-15 3:14 ` Takashi Yano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b41e64c4-4129-4eb6-9351-c962e0d551ba@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-apps@cygwin.com \
--cc=takashi.yano@nifty.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).