From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sa-prd-fep-047.btinternet.com (mailomta7-sa.btinternet.com [213.120.69.13]) by sourceware.org (Postfix) with ESMTPS id 192B23858D20 for ; Sun, 14 Jan 2024 18:59:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 192B23858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dronecode.org.uk ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 192B23858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=213.120.69.13 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705258762; cv=none; b=x2owiOjnfoUdf7XE79K0npRVHtriItbcmUZ5RFsBci1TQSvy6x284+HrmD307hHra7kAeh5B3oTuTNpPvXfgTl0D/qeR10h5wWYjnJfx/IfnKWb3jZqn7KDxXeUsjQ9oNPnkRetEUIOE7FaQa1znWhn2blNSc3paMGcaWs+ro18= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705258762; c=relaxed/simple; bh=KtImmGVAoGq5A8vnGsTIvnVI05OZsv56BRN2ejC322s=; h=Message-ID:Date:MIME-Version:Subject:From:To; b=xY2HV29mr+XKJFDS0mz/2K51doWT5G1a3IwXyuT1jX9Mpga/s8G6RwP2Jhy2e1ECFOEJ777qKKhVlz2n65NTKRuaTftiFp/cc6OJk+4G5Mw5Olf2Cg8uxh+j2EPkKBx4459cv5WykEEpHq3dRC2IKabiGTmu4IDbUlI4QiZqXUY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from sa-prd-rgout-003.btmx-prd.synchronoss.net ([10.2.38.6]) by sa-prd-fep-047.btinternet.com with ESMTP id <20240114185920.YBMO9056.sa-prd-fep-047.btinternet.com@sa-prd-rgout-003.btmx-prd.synchronoss.net>; Sun, 14 Jan 2024 18:59:20 +0000 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 6567CD7105FABAD8 X-Originating-IP: [86.139.158.103] X-OWM-Source-IP: 86.139.158.103 X-OWM-Env-Sender: jon.turney@dronecode.org.uk X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeiledguddulecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfufhfhfevvfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpeefhfeghffghfduleffgfegfeetheejtdekieetiefhkefhleejvdehiefgleevfeenucfkphepkeeirddufeelrdduheekrddutdefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurddutdejngdpihhnvghtpeekiedrudefledrudehkedruddtfedpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtoheptgihghifihhnqdgrphhpshestgihghifihhnrdgtohhmpdhrtghpthhtohepthgrkhgrshhhihdrhigrnhhosehnihhfthihrdhnvgdrjhhppdhrvghvkffrpehhohhsthekiedqudefledqudehkedquddtfedrrhgrnhhgvgekiedqudefledrsghttggvnhhtrhgrlhhplhhushdrtghomhdprghuthhhpghushgvrhepjhhonhhtuhhrnhgvhiessghtihhn thgvrhhnvghtrdgtohhmpdhgvghokffrpefiuedpoffvtefjohhsthepshgrqdhprhguqdhrghhouhhtqddttdef X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.107] (86.139.158.103) by sa-prd-rgout-003.btmx-prd.synchronoss.net (authenticated as jonturney@btinternet.com) id 6567CD7105FABAD8; Sun, 14 Jan 2024 18:59:20 +0000 Message-ID: Date: Sun, 14 Jan 2024 18:59:19 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [ITP] svt-av1 Content-Language: en-GB References: <20240107194245.a39b189c87f162d3c2009d44@nifty.ne.jp> <20240115002016.72eccc2e3f34d93bee027570@nifty.ne.jp> From: Jon Turney Cc: cygwin-apps@cygwin.com To: Takashi Yano In-Reply-To: <20240115002016.72eccc2e3f34d93bee027570@nifty.ne.jp> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14/01/2024 15:20, Takashi Yano via Cygwin-apps wrote: > Thanks for reviewing. No problem! > On Sat, 13 Jan 2024 16:06:45 +0000 > Jon Turney wrote: >> On 07/01/2024 10:42, Takashi Yano via Cygwin-apps wrote: >>> #ifdef _WIN32 >>> -#define FOPEN(f, s, m) fopen_s(&f, s, m) >>> +#define SVT_FOPEN(f, s, m) fopen_s(&f, s, m) >>> #else >>> -#define FOPEN(f, s, m) f = fopen(s, m) >>> +#define SVT_FOPEN(f, s, m) f = fopen(s, m) >> >> This provokes my curiosity. Is there some reason for renaming this macro? >> >> (In general, feel free to provide commentary at the start of the patch >> file on why it's doing what it's doing :)) > > This is because FOPEN macro conflicts with the same name macro in > cygwin's /usr/include/sys/_default_fcntl.h. > > I'll add comment. Thanks! Hmm... go ahead. How interesting. It seems like that might be also fixed by defining an appropriate feature test macro e.g. _XOPEN_SOURCE, which turns off those definitions in that header?