From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sa-prd-fep-049.btinternet.com (mailomta6-sa.btinternet.com [213.120.69.12]) by sourceware.org (Postfix) with ESMTPS id 8428E3858425 for ; Fri, 13 Jan 2023 13:22:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8428E3858425 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from sa-prd-rgout-005.btmx-prd.synchronoss.net ([10.2.38.8]) by sa-prd-fep-049.btinternet.com with ESMTP id <20230113132248.QJDX6602.sa-prd-fep-049.btinternet.com@sa-prd-rgout-005.btmx-prd.synchronoss.net>; Fri, 13 Jan 2023 13:22:48 +0000 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 6139452E4BCF5981 X-Originating-IP: [81.153.98.246] X-OWM-Source-IP: 81.153.98.246 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvhedrleekgdegiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomheplfhonhcuvfhurhhnvgihuceojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukheqnecuggftrfgrthhtvghrnhepheduueevueejueejgeeufeehtddtkeevtdduieelfeetteeffeejjedukeefgffgnecuffhomhgrihhnpegthihgfihinhdrtghomhenucfkphepkedurdduheefrdelkedrvdegieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopegludelvddrudeikedruddruddtiegnpdhinhgvthepkedurdduheefrdelkedrvdegiedpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtoheptgihghifihhnqdgrphhpshestgihghifihhnrdgtohhmpdhrtghpthhtohepthgrkhgrshhhihdrhigrnhhosehnihhfthihrdhnvgdrjhhp X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.106] (81.153.98.246) by sa-prd-rgout-005.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 6139452E4BCF5981; Fri, 13 Jan 2023 13:22:48 +0000 Message-ID: Date: Fri, 13 Jan 2023 13:22:44 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: Version string of package Content-Language: en-GB To: Takashi Yano , "cygwin-apps@cygwin.com" References: <20230113205210.e23a2f47c2ffd6ea86d97541@nifty.ne.jp> From: Jon Turney In-Reply-To: <20230113205210.e23a2f47c2ffd6ea86d97541@nifty.ne.jp> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3570.0 required=5.0 tests=BAYES_00,FORGED_SPF_HELO,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 13/01/2023 11:52, Takashi Yano via Cygwin-apps wrote: > Hi, > > Is it allowed to include '-' in version string (e.g. '20230113-stable')? > I'm asking because mksetupini warns: > > mksetupini: file 'xxx.tar.xz' in package yyy contains '-' in version > > though it works as expected. Short answer: It's a bug that this isn't a fatal error. Please don't do it! Long answer: Package naming in Cygwin has a long and tangled history. This isn't explicitly precluded by the rules at [1], but probably should be. (Fedora, which we generally follow for packaging rules, now doesn't allow '-' in versions, just digits, letters and '.') We need to be able to unambiguously separate a NVR string into the package name, version and release. Underscores are allowed in package names, so the simple approach of splitting on the rightmost two hyphens would work, if we don't allow exceptions like this. (We can get it right in this case, because we have a piece of extra information: the directory the package is in, which happens to always be named N in the current scheme of things, but we might want to change that) [1] https://cygwin.com/packaging-package-files.html In any case, you should be suspicious of using upstream version names of this form. They may expect the 'stable' string to sort against other strings based on meaning, rather than alphabetically (e.g. '20230113-testing' is considered greater, which is probably not what's wanted)