From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout12.t-online.de (mailout12.t-online.de [194.25.134.22]) by sourceware.org (Postfix) with ESMTPS id DC4C4384F01E for ; Wed, 13 Jul 2022 15:39:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DC4C4384F01E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=t-online.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=t-online.de Received: from fwd76.dcpf.telekom.de (fwd76.aul.t-online.de [10.223.144.102]) by mailout12.t-online.de (Postfix) with SMTP id 8E3821D59E for ; Wed, 13 Jul 2022 17:39:28 +0200 (CEST) Received: from [192.168.2.102] ([87.187.34.65]) by fwd76.t-online.de with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted) esmtp id 1oBeSV-28rvAO0; Wed, 13 Jul 2022 17:39:28 +0200 Subject: Re: [PATCH setup 0/2] Simplify setting group ownership of installed files To: cygwin-apps@cygwin.com References: <20220712125449.14050-1-jon.turney@dronecode.org.uk> From: Christian Franke Message-ID: Date: Wed, 13 Jul 2022 17:39:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 SeaMonkey/2.53.12 MIME-Version: 1.0 In-Reply-To: <20220712125449.14050-1-jon.turney@dronecode.org.uk> Content-Type: multipart/mixed; boundary="------------B27EF0E8FA18D035BE1F9B88" X-TOI-EXPURGATEID: 150726::1657726768-01441FA6-A8101CBB/0/0 CLEAN NORMAL X-TOI-MSGID: 833a9cb2-89e1-4fd2-8619-7afc924c837f X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2022 15:39:37 -0000 This is a multi-part message in MIME format. --------------B27EF0E8FA18D035BE1F9B88 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Jon Turney wrote: > Jon Turney (2): > Drop group change while running postinstall scripts > Defer setting group until after All Users/Just For Me is chosen > > main.cc | 2 +- > postinstall.cc | 13 ------------- > root.cc | 5 +++++ > win32.cc | 13 ++----------- > win32.h | 2 +- > 5 files changed, 9 insertions(+), 26 deletions(-) > Works for me as expected. Primary group of dirs/files of "All Users" installed files are now local administrator (like before Feb 2012), including those generated by postinstall scripts (new behavior). As already mentioned in the '--no-write-registry' thread, "Just me" installs only work with non-elevated user and '-B' option. Attached is a temporary patch I used to log changes of root_scope variable. --------------B27EF0E8FA18D035BE1F9B88 Content-Type: text/plain; charset=UTF-8; name="log-root_scope-changes.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="log-root_scope-changes.patch" ZGlmZiAtLWdpdCBhL3N0YXRlLmNjIGIvc3RhdGUuY2MKaW5kZXggMTExYjg5MC4uYjRlMzQx MCAxMDA2NDQKLS0tIGEvc3RhdGUuY2MKKysrIGIvc3RhdGUuY2MKQEAgLTI0LDcgKzI0LDcg QEAgaW50IHNvdXJjZTsKIAogc3RkOjpzdHJpbmcgbG9jYWxfZGlyOwogCi1pbnQgcm9vdF9z Y29wZTsKK3Jvb3Rfc2NvcGVfaG9sZGVyIHJvb3Rfc2NvcGU7CiBpbnQgcm9vdF9tZW51Owog aW50IHJvb3RfZGVza3RvcDsKIApkaWZmIC0tZ2l0IGEvc3RhdGUuaCBiL3N0YXRlLmgKaW5k ZXggYjIxMWRlMy4uYzU2MWVhNSAxMDA2NDQKLS0tIGEvc3RhdGUuaAorKysgYi9zdGF0ZS5o CkBAIC0zMiw2ICszMiw3IEBACiAgKi8KIAogI2luY2x1ZGUgPHN0cmluZz4KKyNpbmNsdWRl ICJMb2dTaW5nbGV0b24uaCIKIAogZW51bSBhdHRlbmRfbW9kZSB7IGF0dGVuZGVkID0gMCwg dW5hdHRlbmRlZCwgY2hvb3Nlcm9ubHkgfTsKIGV4dGVybiBlbnVtIGF0dGVuZF9tb2RlIHVu YXR0ZW5kZWRfbW9kZTsKQEAgLTQyLDcgKzQzLDIyIEBAIGV4dGVybiBpbnQgc291cmNlOwog ZXh0ZXJuIHN0ZDo6c3RyaW5nIGxvY2FsX2RpcjsKIAogZXh0ZXJuIGludCByb290X3RleHQ7 Ci1leHRlcm4gaW50IHJvb3Rfc2NvcGU7CisKK2NsYXNzIHJvb3Rfc2NvcGVfaG9sZGVyCit7 CitwdWJsaWM6CisgIHZvaWQgb3BlcmF0b3I9KGludCB2KSB7CisgICAgaW50IG9sZCA9IHZh bDsKKyAgICB2YWwgPSB2OworICAgIExvZyhMT0dfVElNRVNUQU1QKSA8PCAicm9vdF9zY29w ZTogIiA8PCBvbGQgPDwgIiAtPiAiIDw8IHYgPDwgZW5kTG9nOworICB9CisgIG9wZXJhdG9y IGludCgpIGNvbnN0IHsgcmV0dXJuIHZhbDsgfQorcHJpdmF0ZToKKyAgaW50IHZhbCA9IDA7 Cit9OworCitleHRlcm4gcm9vdF9zY29wZV9ob2xkZXIgcm9vdF9zY29wZTsKKwogZXh0ZXJu IGludCByb290X21lbnU7CiBleHRlcm4gaW50IHJvb3RfZGVza3RvcDsKIAo= --------------B27EF0E8FA18D035BE1F9B88--