From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sa-prd-fep-048.btinternet.com (mailomta5-sa.btinternet.com [213.120.69.11]) by sourceware.org (Postfix) with ESMTPS id B682E3858D20 for ; Fri, 2 Dec 2022 12:10:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B682E3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from sa-prd-rgout-005.btmx-prd.synchronoss.net ([10.2.38.8]) by sa-prd-fep-048.btinternet.com with ESMTP id <20221202121038.LHKK1091.sa-prd-fep-048.btinternet.com@sa-prd-rgout-005.btmx-prd.synchronoss.net>; Fri, 2 Dec 2022 12:10:38 +0000 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 6139452E4629AB37 X-Originating-IP: [81.153.98.246] X-OWM-Source-IP: 81.153.98.246 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvhedrtdekgddufecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpeeuffegleegjeekveegjeehvdekjedvieegveekgeffffelveehffegteeftdeghfenucffohhmrghinhepphihphgrrdhiohdptgihghifihhnrdgtohhmnecukfhppeekuddrudehfedrleekrddvgeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurddutdeingdpihhnvghtpeekuddrudehfedrleekrddvgeeipdhmrghilhhfrhhomhepjhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukhdpnhgspghrtghpthhtohepvddprhgtphhtthhopegrtggvsehsvgiinhgrmhdrtgiipdhrtghpthhtoheptgihghifihhnqdgrphhpshestgihghifihhnrdgtohhm X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.106] (81.153.98.246) by sa-prd-rgout-005.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 6139452E4629AB37; Fri, 2 Dec 2022 12:10:38 +0000 Message-ID: Date: Fri, 2 Dec 2022 12:10:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: cygclass python-wheel setup.cfg-only projects To: Libor Ukropec , "cygwin-apps@cygwin.com" References: Content-Language: en-GB From: Jon Turney In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1192.0 required=5.0 tests=BAYES_00,FORGED_SPF_HELO,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 01/12/2022 22:20, Libor Ukropec wrote: > Hello, > > I have question to cygclass python-wheel. It seems that setup.py is > being omited in some python packages (here I faced it in the > python-fasteners) and as described here: > https://setuptools.pypa.io/en/latest/setuptools.html , chapter > "setup.cfg-only projects" > > > If setup.py is missing from the project directory when a PEP 517 > build is invoked, > > setuptools emulates a dummy setup.py file containing only a > setuptools.setup() call. > > Currently the cyglass requires the setup.py being present, otherwise it > throws error "No Python Distutils module detected" > > IMHO would be nice if the cygclass handle this case. Or should I create > a patch that inserts empty setup.py module instead? Yeah, it seems this is definitely something that needs updating in cygport, so thanks for pointing that out. It's fairly straightforward to drop the check at [1], or perhaps it's more appropriate to change it to check for either setup.py or setup.cfg? But then we want to run 'python -msetuptools.launch setup.py bdist_wheel' to build the wheel. In a very quick bit of research, it' seems the modern equivalent would be something like 'python -m build --wheel', but we don't seem to have a python-build package? I'm not very familiar with the evolving state of python packaging, so I think I may need a bit of help getting this right! [1] https://cygwin.com/git/?p=cygwin-apps/cygport.git;a=blob;f=cygclass/python-wheel.cygclass;h=b6ed68b4acda83ada549f898b9ebd611d8a4506f;hb=HEAD#l158