From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from m0.truegem.net (m0.truegem.net [69.55.228.47]) by sourceware.org (Postfix) with ESMTPS id 11BAC3858413 for ; Fri, 1 Sep 2023 10:28:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 11BAC3858413 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maxrnd.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=maxrnd.com Received: (from daemon@localhost) by m0.truegem.net (8.12.11/8.12.11) id 381ASU9h022670 for ; Fri, 1 Sep 2023 03:28:30 -0700 (PDT) (envelope-from mark@maxrnd.com) Received: from 50-1-247-226.fiber.dynamic.sonic.net(50.1.247.226), claiming to be "[192.168.4.101]" via SMTP by m0.truegem.net, id smtpdOVjMA2; Fri Sep 1 03:28:26 2023 Subject: Re: can't compile coreutils-9.3 any more after upgrade to cygwin-3.4.8 To: Cygwin-Apps References: <603386c9-d4a0-82cd-a8e4-02f298f9047b@maxrnd.com> From: Mark Geisert Message-ID: Date: Fri, 1 Sep 2023 03:28:26 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.4 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_NUMSUBJECT,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Corinna, Corinna Vinschen via Cygwin-apps wrote: > On Aug 30 20:10, Corinna Vinschen via Cygwin-apps wrote: >> On Aug 30 12:04, Brian Inglis via Cygwin-apps wrote: >>> On 2023-08-30 06:17, Corinna Vinschen via Cygwin-apps wrote: >>>> On Aug 30 11:57, Corinna Vinschen via Cygwin-apps wrote: >>>>> On Aug 30 11:34, Corinna Vinschen via Cygwin-apps wrote: >>>>>> #define CPU_ZERO_S(siz, set) __cpuset_zero_s (siz, set) >>>>>> -static __inline void >>>>>> -__cpuset_zero_s (size_t siz, cpu_set_t *set) >>>>>> -{ >>>>>> - (void) memset (set, 0, siz); >>>>>> -} >>>>>> +void __cpuset_zero_s (size_t, cpu_set_t *); >>>>>> [...] >>>>>> +__cpuset_zero_s (size_t siz, cpu_set_t *set) >>>>>> +{ >>>>>> + (void) memset (set, 0, siz); >>>>>> +} >>>>>> + >>>>>> } /* extern C */ >>>>> >>>>> Also, we can avoid an external __cpuset_zero_s function by just using a >>>>> loop, kind of like this: >>>> >>>> I attached a matching patch. Please give it a try. >>> >>> Shouldn't cpuset.h #include for size_t and for pid_t? >> >> It shouldn't need that. sys/cpuset.h is a non-standard header which is >> only included indirectly via sys/types.h. >> >> We may want to change from size_t to __size_t and from pid_t to __pid_t. >> That should eliminate any further dependency. > > Try this: After applying both patches to my system I was able to build coreutils without issues. After updating my local Cygwin tree's sched.cc and cygwin.din I rebuilt the Cygwin DLL without issues. I then tried recompiling a CPU affinity test program of mine (that uses cpusets) but it could not link due to missing __cpuset_alloc and __cpuset_free. I think this is likely a local issue of mine in copying newly-built stuff into place, though I've automated that process and do it frequently, so... ? I believe those two patches you wrote are fine. Ship when convenient, I say. Cheers & Regards, ..mark